From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E68CCA0508; Thu, 14 Apr 2022 13:48:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9142640687; Thu, 14 Apr 2022 13:48:30 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 26B7540041 for ; Thu, 14 Apr 2022 13:48:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649936908; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q8QCjT6tDiVF96u82p1yGMyvxYYYUjjKUQXQGpwUXII=; b=Rk41SABvn2LA+aKsBdgaX044GFD2iA8eBvfI8N4f85PlpFJRTvs+ntj5161MRaa11xSZfF vdqTu0ZXh9Do1mMMSSlz/nRj8jpReRvmm0K8eKuUGW4N4OLH6lpZq1P4ZR+YeRgJD7uovm JJAysW7Zq+4hPSb1R+0kl8O/0XLgGlc= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-21-NaDd6ibiOBaqyb0OSFpyJg-1; Thu, 14 Apr 2022 07:48:27 -0400 X-MC-Unique: NaDd6ibiOBaqyb0OSFpyJg-1 Received: by mail-lf1-f69.google.com with SMTP id bp19-20020a056512159300b0046bac0601a3so2225121lfb.1 for ; Thu, 14 Apr 2022 04:48:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=q8QCjT6tDiVF96u82p1yGMyvxYYYUjjKUQXQGpwUXII=; b=NAki9Z2kryu4yz3NX2foLo4722M1jDTvKfNw+Rwgx+lBbcKyP2rJt0HfOxyAcSD1ch mZoZhCsUNZ4udT/ktlhxJDW/OGFm8NeTX949Zm3RRtMKq6XdqOQ3JG+J5U/G2k6wbsGI Pyr66ejEGOdOeqlbqQuv4K8CDzS2URAFmoHdJM4Xh/w/dwQOh+XSUt1OXFPRsEiWrYcn slWZRm/eLUzDAPgcHQRaJ+m88JnHzCjJuVy2tbTCdL5r1eQRZztLRdrXChl3by5Llbp5 VQvNNEBrHtTPhWzbsBkiiYq6o4cqWreGjBB7rDa+8HehGgZvS99oXfJmBmhabO7ZIHQq MfmQ== X-Gm-Message-State: AOAM533/L1eF0IPAn+Dzw0T0SGJXiX5SfVVJ/lFI7PHYUp4j+qwe6FyX 5KN9HbBfo1HSK8Pe9JSpmBI55Spc8tqQXIGB7nphy8qHnsF/zG0vJGbeC8RTu4bFoZVWFYUbMT+ TQ/x1metOaFskQ/2BO94= X-Received: by 2002:a05:6512:398a:b0:44a:56b9:c03e with SMTP id j10-20020a056512398a00b0044a56b9c03emr1636088lfu.553.1649936905934; Thu, 14 Apr 2022 04:48:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxnQJ93tWvyT+/aYdg98Rli/SsX+YpjkOLukr/HO0+VQjY2Zg+lrtfAlaRH98OdMZLdpqYLTH1sbLiArVFHCms= X-Received: by 2002:a05:6512:398a:b0:44a:56b9:c03e with SMTP id j10-20020a056512398a00b0044a56b9c03emr1636069lfu.553.1649936905734; Thu, 14 Apr 2022 04:48:25 -0700 (PDT) MIME-Version: 1.0 References: <20220323093001.20618-1-david.marchand@redhat.com> <20220405163448.2099-1-david.marchand@redhat.com> <20220405163448.2099-2-david.marchand@redhat.com> In-Reply-To: <20220405163448.2099-2-david.marchand@redhat.com> From: David Marchand Date: Thu, 14 Apr 2022 13:48:14 +0200 Message-ID: Subject: Re: [PATCH v3 2/2] eal: factorize lcore main loop To: David Marchand Cc: dev , Thomas Monjalon , =?UTF-8?Q?Morten_Br=C3=B8rup?= , Tyler Retzlaff , Ray Kinsella , Bruce Richardson , Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Apr 5, 2022 at 6:37 PM David Marchand w= rote: > > All OS implementations provide the same main loop. > Introduce helpers (shared for Linux and FreeBSD) to handle synchronisatio= n > between main and threads and factorize the rest as common code. > Thread id are now logged as string in a common format across OS. > > Note: libabigail flags this change as breaking ABI in clang builds: > > 1 function with some indirect sub-type change: > > [C] 'function int rte_eal_remote_launch(int (void*)*, void*, unsigned > int)' at eal_common_launch.c:35:1 has some indirect sub-type > changes: > parameter 1 of type 'int (void*)*' changed: > in pointed to type 'function type int (void*)' at rte_launch.h:31:1= : > entity changed from 'function type int (void*)' to 'typedef > lcore_function_t' at rte_launch.h:31:1 > type size hasn't changed > > This is being investigated on libabigail side. > For now, we don't have much choice but to waive reports on this symbol. > > Signed-off-by: David Marchand > Acked-by: Morten Br=C3=B8rup > Acked-by: Tyler Retzlaff Added a note in the commitlog about Windows EAL threads affinity (from a parallel discussion with Tyler), and applied. Thanks. --=20 David Marchand