From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 768A4A0350; Mon, 29 Jun 2020 12:09:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 066D01B5E1; Mon, 29 Jun 2020 12:09:36 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 379B31B13C for ; Mon, 29 Jun 2020 12:09:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593425373; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YXFKypICVa3hBAbTmSqjzdfGTjTiXkHEaDnicxxyzZk=; b=b9PE4Z9mF8sd9jWwO6gdj/XI76a8kVwz2ZUD/YRa3aJ46ZfJcdOBq7vOkmwBMhjgHwcEvM 1zAcWEw/SdyDQo4QQyTrab9X1LoQU2FlfCn5/+gRTwjXVil/LNnvl9GFU6o+Q+5obFeeoD 1cD5oMViXA/GvLX5Pg3vebq8XlJr4wk= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-262-X52mfA5jPvSZ7ON9KIrVKw-1; Mon, 29 Jun 2020 06:09:31 -0400 X-MC-Unique: X52mfA5jPvSZ7ON9KIrVKw-1 Received: by mail-ua1-f72.google.com with SMTP id x25so4027108uap.10 for ; Mon, 29 Jun 2020 03:09:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YXFKypICVa3hBAbTmSqjzdfGTjTiXkHEaDnicxxyzZk=; b=YyxrZaNQ4TlepXc0zT2c3lyRVmt1CQyWMrcfn4Cv4vgC60WJlT+L5bbhn3BE5txgrP lNxqFFsJgl+E2512jZaoPqy+ZDo2vx8tU3ZZAM49078fn9RmSWeoUjLslNF8VzY1X5ro u/wKYu7EF8KlARRp5CNKsoxMYw5V1QaPR1ImizTg3KzvAHpHRmXnnONxnb5uSjasBYIh 6Vrios/fNlksTcgFRe3NHJwRvlZJZJej/Mq20JPcgn47/PwSxELXFsmdnl6PiaC6MUnH TF1zqngm5aAFR9C4qQBTOcF/NoJd2JJc61Cso8Ze/HqubzY9URDlatOO8Cs1vwXWDRLQ 94cw== X-Gm-Message-State: AOAM530jle8ShaPBVC3rhHHU4QCMVcL3PtDs9Eo/VxIDH98ARpGz41l0 W5hRNGK17Ji7znwgAgkEf/h1XhHpYIau+pGPCFpo17oHBOZ7Lw06so76VPJbmt1ZIAb/20bfJ4q tR0IpuyBaYaQGQQNh4i0= X-Received: by 2002:a1f:284a:: with SMTP id o71mr9243521vko.18.1593425371166; Mon, 29 Jun 2020 03:09:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy7Gl8uUi9oFrbfnZnHnZEOPD6V7F0Jhp7pe82X1fM6KazxFmmjbRs7mUiN6BohZjmrj6tIYaQwA5M8bJTxE6I= X-Received: by 2002:a1f:284a:: with SMTP id o71mr9243504vko.18.1593425370906; Mon, 29 Jun 2020 03:09:30 -0700 (PDT) MIME-Version: 1.0 References: <20200527145745.4060-1-bruce.richardson@intel.com> In-Reply-To: <20200527145745.4060-1-bruce.richardson@intel.com> From: David Marchand Date: Mon, 29 Jun 2020 12:09:20 +0200 Message-ID: To: Bruce Richardson Cc: dev , "Pattan, Reshma" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] app/test: fix build with ring pmd but no bond pmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, May 27, 2020 at 4:58 PM Bruce Richardson wrote: > > If the bonding pmd is disabled, all autotest associated with it should be > disabled. However, some of those tests also depended upon the ring PMD so > were placed in a block depending on that driver - and unfortunately that > driver alone. This caused build failures if the ring PMD was enabled but > the bonding PMD disabled, due to missing header files and driver libs. > > This error can be reproduced by configuring DPDK using e.g. > > meson configure -Ddisable_drivers=net/[!r]* build > > (which will disable all drivers not starting with "r"), and then building > using ninja. > > Fix this by moving all link bonding autotests to the one block and putting > a second conditional check within that block for those also requiring the > ring PMD. > > Fixes: 7f6ef1664027 ("test/bonding: allow disabling driver") > Fixes: 207b1c813f39 ("test: fix build without ring PMD") > Cc: reshma.pattan@intel.com > > Signed-off-by: Bruce Richardson > --- > app/test/meson.build | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/app/test/meson.build b/app/test/meson.build > index 1715ddbcb..dc2474699 100644 > --- a/app/test/meson.build > +++ b/app/test/meson.build > @@ -350,6 +350,10 @@ if dpdk_conf.has('RTE_LIBRTE_BOND_PMD') > test_deps += 'pmd_bond' > test_sources += ['test_link_bonding.c', 'test_link_bonding_rssconf.c'] > driver_test_names += ['link_bonding_autotest', 'link_bonding_rssconf_autotest'] > + if dpdk_conf.has('RTE_LIBRTE_RING_PMD') > + test_sources += 'test_link_bonding_mode4.c' > + driver_test_names += 'link_bonding_mode4_autotest' > + endif > endif > if dpdk_conf.has('RTE_LIBRTE_RING_PMD') > test_deps += 'pmd_ring' > @@ -358,7 +362,6 @@ if dpdk_conf.has('RTE_LIBRTE_RING_PMD') > test_sources += 'test_event_eth_tx_adapter.c' > test_sources += 'test_bitratestats.c' > test_sources += 'test_latencystats.c' > - test_sources += 'test_link_bonding_mode4.c' > test_sources += 'sample_packet_forward.c' > test_sources += 'test_pdump.c' > fast_tests += [['ring_pmd_autotest', true]] > @@ -366,7 +369,6 @@ if dpdk_conf.has('RTE_LIBRTE_RING_PMD') > fast_tests += [['event_eth_tx_adapter_autotest', false]] > fast_tests += [['bitratestats_autotest', true]] > fast_tests += [['latencystats_autotest', true]] > - driver_test_names += 'link_bonding_mode4_autotest' > fast_tests += [['pdump_autotest', true]] > endif > > -- > 2.25.1 > Reviewed-by: David Marchand Just a note. Looking at the makefile counterpart, I can see that if we disable the null driver, we would have an issue too. -- David Marchand