From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9897F460FC; Thu, 23 Jan 2025 14:13:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 763D340269; Thu, 23 Jan 2025 14:13:43 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id A040A40263 for ; Thu, 23 Jan 2025 14:13:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737638021; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pO7y0WEkpJJTD0RoijrS6KzBr+HmKbayIMYwDF39rZ0=; b=doLv3hE2eAveVpSaKWPC3PvvTZ/R0zP6qwSR1SYOLnxbSu//14NJj5P4ooS2Tkw9w+nwwL y/XaklW5JNrOnxyqOSL/fVD282BhDLgppuWuv1ch5YOgrVp06bAuL2J4khO0trpbyF9N2v 34wxYbAWrTannsnyImUUOIH3QxnPr+I= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-77-3QnK5Y3SNQ-BRmbaIkpLyw-1; Thu, 23 Jan 2025 08:13:40 -0500 X-MC-Unique: 3QnK5Y3SNQ-BRmbaIkpLyw-1 X-Mimecast-MFC-AGG-ID: 3QnK5Y3SNQ-BRmbaIkpLyw Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-306139caa6bso9209681fa.0 for ; Thu, 23 Jan 2025 05:13:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737638018; x=1738242818; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pO7y0WEkpJJTD0RoijrS6KzBr+HmKbayIMYwDF39rZ0=; b=bcgrPxbOvjkDu34VKa3qX3FvpvT5FqEPXtiZ7wF+RskbQX7p8I8CErTRAa5pKnhyVg 5rGF2mWcn+Mfh24PeZmzb069WUZIN+h8/QOg43mJQbztwSyHA+zpRNq1j+VcEYsT00Kh l/PSt6Abi1w8wgt5slOHbmdcIDOPp8GCch0HP9G9pUslCPRUuoHRljXB2QcKsCqaHVzZ INNParb4scQsWQA45ggKm/ovGon7OKbfOzl9uDt03He0J20+M83WaoF1RyN340/+oc2l JIW0B2jRaG0MBnGQBzaGn1YW30q0OwvKJUUX2c6LOqj2cBVWWEoMrNd/PnpF5I/afp6Z pQhA== X-Forwarded-Encrypted: i=1; AJvYcCUquZ6AkrH2JMHo9979RSK1Gg73Ysfxd0inXf9+E6xFALl9QcfpgTQN8rWVgZxmiB1GvpM=@dpdk.org X-Gm-Message-State: AOJu0YwHKNQlGr114fjR3HCvz11DVosVUCVKHv90aMgMd6MaqVe1rJFN MJ3zscqwraLhH4TZgmU2NF5EmwCgJ+BxXdI7kiEzLUt74o02oJwqPw4ghquirtdOOCiXfBrEVtw M53hlm8JX6mEQ6h3jNbitQE9Yp/Oh6y0hQKTgPO69BhBJncsWACm6c6ZHO656cCUdXA2uxjDe/J itk5VhrIU3PRjQsbo= X-Gm-Gg: ASbGncsQfXQwJRqNLAkUPT3auGvCPccryxlVJgm/W645KCEP/GKXz+bHQvf52rgHOUp Q3mJs00eJRdpR6UXTe9fWdc12GaIkZorDJEni5e4GzOPZrCdPISVTXw== X-Received: by 2002:a05:651c:10a3:b0:306:501:4762 with SMTP id 38308e7fff4ca-30761c1abe3mr9009721fa.16.1737638018412; Thu, 23 Jan 2025 05:13:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IE/I2LKZCFKLHPMOlTwNtGvUQkxLqBCAEkqWHhh3ShF3rijfkmait1yPWStEw+FDeL6Zw0YTwwPAbRXm/upSRc= X-Received: by 2002:a05:651c:10a3:b0:306:501:4762 with SMTP id 38308e7fff4ca-30761c1abe3mr9009631fa.16.1737638018048; Thu, 23 Jan 2025 05:13:38 -0800 (PST) MIME-Version: 1.0 References: <1736871673-25398-1-git-send-email-andremue@linux.microsoft.com> In-Reply-To: From: David Marchand Date: Thu, 23 Jan 2025 14:13:26 +0100 X-Gm-Features: AbW1kvYsPOasZKqL5DYTpG20qcy72oPU7bVSSbA3YxmqIVx78pHlkYZL4kYuTVY Message-ID: Subject: Re: [PATCH] eal: fix undeclared function error on old CPUs To: Andre Muezerie Cc: Konstantin Ananyev , Neil Horman , dev@dpdk.org, stable@dpdk.org, Bruce Richardson , pdamouny@nvidia.com X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: YKWvwhGKyUAswN5LCsdW-2FH9FnItgVmY14C_7KHh8s_1737638018 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jan 14, 2025 at 5:33=E2=80=AFPM Bruce Richardson wrote: > > On Tue, Jan 14, 2025 at 08:21:13AM -0800, Andre Muezerie wrote: > > Error reported: > > ../lib/net/net_crc_sse.c:49:17: error: call to undeclared function > > '_mm_clmulepi64_si128'; ISO C99 and later do not support implicit > > function declarations [-Wimplicit-function-declaration] > > > > The fix is to remove the unnecessary ifdef around the inclusion of > > header file immintrin.h. This header also contains functions that do > > not require AVX instructions, so should not be included only when AVX > > is available. > > > > Bugzilla ID: 1595 > > Fixes: da826b7135a4 ("eal: introduce ymm type for AVX 256-bit") > > Cc: stable@dpdk.org > > Reported-by: Pier Damouny > > Signed-off-by: Andre Muezerie > Acked-by: Bruce Richardson Applied, thanks Andre. --=20 David Marchand