From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 64C91A04B5; Fri, 11 Sep 2020 13:32:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B3A0A1BF90; Fri, 11 Sep 2020 13:32:30 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id AC87B1B9B7 for ; Fri, 11 Sep 2020 13:32:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599823949; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9caIkVin3uVZpWeEEkXaV6AkKMfohnk2CRaoMTsMpe4=; b=Yq6OomtokwChu1Ud1/SOtsrGeYGjGPxpgBUKLTVrtjkQ76i2TE7nPHDNUKVGCnbM7GQCRk uXOYL46rn3f/0Q1ISU131lA/l/Vd9LqRd0uqhoMEk5gzdhocIfd3uGmfmzu5wdVmPJ0i+8 8dT3SzJGDu3wCiGcJbYE0DU/QT1qajY= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-29-TpCPex_5O3W1nnxmRLi4Lw-1; Fri, 11 Sep 2020 07:32:27 -0400 X-MC-Unique: TpCPex_5O3W1nnxmRLi4Lw-1 Received: by mail-vk1-f200.google.com with SMTP id q69so2124260vka.12 for ; Fri, 11 Sep 2020 04:32:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9caIkVin3uVZpWeEEkXaV6AkKMfohnk2CRaoMTsMpe4=; b=i0/iqgFw7LlJa7DjlfW3/VODdB1wg6zKhIUhZ1K6tEmrpDe8Yf9KdEQV2KStHWaXgA Nj3XNnpuDYR/M96Y02ZtbnfroX8zmiva5ZPXEnzO7RIfMSaPuvpFDI0zEKbIg4TYKTFj 7TgMEZWtCYFdT89FnEFIT49KDceGGhrJlKH45BdG06YxzCfCIj7bpeAOUES7smIYm0T0 oJB9IRP2FcvfJUyocIu3sylkHlWHm5S8I8JWpzwGIxoiV9NctBs4SMKQCJm5uPlwKbkD NiVTdgLYFWpljVyCtip5v6CfWSmgFZ7ReaCWcEbhjnA/IiXpwIAuF9W4L8E931cKWY0n E2oA== X-Gm-Message-State: AOAM530RcJJ0ympjTfwBT9IzOm5kbbhnIlaCAQlE2GJEmSjIJWwFq7AR yS1mQPJbObegrRBiUSRhzSEp/hzMjgB/ek96f149I+i8EMdeltbdcEMALTzL39iN47JMHPBHZHT VZGCVrWcuv1Ai/J/YfXw= X-Received: by 2002:ab0:269:: with SMTP id 96mr630431uas.41.1599823946747; Fri, 11 Sep 2020 04:32:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyTwaGqu1TmAAbU3WryW48IqCN35C39ngs0mI76JDF7kJsQrs+EaWcmNH+JLNtweICPv8K7nFmPG3W575WWw4Y= X-Received: by 2002:ab0:269:: with SMTP id 96mr630422uas.41.1599823946527; Fri, 11 Sep 2020 04:32:26 -0700 (PDT) MIME-Version: 1.0 References: <20200910015525.59124-1-stevex.yang@intel.com> <20200911055811.16474-1-stevex.yang@intel.com> In-Reply-To: From: David Marchand Date: Fri, 11 Sep 2020 13:32:15 +0200 Message-ID: To: SteveX Yang , Bruce Richardson Cc: dev , Wenzhuo Lu , Beilei Xing , Qiming Yang , Kevin Traynor , Luca Boccassi , Thomas Monjalon , Ciara Power Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] app/test-pmd: fix meson build failed when enabled pmd_bonded X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Sep 11, 2020 at 9:43 AM David Marchand wrote: > > On Fri, Sep 11, 2020 at 8:15 AM SteveX Yang wrote: > > > > The depended pmd bond is missing for test-pmd. Add the pmd_bond to deps, > > and replace the relative MACRO name with new RTE_LIBRTE_BOND_PMD. > > meson changed the name of the driver define (when compared to make). It is likely we have other similar issues. I excluded the doc, since we have pending patches. *Disclaimer* My scripting might be buggy. $ git grep -h DIRS-..CONFIG_RTE_ v20.08 -- drivers/*/Makefile |sed -e 's#DIRS-$(CONFIG_\(.*\)).*$#\1#' |sort > make.tokens $ for meson in drivers/*/meson.build; do dir=$(dirname $meson); format=$(git grep 'config_flag_fmt =' $meson |cut -d \' -f 2); for drv in $dir/*; do drvname=$(basename $drv |tr '[a-z]' '[A-Z]'); echo $format |sed -e "s/@0@/$drvname/"; done; done |sort > meson.tokens $ for token in $(diff -u make.tokens meson.tokens |sed -n 's/^-\(RTE_LIBRTE.*\)/\1/p'); do output=$(git grep -l "$token\>" -- :^doc/) || continue; echo $token $output; done RTE_LIBRTE_PMD_AESNI_GCM app/test/test_cryptodev.c RTE_LIBRTE_PMD_AESNI_MB app/test/test_cryptodev.c app/test/test_cryptodev_hash_test_vectors.h RTE_LIBRTE_PMD_BOND app/test-pmd/cmdline.c app/test-pmd/parameters.c RTE_LIBRTE_PMD_CAAM_JR app/test/test_cryptodev.c RTE_LIBRTE_PMD_CCP app/test/test_cryptodev.c RTE_LIBRTE_PMD_CRYPTO_SCHEDULER app/test-crypto-perf/main.c app/test/meson.build app/test/test_cryptodev.c examples/l2fwd-crypto/main.c RTE_LIBRTE_PMD_DPAA2_EVENTDEV drivers/bus/fslmc/portal/dpaa2_hw_dpio.c RTE_LIBRTE_PMD_DPAA2_SEC app/test/test_cryptodev.c RTE_LIBRTE_PMD_DPAA_SEC app/test/test_cryptodev.c RTE_LIBRTE_PMD_KASUMI app/test/test_cryptodev.c RTE_LIBRTE_PMD_MVSAM_CRYPTO app/test/test_cryptodev.c RTE_LIBRTE_PMD_NITROX app/test/test_cryptodev.c RTE_LIBRTE_PMD_NULL app/test/test_cryptodev.c RTE_LIBRTE_PMD_OCTEONTX2_CRYPTO app/test/test_cryptodev.c app/test/test_cryptodev_asym.c RTE_LIBRTE_PMD_OCTEONTX_CRYPTO app/test/test_cryptodev.c app/test/test_cryptodev_asym.c RTE_LIBRTE_PMD_OPENSSL app/test/test_cryptodev.c app/test/test_cryptodev_asym.c RTE_LIBRTE_PMD_RING app/test/test_eal_flags.c RTE_LIBRTE_PMD_SNOW3G app/test/test_cryptodev.c RTE_LIBRTE_PMD_VIRTIO_CRYPTO app/test/test_cryptodev.c RTE_LIBRTE_PMD_ZUC app/test/test_cryptodev.c RTE_LIBRTE_SFC_EFX_PMD config/arm/meson.build Can this be looked at? Thanks. -- David Marchand