From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8FFB7A053A; Wed, 5 Aug 2020 10:00:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E8ADF37B4; Wed, 5 Aug 2020 10:00:26 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id E5F4829D2 for ; Wed, 5 Aug 2020 10:00:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596614424; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oMVKIJn8X37utrYkoAYVstVdbUOh5vrClRrioQGdHi0=; b=BX4LOTGEkd0VqbPhGOcEm3BVElsK5yX4uhwlitdgl7JEjBUKqPxp4ZbroD4jer1kX1qZ7r arVSiJJJNaUvrw591KJwHwv3xszKGIzy7FbtFlUC2KiC05RDjIV3+iyog1Hk62beG1Mxa+ 5L773rbvVt4AXWEUFHu+35492wUowlE= Received: from mail-oo1-f70.google.com (mail-oo1-f70.google.com [209.85.161.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-356-3lRaMFNRORa7P2Yev6Y5Cg-1; Wed, 05 Aug 2020 04:00:20 -0400 X-MC-Unique: 3lRaMFNRORa7P2Yev6Y5Cg-1 Received: by mail-oo1-f70.google.com with SMTP id f13so15150812oop.0 for ; Wed, 05 Aug 2020 01:00:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=oMVKIJn8X37utrYkoAYVstVdbUOh5vrClRrioQGdHi0=; b=SVB/q/nhnVlncBPXVRP8A+XB/+L7QCp8W+I5sp+4KB40GTztsPJ4hH+L6SOTe+tQKg ofVttMa5mmfaXcMpOT1Mqsac9mTlsOL2HMoglfmW3z5LwI4k7Y1mAbLv9QrktyMs6zUH kTuKNXh+XA4Es9IsBVIKtxkzx6AOiS3ncmgY4+o4kbN0M1RfJTlOmonFMryyroj5r6Jl Ueeq/Dw8NGDD7jTDdmbbSFoRFJD6qkFkd8LKHFLQMDwy+7yO2xfUc4wfyeFrleBbOmTN 3ES2HcCaY3JGCONnHTLewWzm507Nw2oUdfT6/lRanrL5zbg8BHoTmrRa/ULsSw1mZ5wJ +dLA== X-Gm-Message-State: AOAM5300uoy0SP1pH0fIXPUIkLrlxo1UUB1zqoZ58oBx0usEDnqX6g8m Vk3s/rUx1VWQYQ2wsp3OAim6lkb0WSEmB5L2vldDwd759Xgtu794KDvi9JggrWLh/yhnvaBy8XN QiPdiijjg+MS+dzGI+os= X-Received: by 2002:a9d:3df5:: with SMTP id l108mr1654910otc.369.1596614419416; Wed, 05 Aug 2020 01:00:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyVF1XEL9Bn1P1sx+tCo/GHPq93yAvtGwDXisvjLDxuJP9Z8UrfQjQbLXQE8GgUD2vz0jIWXACR5Y6kKvsgeho= X-Received: by 2002:a9d:3df5:: with SMTP id l108mr1654887otc.369.1596614419079; Wed, 05 Aug 2020 01:00:19 -0700 (PDT) MIME-Version: 1.0 References: <20200804175138.18543-1-pawelwod@gmail.com> In-Reply-To: <20200804175138.18543-1-pawelwod@gmail.com> From: David Marchand Date: Wed, 5 Aug 2020 10:00:07 +0200 Message-ID: To: Pawel Wodkowski Cc: dev , Jerin Jacob Kollanukkaran , Sunil Kumar Kori X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] tracepoint: fix compilation with C++ X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello Pawel, Thanks for contributing to DPDK. On Tue, Aug 4, 2020 at 7:52 PM Pawel Wodkowski wrote: > > trace_mem is declared as 'void *' which triggers following error: > '...invalid conversion from =E2=80=98void*=E2=80=99 to =E2=80=98__rte_tra= ce_header*=E2=80=99 > [-fpermissive]...' > > Fix this by changing void to struct __rte_trace_header I Cc'd trace maintainers. For subsequent revisions, you can do directly Cc them by calling the get-maintainer.sh script like this: $ git send-email --to dev@dpdk.org --cc-cmd devtools/get-maintainer.sh $pat= ch On the form of the patch, this patch is missing a signed-off tag, please have a look at the contribution guidelines: https://doc.dpdk.org/guides/contributing/patches.html Do not forget to chain replies using the --in-reply-to option for git send-email. This is a fix, so we expect a Fixes: tag in the commitlog. This tag should point at the original commit that introduced the issue. Looking at the CI report http://mails.dpdk.org/archives/test-report/2020-August/147927.html, you will see that the windows part is missing an update. $ git grep -wl trace_mem lib/librte_eal/common/eal_common_trace.c lib/librte_eal/include/rte_trace_point.h lib/librte_eal/windows/eal.c --=20 David Marchand