From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EA7F5A054D; Thu, 18 Feb 2021 10:33:47 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CD149160728; Thu, 18 Feb 2021 10:33:47 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 0283F40698 for ; Thu, 18 Feb 2021 10:33:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613640825; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k+twtUymrdiMN6H+X0O8li56eMLar/yypoPAiKwlCW0=; b=F9oWNzVyHkOW0T1f/XfziTnTCcIE1W1sIhBdNn/dSDeeUIcp6T7uKZ0LR28eA/BTMSNplA EJNl19DcsLH3mJGhx5TbCSd2wr1IsfrkHANxmma3mWwV0U8dHKPAXqrDWgIlf5TWzL7FNa wwybhcFyj6JgG72RBkzlumFv9IkFJP8= Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-35-p5rYYbOqN_quFoEES3E8Yw-1; Thu, 18 Feb 2021 04:33:43 -0500 X-MC-Unique: p5rYYbOqN_quFoEES3E8Yw-1 Received: by mail-ua1-f69.google.com with SMTP id d8so654949uad.13 for ; Thu, 18 Feb 2021 01:33:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=k+twtUymrdiMN6H+X0O8li56eMLar/yypoPAiKwlCW0=; b=ASBhGUGgh85+NQL3krVG0hl54cPwDrv6m2GRrcNhuG5pABOprMYXu9vAabaV5AeAna Bebg2IJkOOsi9zzyPZGnjUIXna4YSy83VJbX9WBrBhkAz3YJ7Wo5axh2CKW6cmugsE+L xkywzXkAiQ5GDElkYQaCiLyYHpB9TcOtwQJTIriLpKIFkoKXO3p9s3g2DtMF9BPDG9G3 pyy+Ful+YV+euihdpkFZwCZfutxJzbgRmyiKAiJDPj95gSfyryzAE7SSNpIKh7LPJ4jl Y/iyJOusO6NbRMvTzJydpXObjojG6RJ28yIlzSF+RW7zPWqwrTP00kjoxZYWII8J3X5Q SB7Q== X-Gm-Message-State: AOAM531fK2dZduc8O8IDAihCiKf5/SNb/WsfUVa5E0kdDX0CBSw3z1fz vdKxf6oVmzgcibuu0fqr2iQyXMQMwRUdv8WQPMq0wyqa2O0lcRNTNzcAz9E9e4SqsrrpQjSUvbv Bsgu/zMAOY3S6T+LHImg= X-Received: by 2002:ab0:780a:: with SMTP id x10mr1243850uaq.86.1613640823462; Thu, 18 Feb 2021 01:33:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJyPw0olqr27yb5YMwVK2rwJLoJfrh66z7CRXOqhWV8Wxo92AYPSa+2iTmY05RA3YhBfsC+pyNqLNeHokMb9ies= X-Received: by 2002:ab0:780a:: with SMTP id x10mr1243843uaq.86.1613640823253; Thu, 18 Feb 2021 01:33:43 -0800 (PST) MIME-Version: 1.0 References: <1611890309-99135-1-git-send-email-huawei.xhw@alibaba-inc.com> <1611890309-99135-2-git-send-email-huawei.xhw@alibaba-inc.com> In-Reply-To: <1611890309-99135-2-git-send-email-huawei.xhw@alibaba-inc.com> From: David Marchand Date: Thu, 18 Feb 2021 10:33:32 +0100 Message-ID: To: =?UTF-8?B?6LCi5Y2O5LyfKOatpOaXtuatpOWIu++8iQ==?= Cc: "Yigit, Ferruh" , Maxime Coquelin , dev , "Burakov, Anatoly" , xuemingl@nvidia.com, Gaetan Rivet , "Xia, Chenbo" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v6 1/2] bus/pci: use PCI standard sysfs entry to get PIO address X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jan 29, 2021 at 4:19 AM =E8=B0=A2=E5=8D=8E=E4=BC=9F(=E6=AD=A4=E6=97= =B6=E6=AD=A4=E5=88=BB=EF=BC=89 wrote: > > From: "huawei.xhw" > > Currently virtio PMD asssumes legacy device uses PIO bar. > There are three ways to get PIO(PortIO) address for virtio legacy device. > under igb_uio, get pio address from uio/uio# sysfs attribute > under uio_pci_generic: > for X86, get PIO address from /proc/ioport > for other ARCH, get PIO address from standard PCI sysfs attribute > > Actually, igb_uio sysfs attribute exports exactly the same thing as stand= ard PCI sysfs, i.e, > pci_dev->resource[] > > This patch fixes these messy things, and uses standard PCI sysfs attribut= e. I can not find what is being fixed. Could you elaborate? --=20 David Marchand