From: David Marchand <david.marchand@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>,
"Morrissey, Sean" <sean.morrissey@intel.com>
Cc: "Laatz, Kevin" <kevin.laatz@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Gaetan Rivet <gaetan.rivet@6wind.com>
Subject: Re: [dpdk-dev] [PATCH v2] Revert "eal: fix parsing option --telemetry"
Date: Mon, 29 Jul 2019 10:40:59 +0200 [thread overview]
Message-ID: <CAJFAV8x6qo_NgNwMBWfpP1zEAC5hh90O4xR-J3Z88Z5r3stWZQ@mail.gmail.com> (raw)
In-Reply-To: <5173895.pTg1DfyaZ9@xps>
On Sun, Jul 28, 2019 at 9:55 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> 25/07/2019 10:42, David Marchand:
> > > > > 24/07/2019 17:20, Sean Morrissey:
> > > On further investigation, the full fix involves
> > > a change in the EAL command line parameter handling,
> > > which is probably too risky for RC3.
>
> No way you change the command line parsing,
> except the rte_option which was created for telemetry.
> The history of this "simple" feature is already full
> of hesitations which made me hesitate to merge.
> Please, don't force me to dig in the code, otherwise
> I will be tempted to do a big "clean-up".
>
> > > This revert will allow telemetry to function again,
> > > but with the erroneous message still in place.
> > > We will aim to fix in the next release.
> >
> > Might be good to look and revisit the rte_option api.
>
The patch on eal did not make any sense.
I am for reverting it too.
About the real fix, I'd like to first see a description of the actual problem.
Thanks.
--
David Marchand
next prev parent reply other threads:[~2019-07-29 8:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 15:20 Sean Morrissey
2019-07-24 15:31 ` Thomas Monjalon
2019-07-24 16:28 ` Morrissey, Sean
2019-07-24 21:34 ` Thomas Monjalon
2019-07-25 8:38 ` Morrissey, Sean
2019-07-25 8:42 ` David Marchand
2019-07-28 19:55 ` Thomas Monjalon
2019-07-29 8:40 ` David Marchand [this message]
2019-07-29 9:22 ` Gaëtan Rivet
2019-07-29 20:06 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8x6qo_NgNwMBWfpP1zEAC5hh90O4xR-J3Z88Z5r3stWZQ@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
--cc=kevin.laatz@intel.com \
--cc=sean.morrissey@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).