From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9478BA0487 for ; Mon, 29 Jul 2019 10:41:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E1A191BF1A; Mon, 29 Jul 2019 10:41:12 +0200 (CEST) Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by dpdk.org (Postfix) with ESMTP id 439951BEB8 for ; Mon, 29 Jul 2019 10:41:11 +0200 (CEST) Received: by mail-io1-f66.google.com with SMTP id k20so118166797ios.10 for ; Mon, 29 Jul 2019 01:41:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4hBTbLZnFWjgOSMpaxDcdqxTBRoGE3RXNYZA0S9cPSQ=; b=ointSEmEQYWBo9pp0MjznwCRsf4lwzAJzQs8RnMia5Lvbu28ufwBI3pf2VIXQ6J1Yl eLqDt3hC0NnE35MYNMjwBfi1NyEK1SwfSOv7zOl8ljaKTtEB4az2Ob/1/16rcInY87n6 wE9skGrjYQ5WfD/pYqyZa0M88+UukZv3ebM0oct//7CslccBbep6rtXTLQDTFstcjdiR L82fVu5pzIiU/VGT15Y4R+CEVBwaDwckKlTam6wS+HmYb/7+ZdBlvdtbazGtGwkz8TBW etwAnECc3vqshvf+RkMhKNPqcgOkGrole7bzKB7zLBaGOZoNHBjIQTIVN7DrX4X50wcW 8T0w== X-Gm-Message-State: APjAAAUkgdOmQqHnkUoJ5gt4qY88ZhbYM4bSoGAFM4bpjddfe4IR4ZtQ C911R6kdzuZqtuNKtqnCyfEHpwZsn3ZbicFJQYMjhA== X-Google-Smtp-Source: APXvYqyKnGO+PNMaYbAM+FhTr8vamM611M5yqUT4Rhgv1iqeydzzn+WqVnZIU7z7ZnehDtyy/Y1vekfU6Q8mmeP/kU0= X-Received: by 2002:a5e:c241:: with SMTP id w1mr93966524iop.58.1564389670312; Mon, 29 Jul 2019 01:41:10 -0700 (PDT) MIME-Version: 1.0 References: <20190724152059.17859-1-sean.morrissey@intel.com> <5173895.pTg1DfyaZ9@xps> In-Reply-To: <5173895.pTg1DfyaZ9@xps> From: David Marchand Date: Mon, 29 Jul 2019 10:40:59 +0200 Message-ID: To: Thomas Monjalon , "Morrissey, Sean" Cc: "Laatz, Kevin" , "dev@dpdk.org" , Gaetan Rivet Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] Revert "eal: fix parsing option --telemetry" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, Jul 28, 2019 at 9:55 PM Thomas Monjalon wrote: > 25/07/2019 10:42, David Marchand: > > > > > 24/07/2019 17:20, Sean Morrissey: > > > On further investigation, the full fix involves > > > a change in the EAL command line parameter handling, > > > which is probably too risky for RC3. > > No way you change the command line parsing, > except the rte_option which was created for telemetry. > The history of this "simple" feature is already full > of hesitations which made me hesitate to merge. > Please, don't force me to dig in the code, otherwise > I will be tempted to do a big "clean-up". > > > > This revert will allow telemetry to function again, > > > but with the erroneous message still in place. > > > We will aim to fix in the next release. > > > > Might be good to look and revisit the rte_option api. > The patch on eal did not make any sense. I am for reverting it too. About the real fix, I'd like to first see a description of the actual problem. Thanks. -- David Marchand