From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ED6EFA0032; Tue, 16 Nov 2021 15:56:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AD86941168; Tue, 16 Nov 2021 15:56:43 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 762DA41165 for ; Tue, 16 Nov 2021 15:56:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1637074602; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fMd1nYHzsOK2QhK374zmzaagZmPguuIQQV2Clq7VBZw=; b=QYHETM8pp44RNx/Z3/XdtJFuvs0iXs7febDldVUHP8h1c/PF/usV27YSjaqmlajEDymcLz xKEPGSl2ws0bAryf7hWoUkfW1EiGUhfyvwC8Ku6JlIRGG1KmkPmlG1Ib51Af/MnTbK9wlf s7Yb+fMcUfjAMYFqONt3fLhpURLo+C4= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-585-w6sRfuZXN_GwN5tWfbOHvA-1; Tue, 16 Nov 2021 09:56:41 -0500 X-MC-Unique: w6sRfuZXN_GwN5tWfbOHvA-1 Received: by mail-lf1-f72.google.com with SMTP id k5-20020a05651210c500b0040934a07fbdso2590753lfg.22 for ; Tue, 16 Nov 2021 06:56:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fMd1nYHzsOK2QhK374zmzaagZmPguuIQQV2Clq7VBZw=; b=Xczcv/UxcZg/R6e/9CzegZStRl5bdKJPYYw9mGzA8tXnD/qrcyuG/Kan7E9UAoKnRb 94IosaItwi6HJ/bTUGy7ZHesjgVYNNtNozVAbOeFkIzGqI0aUIs8XMnzHGH6LJTeTIIV F2U1kE4NhWc+GkgBsXkYHBuBvPKLs5jXZKhTNtNNfwyd6AAmftVL6yfl+B+I6+rwR3Gw D5edSpLZu23qhpMfDrh0CVxA02nuwheZqY7sY6ZVl8YgIsAWCzGn6nWp4tdZHWn+x/4Q Miq4A9yzil6N58VPtRgMPSrAMqVSrdvREtalPyW+1tXpYPk1oie52l5ckgng+S4mDcsr 73KQ== X-Gm-Message-State: AOAM532GEuvfCtKGTIT7yfQbx+IMg10An/T/x1+Olkar3wnHXkarfMlj aSRNHRUP34JiU3NL5kU1vPrgLmEF/oVqPEgY39acaKQxvOjmNJdklx1JUq98gBYQGc3JKvXPenD REiQaWpzc81HV5WR+y3Y= X-Received: by 2002:a19:495c:: with SMTP id l28mr7285314lfj.484.1637074599499; Tue, 16 Nov 2021 06:56:39 -0800 (PST) X-Google-Smtp-Source: ABdhPJx3TkjtINu6zgefm/DkOmJDquh371EFKwehVzfA33tea74v1LiHAPxriDATpGvAGVS5OJKD5JSR6EPwP53G518= X-Received: by 2002:a19:495c:: with SMTP id l28mr7285296lfj.484.1637074599324; Tue, 16 Nov 2021 06:56:39 -0800 (PST) MIME-Version: 1.0 References: <20211004100304.13602-1-pbhagavatula@marvell.com> <20211105085712.3220-1-pbhagavatula@marvell.com> In-Reply-To: From: David Marchand Date: Tue, 16 Nov 2021 15:56:28 +0100 Message-ID: Subject: Re: [dpdk-dev] [PATCH v2] eal/arm: remove CASP constraints for GCC To: "pbhagavatula@marvell.com" , Ruifeng Wang , "jerinj@marvell.com" Cc: "dev@dpdk.org" , nd , Honnappa Nagarahalli , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Nov 8, 2021 at 8:15 AM Ruifeng Wang wrote: > > > -----Original Message----- > > From: pbhagavatula@marvell.com > > Sent: Friday, November 5, 2021 4:57 PM > > To: Ruifeng Wang ; david.marchand@redhat.com; > > jerinj@marvell.com > > Cc: dev@dpdk.org; Pavan Nikhilesh > > Subject: [dpdk-dev] [PATCH v2] eal/arm: remove CASP constraints for GCC > > > > From: Pavan Nikhilesh > > > > GCC now assigns even register pairs for CASP, the fix has also been > > backported to all stable releases of older GCC versions. > > Removing the manual register allocation allows GCC to inline the functions > > and pick optimal registers for performing CASP. > > > > Signed-off-by: Pavan Nikhilesh > Acked-by: Ruifeng Wang Patch lgtm but it is late for merging in 21.11. It is in EAL, and is an optimisation of the 128 bits cas operation on ARM. This is used by the stack library and mempool. There might be other impacts I did not think of. Do you have links to bugs or commits for the mentionned fix on gcc side? This will help when we get reports from users with compilers without the fix. Thanks. -- David Marchand