From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2BC71A04B1; Wed, 4 Nov 2020 11:42:48 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 96A92C8D2; Wed, 4 Nov 2020 11:42:46 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id DE0CDC8C8 for ; Wed, 4 Nov 2020 11:42:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604486562; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vLt9qc9Yt73b2rFb5j8Wv4FkPd19WT+shS76E4uXT00=; b=H+vV2L9TNjS7coE6SUvJzKbtNwKVMPE4aTsmiYKSV9AOzELmgeRLjl57dLVcUP1H1+bGrM PVv2EvaJctx8cIhhxDNv3eoeFkzX7mFddFWJBOY3ulncEXRExibNew1nRkmyOLJSZWmSnK Yv9p9sVvkftm/54E0YdxdCh6jMa6gDo= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-171-Ak2fadD5NEKn0Ka4sHIXfQ-1; Wed, 04 Nov 2020 05:42:37 -0500 X-MC-Unique: Ak2fadD5NEKn0Ka4sHIXfQ-1 Received: by mail-vk1-f199.google.com with SMTP id h123so764876vke.8 for ; Wed, 04 Nov 2020 02:42:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vLt9qc9Yt73b2rFb5j8Wv4FkPd19WT+shS76E4uXT00=; b=JOxiDhOWi3KnU3tLg9uONM2/efVDnvcEa6yHYzi+EBrLvmpzE4dhHbCCmrqyzzScrV 2xFJ4JOv24Sga78dQi3T3M/ubhWZOTMmGPZ1cWzYlD8JBgXRGNYsxeNkPefR2Sx7LuR2 1rWrs5naad2q6PKbWL6UGVtkzcLJorv9QbwJylHem3/JIJJMO/DXggh29nHSB8qU4Gyx LftHJuKOW6fiebRIbJ1DEMmnSOrC5Og+DXn6t82Rv3ObBv3FIyWfwAEcDLPDiaTVpoPc y1g3M6jru5kuP1G3EDn0eTT2epQDrKt3egZAqo/8cveVH+UIyA0SSbRNL4zmE35fZNOu ngGA== X-Gm-Message-State: AOAM530mv77qUH4UnxQAnQaQrwBFJKTjFz4zpovMxWIKw7WwRyqSM5BL LUkJvR7LbHCJDO9TJwPDs8kL1XQb/LQFOl7sUz/dA6GLZI8+jA0fyYIrqJdFSIV4medA77gYUBB X+JgkXEgcN803UykXxL8= X-Received: by 2002:a1f:38d2:: with SMTP id f201mr19187915vka.17.1604486556575; Wed, 04 Nov 2020 02:42:36 -0800 (PST) X-Google-Smtp-Source: ABdhPJwUmuQogOyiETapD5+aUvrvBE98QciX5i8nYbslhg7d+Eo2vnhSYHwTIYjss//sAIYzPne8/FFnC+jryL0PoS0= X-Received: by 2002:a1f:38d2:: with SMTP id f201mr19187899vka.17.1604486556256; Wed, 04 Nov 2020 02:42:36 -0800 (PST) MIME-Version: 1.0 References: <20201103183906.8088-1-david.marchand@redhat.com> <20201104094033.29674-1-david.marchand@redhat.com> <20201104103249.GD58@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20201104103249.GD58@bricha3-MOBL.ger.corp.intel.com> From: David Marchand Date: Wed, 4 Nov 2020 11:42:25 +0100 Message-ID: To: Bruce Richardson , Robin Jarry , Olivier Matz , Thomas Monjalon Cc: dev , Stephen Hemminger , Neil Horman , Rosen Xu , Andrew Rybchenko , Luca Boccassi Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] usertools: fix pmdinfo parsing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Nov 4, 2020 at 11:33 AM Bruce Richardson wrote: > > On Wed, Nov 04, 2020 at 10:40:33AM +0100, David Marchand wrote: > > This script inspects an ELF file (binary or shared library) and its > > linked dependencies by following DT_NEEDED tags. > > So far a simple librte_pmd prefix was used as a filter. > > Now that we changed the driver library names, update this heuristic with > > an explicit list of all driver classes. > > > > Fixes: a20b2c01a7a1 ("build: standardize component names and defines") > > > > Signed-off-by: David Marchand > > Acked-by: Robin Jarry > > --- > > Changelog since v1: > > - moved driver classes list as a class variable and did some cosmetic > > change for readibility, > > - used dpdk_driver_classes variable name in the hope that someone changing > > meson will catch this script too, > > Good idea, but probably not enough. I think adding a comment to the > meson.build file to update this as well would be good. I am reconsidering all this... The filtering stage in the pmdinfo script is unneeded. We need to find a PMD_INFO_STRING symbol in any case, which is good enough to find out this is a dpdk driver without relying on the library name. Parsing all libraries only impact for the user is a debug message print("Scanning %s for pmd information" % library). We might as well remove it or hide under a verbose option. -- David Marchand