From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C0155A0557; Sat, 22 Feb 2020 16:28:35 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 906401DBD; Sat, 22 Feb 2020 16:28:34 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 72619B62 for ; Sat, 22 Feb 2020 16:28:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582385312; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GhklmuLRMlSVL+PgRlU9g6ST1FXhZhtZIDMBeN1lkEA=; b=JtJCbj9QVa4KcqJ7mAk1EbNSKdxJP2eAbwoFrkqXSiGHzgWJeKS00uhQTVsny46wDCk6RI H2zT5KFZs3WOPw0f7zyq0Mwb0YbyrZ7jldpvnhds4mgvQkrR/DbCtFfk7sCNuvAh04a0bT KyuhhaaxLt90i0CJTp3mCY7eMLqWST0= Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-274-1s_5qPsjOsefmsnLWjMThw-1; Sat, 22 Feb 2020 10:28:27 -0500 X-MC-Unique: 1s_5qPsjOsefmsnLWjMThw-1 Received: by mail-ua1-f69.google.com with SMTP id i21so737999uac.10 for ; Sat, 22 Feb 2020 07:28:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0kL095dtBSxKkCej/mZ8nPoVULPnHk6GhWE/EhL04A4=; b=Z8mNcdJO4y+t93BOIMZPT35GJRn5qNztLIz4N9eZLijXKNd0Jdpuks3XyyARzPKXhd Z0lmCGy94HeOVBs25VnMllgg/yMWNRjqIZiaFbOLqv4pqqSfbYgCdwUy4ok0cY3Xyvm7 3YH9+gNuazX7EnW+4gIyQeAnNmxXC3/1xh0hQDAFNvMLiwBMUOuXj7x2CKM4kNktzeoa fEsrCfrs66Z3oIibYm/PYnFHWUgZ2dKG8qaYEUMzq5WX6ilLhYhe8PcPsG8XlDVVX1Gl yUh4k7PJVcbBtkxQDsM0r6E6reme5D1iz2xIBNyJON8JBEpzbzNo5epBk9bh2c9kZIV6 t/dg== X-Gm-Message-State: APjAAAUhABCqJhx5wThsQgzeySKk+zn/nqNhLducOmZxJzqrD1HraI4X pQgdik8eJTLj+VpOFrrM7R3zKg+oaz2DfIWMk6ygpE3ZL4YdBbduI71qAwyDuECDD0tKjPu8V2p xbbM7rUvL5yXhZo17dSU= X-Received: by 2002:ab0:618a:: with SMTP id h10mr21934304uan.53.1582385306759; Sat, 22 Feb 2020 07:28:26 -0800 (PST) X-Google-Smtp-Source: APXvYqxVyPM5lNMZsFNGocZ8wZoPK9XCm6twMh8oJn9vOSxAz3jSCOjsL2Qt2Kfp3ziNWhK61SQ5p96JKI87zWeoHrk= X-Received: by 2002:ab0:618a:: with SMTP id h10mr21934296uan.53.1582385306468; Sat, 22 Feb 2020 07:28:26 -0800 (PST) MIME-Version: 1.0 References: <1582204709-7992-1-git-send-email-wisamm@mellanox.com> <1582210386-27331-1-git-send-email-wisamm@mellanox.com> In-Reply-To: <1582210386-27331-1-git-send-email-wisamm@mellanox.com> From: David Marchand Date: Sat, 22 Feb 2020 16:28:15 +0100 Message-ID: To: Wisam Jaddo Cc: dev , Raslan , Thomas Monjalon , Olivier Matz , "Iremonger, Bernard" , dpdk stable X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v3] cmdline: increase maximum line length X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch is flagged as an ABI breakage: https://travis-ci.com/ovsrobot/dpdk/jobs/289313318#L2273 On Thu, Feb 20, 2020 at 3:53 PM Wisam Jaddo wrote: > > This increase due to the usage of cmdline in dpdk applications > as config commands such as testpmd do for rte_flow rules creation. > > The current size of buffer is not enough to fill > many cases of rte_flow commands validation/creation. > > rte_flow now can have outer items, inner items, modify > actions, meta data actions, duplicate action, fate action and > more in one single rte flow, thus 512 char will not be enough > to validate such rte flow rules. > > Such change shouldn't affect the memory since the cmdline > reading again using the same buffer. I don't get your point here. > Cc: stable@dpdk.org This is not a fix. --=20 David Marchand