From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 369BDA0032; Sat, 2 Oct 2021 16:43:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 20151411DB; Sat, 2 Oct 2021 16:43:19 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id EFF62411A0 for ; Sat, 2 Oct 2021 16:43:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633185797; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4ZoIiHIL2JZp5u5MT5VkNmzv3fRaRxoWJ7det58Ep3s=; b=EaQ+fb5Q+C2qWbBt5cQKOsYcfuB704fZaoJ6GY/WxzW1gKco6OeW1Uw2VdhA14J9u1yiCc S9wn8+2oveOQa7pG2mPSzfwyyvubnmuXxVCmPH0IwBf47hN/1m26XuAMGeWHsxLQthtWlk fs76dXEuceoVnuFFxQ/F4GOXM6uWlr8= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-540-ZrS607ruNCGe0lauCsHavQ-1; Sat, 02 Oct 2021 10:43:13 -0400 X-MC-Unique: ZrS607ruNCGe0lauCsHavQ-1 Received: by mail-lf1-f72.google.com with SMTP id f32-20020a0565123b2000b003fd19ba9acaso5910885lfv.10 for ; Sat, 02 Oct 2021 07:43:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4ZoIiHIL2JZp5u5MT5VkNmzv3fRaRxoWJ7det58Ep3s=; b=uRLahNMPuGm3CKn19CDsyDUDmbFqGGPAPFBm+Um0AAE04eqd9eBhlOykZqzWsKXmOh ivc70FBInEbijs+Zn9Aw+Nk8d+YufKYd9PrzxppPYLmq1uq4ncGsfJhVlKc+hF6aQfra 6cJp7VasBUZ2XQFTsz8SK5h0CNIs5DUBTFlpcbD6UaHgqFWOWaPlKPriQvtpXqJVP4Jy QPtJIP4a9S/Wq7Iblp6CML43XM1iBcRwqPGF/ptqIclTKTHeIsqx44PriLpcUqxosL19 AjUwDaquRTpnJRczNjHC1aD2hTvhTowxUW/Qjk4umAFqsYpcJ0FheB3lKupBIB94pI7m S6Yg== X-Gm-Message-State: AOAM530CCW51hi9DIO1URjiNnpdiT0twyVzsjMTQWqEUf0XKT1Wks7rT ItlXRyrRmewiC11dodqmGK+K6ZcJd98EgCVaHVscy3wiLdoyhukzrs5BZg4v6UAlfpej0hS3C0V l1+MHD6Z7Q1JbpzqKAgY= X-Received: by 2002:a2e:2f02:: with SMTP id v2mr4026752ljv.46.1633185792054; Sat, 02 Oct 2021 07:43:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyhlqtdZumPorJBxk2Zx3Jtp6+5QAX1YSbgACBpjGxS/MWph3tCoPSLFI+P+xAWqyFZgsZjAUYjBYVgLK1pGl8= X-Received: by 2002:a2e:2f02:: with SMTP id v2mr4026736ljv.46.1633185791809; Sat, 02 Oct 2021 07:43:11 -0700 (PDT) MIME-Version: 1.0 References: <20210913110635.130387-1-bruce.richardson@intel.com> <48d75bc2-ae55-183c-8132-6e3e150647af@intel.com> In-Reply-To: From: David Marchand Date: Sat, 2 Oct 2021 16:43:00 +0200 Message-ID: To: "Burakov, Anatoly" Cc: Bruce Richardson , dev , dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] eal/freebsd: lock memory device to prevent conflicts X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Sep 13, 2021 at 4:40 PM Burakov, Anatoly wrote: > >> I'm a bit uneasy with --in-memory mode pretending to work on > >> FreeBSD and Windows, but that's a separate problem :) > > > > Yes, it is, though one that does belong is the same area as this one. The > > "fix" is probably to just print a warning when --in-memory is used, > > informing the user that the flag is ignored and then continue. > > Alternatively we can error out, but I think the warn+continue is better, > > myself. > > I think erroring out is better. The feature is intended to work a > certain way, so if we can't guarantee that it does, we can't pretend it > is "supported" or "is working". But again, irrelevant to this patch :) > Please, can you review https://patchwork.dpdk.org/project/dpdk/patch/20210913140848.184928-1-bruce.richardson@intel.com/ ? Thanks. -- David Marchand