From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4481441C12; Mon, 6 Feb 2023 15:48:22 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 267FC42B7E; Mon, 6 Feb 2023 15:48:22 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id DE0EC427E9 for ; Mon, 6 Feb 2023 15:48:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675694898; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eLhQ8qNBndKcwO5gSPHr9IjgeCiB32PzPyjpBa4xdzw=; b=Jw+P1syH1ySABdQypFJ86xBym1TFwMa0QDNdvNkGHYD7LdueBsBP4RBU5RDcTsKr2N/uHY 5QquxO6y1NTwHWj00heRMik1pkuN/QT6dK4oOYxZP48B7YJnn/JfMJtT1g+xrBGv70R4+p YsxYQQeeEvayxqPBlec/dPtJ4L6yMyc= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-517-Z0sdF0_VO1SYOkUHK8uREg-1; Mon, 06 Feb 2023 09:48:15 -0500 X-MC-Unique: Z0sdF0_VO1SYOkUHK8uREg-1 Received: by mail-pj1-f71.google.com with SMTP id c4-20020a17090a674400b00230c06f525bso1552230pjm.2 for ; Mon, 06 Feb 2023 06:48:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eLhQ8qNBndKcwO5gSPHr9IjgeCiB32PzPyjpBa4xdzw=; b=LkbUoABqz9AAhzrb0+UL0RjLNAM2zta1HpR0v9lRjhRMx/1lUxQDi5KP/ZT/gHH5nb 6dg4O4TObTk71oNrm9ibSXfEdzJ07xE+CaeweuTjZy1CsfHVvSz6P0JeYrNGs457L1So So6oMoWf6ReJishXAS+SAxYJtJjeI6bipGpUb1VamKxP/0YUqoTkYF+Z+uWppdW6kyTr qb2yg8ppCt0isQhnfIwgZXeoemqsjlglX3smmDUQ6U2W969NbGDSDFDaF0xI+rsavGK2 Fe3+yAuPTfwolNHHVJ3NoG1/J6Jfy1JN8lSVAL/R4Vvq+SFOBpyGEv+jfKeEhqR6KFlr KiOQ== X-Gm-Message-State: AO0yUKUl3d9Bm0qpVijgzdi1y5YEJpQf5ZE/OJocfjd5t4pe8pMAFMAL DS/4v5/bI3OLNcEVzOLt4LL8vdN92Aj7iNq+OrDHCf4gMgCGPlMejAkuT4PbZdI3wxmrpH16B5x jOdLJgplCofk1h5iBm3Q= X-Received: by 2002:a17:90b:e17:b0:230:36c1:fde6 with SMTP id ge23-20020a17090b0e1700b0023036c1fde6mr3292084pjb.83.1675694894263; Mon, 06 Feb 2023 06:48:14 -0800 (PST) X-Google-Smtp-Source: AK7set+NaTnA3QvalTcSJDD26s2sw1hPrc4c2epRI9XiucTR1Lrq5octsxchBteph21IJteUmVa8alERAMokPB/r4IE= X-Received: by 2002:a17:90b:e17:b0:230:36c1:fde6 with SMTP id ge23-20020a17090b0e1700b0023036c1fde6mr3292072pjb.83.1675694893847; Mon, 06 Feb 2023 06:48:13 -0800 (PST) MIME-Version: 1.0 References: <20230123090229.3392071-1-adwivedi@marvell.com> <20230206115810.308574-1-adwivedi@marvell.com> <20230206115810.308574-2-adwivedi@marvell.com> In-Reply-To: <20230206115810.308574-2-adwivedi@marvell.com> From: David Marchand Date: Mon, 6 Feb 2023 15:48:02 +0100 Message-ID: Subject: Re: [PATCH v8 1/6] eal: trace: add trace point emit for blob To: Ankur Dwivedi Cc: dev@dpdk.org, thomas@monjalon.net, mdr@ashroe.eu, orika@nvidia.com, ferruh.yigit@amd.com, chas3@att.com, humin29@huawei.com, linville@tuxdriver.com, ciara.loftus@intel.com, qi.z.zhang@intel.com, mw@semihalf.com, mk@semihalf.com, shaibran@amazon.com, evgenys@amazon.com, igorch@amazon.com, chandu@amd.com, irusskikh@marvell.com, shepard.siegel@atomicrules.com, ed.czeck@atomicrules.com, john.miller@atomicrules.com, ajit.khaparde@broadcom.com, somnath.kotur@broadcom.com, jerinj@marvell.com, mczekaj@marvell.com, sthotton@marvell.com, srinivasan@marvell.com, hkalra@marvell.com, rahul.lakkireddy@chelsio.com, johndale@cisco.com, hyonkim@cisco.com, liudongdong3@huawei.com, yisen.zhuang@huawei.com, xuanziyang2@huawei.com, cloud.wangxiaoyun@huawei.com, zhouguoyang@huawei.com, simei.su@intel.com, wenjun1.wu@intel.com, qiming.yang@intel.com, Yuying.Zhang@intel.com, beilei.xing@intel.com, xiao.w.wang@intel.com, jingjing.wu@intel.com, junfeng.guo@intel.com, rosen.xu@intel.com, ndabilpuram@marvell.com, kirankumark@marvell.com, skori@marvell.com, skoteshwar@marvell.com, lironh@marvell.com, zr@semihalf.com, radhac@marvell.com, vburru@marvell.com, sedara@marvell.com, matan@nvidia.com, viacheslavo@nvidia.com, longli@microsoft.com, spinler@cesnet.cz, chaoyong.he@corigine.com, niklas.soderlund@corigine.com, hemant.agrawal@nxp.com, sachin.saxena@oss.nxp.com, g.singh@nxp.com, apeksha.gupta@nxp.com, sachin.saxena@nxp.com, aboyer@pensando.io, rmody@marvell.com, shshaikh@marvell.com, dsinghrawat@marvell.com, andrew.rybchenko@oktetlabs.ru, jiawenwu@trustnetic.com, jianwang@trustnetic.com, jbehrens@vmware.com, maxime.coquelin@redhat.com, chenbo.xia@intel.com, steven.webster@windriver.com, matt.peters@windriver.com, bruce.richardson@intel.com, mtetsuyah@gmail.com, grive@u256.net, jasvinder.singh@intel.com, cristian.dumitrescu@intel.com, jgrajcia@cisco.com, mb@smartsharesystems.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Feb 6, 2023 at 12:59 PM Ankur Dwivedi wrote: > > Adds a trace point emit function for capturing a blob. The blob > captures the length passed by the application followed by the array. > > The maximum blob bytes which can be captured is bounded by > RTE_TRACE_BLOB_LEN_MAX macro. The value for max blob length macro is > 64 bytes. If the length is less than 64 the remaining trailing bytes > are set to zero. > > This patch also adds test case for emit blob tracepoint function. > > Signed-off-by: Ankur Dwivedi > Acked-by: Morten Br=C3=B8rup > Acked-by: Sunil Kumar Kori > Acked-by: Jerin Jacob I came accross this patch while looking at CI failures. Giving my two cents. > diff --git a/lib/eal/include/rte_eal_trace.h b/lib/eal/include/rte_eal_tr= ace.h > index 5ef4398230..6f5c022558 100644 > --- a/lib/eal/include/rte_eal_trace.h > +++ b/lib/eal/include/rte_eal_trace.h > @@ -143,6 +143,12 @@ RTE_TRACE_POINT( > rte_trace_point_emit_string(func); > ) > > +RTE_TRACE_POINT( > + rte_eal_trace_generic_blob, > + RTE_TRACE_POINT_ARGS(const void *in, uint8_t len), > + rte_trace_point_emit_blob(in, len); > +) > + > #define RTE_EAL_TRACE_GENERIC_FUNC rte_eal_trace_generic_func(__func__) This new tracepoint is exported as a public API. So its underlying symbol __rte_eal_trace_generic_blob (part of the inlined implementation) is visible to applications: #define __RTE_TRACE_POINT(_mode, _tp, _args, ...) \ extern rte_trace_point_t __##_tp; \ static __rte_always_inline void \ _tp _args \ { \ __rte_trace_point_emit_header_##_mode(&__##_tp); \ __VA_ARGS__ \ } __rte_eal_trace_generic_blob must be exported as a versionned symbol (i.e. listed in EAL version.map). --=20 David Marchand