From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3E35E42F93; Wed, 2 Aug 2023 17:25:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2CEA7410DC; Wed, 2 Aug 2023 17:25:26 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id CD6F9410DC for ; Wed, 2 Aug 2023 17:25:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690989924; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wsjIU9zed3f++ZAm28d8foR57izB5ulKnNf3J5hgyX0=; b=caA3/iJYsf3gXRVjz75Yb3jdMszBiAfVVazXgx2iliYlvTSgtJoeOatn8Jq9+QRCETVLnt EVZwZKIVm9mFgfzO/Wy9DS0xqnzCwheEDsqVEyqAu+RJAH9Tzi1SDoBjo1S7c4BmWPKl/1 0Napjt7Io58ri6XHCKA1nMyT9E5DlVw= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-468-XlJ3TADBPdq45W8cnLOqpg-1; Wed, 02 Aug 2023 11:25:23 -0400 X-MC-Unique: XlJ3TADBPdq45W8cnLOqpg-1 Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-26814a011deso4989852a91.0 for ; Wed, 02 Aug 2023 08:25:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690989922; x=1691594722; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wsjIU9zed3f++ZAm28d8foR57izB5ulKnNf3J5hgyX0=; b=NXghimIV/Gdl+GgVZGgeKQzoDZscTFaXejsUbX/Xs7sKQakyUuyP9iNQBiep/u3K7a s9GbCg6E6m/c4l8EYF1IItieom/KBAvA2JVIpohBWf2S6Y/p0otM4gBDLnKImZYNTEta rUEAf2uWiQTlkmtdlVhBUJ8OCVzpKt7HIoPi5/O8gGd4hlVXquc++f66aI+NwAb5XCai 8jmQf0B8Lljzp5P7ULh3CxAbn1KLdueXAATCRjDA4+M6WaZ5mgsbvdbJoEQvcD/YNWl8 eCfOsn1SLww1DNOZdOZoJyQYKISR9T5S5Q+TPrm8k5TcpHT7JYHzKUSsO8F11UNU6ZfL Xt2g== X-Gm-Message-State: ABy/qLbIgj7qD3W1YuzLGKg8xLc2BAcZd7F1gpVq44p3XfPmNLjx+Gok V19NeN5vRIQtZD58bLpeym0G+671JgEdOXDp/df3wALDPiSIukKxmS2TGcPFqfI83vy30rs6Zzk QX3q94r/QPx29ERhutis= X-Received: by 2002:a17:90a:2ca2:b0:267:f9ab:15bb with SMTP id n31-20020a17090a2ca200b00267f9ab15bbmr13377233pjd.14.1690989922115; Wed, 02 Aug 2023 08:25:22 -0700 (PDT) X-Google-Smtp-Source: APBJJlFnfSwDs1m0Vwt9Gz+WHnR3xjn80HtpAP4RiWI4/Jut4+Nk7U/Pc68e3dfCpRasjKWNz1H9UPIZYHe2sek6p7k= X-Received: by 2002:a17:90a:2ca2:b0:267:f9ab:15bb with SMTP id n31-20020a17090a2ca200b00267f9ab15bbmr13377212pjd.14.1690989921853; Wed, 02 Aug 2023 08:25:21 -0700 (PDT) MIME-Version: 1.0 References: <20230726013517.216549-1-dmiller423@gmail.com> In-Reply-To: <20230726013517.216549-1-dmiller423@gmail.com> From: David Marchand Date: Wed, 2 Aug 2023 17:25:08 +0200 Message-ID: Subject: Re: [PATCH v3] Add support for IBM Z s390x To: David Miller Cc: dev@dpdk.org, Mathew S Thoennes , Konstantin Ananyev , Olivier Matz , Yipeng Wang , Sameh Gobriel , Bruce Richardson , Vladimir Medvedkin , Dmitry Kozlyuk , Yuying Zhang , Beilei Xing , Matan Azrad , Viacheslav Ovsiienko , Ori Kam , Suanming Mou , Qiming Yang , Wenjun Wu , Jakub Grajciar , Harman Kalra , Thomas Monjalon , David Christensen X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello David, On Wed, Jul 26, 2023 at 3:35=E2=80=AFAM David Miller = wrote: > > Minimal changes to drivers and app to support the IBM s390x. This seems a bit more than "minimal changes" :-). > > Signed-off-by: David Miller > Reviewed-by: Mathew S Thoennes > --- > app/test-acl/main.c | 4 + > app/test/test_acl.c | 1 + > app/test/test_atomic.c | 7 +- > app/test/test_cmdline_ipaddr.c | 12 +- > app/test/test_cmdline_num.c | 110 ++++ > app/test/test_hash_functions.c | 29 + > app/test/test_xmmt_ops.h | 14 + > buildtools/pmdinfogen.py | 11 +- > config/meson.build | 2 + > config/s390x/meson.build | 51 ++ > config/s390x/s390x_linux_clang_ubuntu | 19 + > doc/guides/nics/features/i40e.ini | 1 + > drivers/common/mlx5/mlx5_common.h | 9 + > drivers/net/i40e/i40e_rxtx_vec_s390x.c | 630 +++++++++++++++++++ > drivers/net/i40e/meson.build | 2 + > drivers/net/ixgbe/ixgbe_rxtx.c | 8 +- > drivers/net/memif/rte_eth_memif.h | 2 + > drivers/net/mlx5/mlx5_rx.c | 24 +- > drivers/net/octeontx/base/octeontx_pki_var.h | 6 + > examples/l3fwd/l3fwd_em.c | 8 + > examples/l3fwd/l3fwd_lpm_s390x.h | 137 ++++ > examples/l3fwd/l3fwd_s390x.h | 261 ++++++++ > lib/acl/acl_bld.c | 3 + > lib/acl/acl_gen.c | 9 + > lib/acl/acl_run_scalar.c | 8 + > lib/acl/rte_acl.c | 27 + > lib/acl/rte_acl.h | 5 +- > lib/eal/s390x/include/meson.build | 16 + > lib/eal/s390x/include/rte_atomic.h | 44 ++ > lib/eal/s390x/include/rte_byteorder.h | 43 ++ > lib/eal/s390x/include/rte_cpuflags.h | 41 ++ > lib/eal/s390x/include/rte_cycles.h | 44 ++ > lib/eal/s390x/include/rte_io.h | 184 ++++++ > lib/eal/s390x/include/rte_mcslock.h | 18 + > lib/eal/s390x/include/rte_memcpy.h | 55 ++ > lib/eal/s390x/include/rte_pause.h | 22 + > lib/eal/s390x/include/rte_power_intrinsics.h | 20 + > lib/eal/s390x/include/rte_prefetch.h | 46 ++ > lib/eal/s390x/include/rte_rwlock.h | 42 ++ > lib/eal/s390x/include/rte_spinlock.h | 85 +++ > lib/eal/s390x/include/rte_ticketlock.h | 18 + > lib/eal/s390x/include/rte_vect.h | 35 ++ > lib/eal/s390x/meson.build | 16 + > lib/eal/s390x/rte_cpuflags.c | 91 +++ > lib/eal/s390x/rte_cycles.c | 11 + > lib/eal/s390x/rte_hypervisor.c | 11 + > lib/eal/s390x/rte_power_intrinsics.c | 51 ++ > lib/hash/rte_fbk_hash.h | 7 + > lib/lpm/meson.build | 1 + > lib/lpm/rte_lpm.h | 2 + > lib/lpm/rte_lpm6.c | 18 + > lib/lpm/rte_lpm_s390x.h | 130 ++++ > meson.build | 2 + > 53 files changed, 2439 insertions(+), 14 deletions(-) - This is too big to review. Please split this patch separating the really minimum support (getting EAL and main libraries to build, disabling the rest that is "broken" for s390x) then adding more components support in later patches. RISC V and LoongArch "recent" additions are good examples. https://patchwork.dpdk.org/project/dpdk/list/?series=3D23380&state=3D%2A&ar= chive=3Dboth https://patchwork.dpdk.org/project/dpdk/list/?series=3D24969&state=3D%2A&ar= chive=3Dboth - We need one maintainer for this new architecture. - You'll notice that the DPDK CI reported issues, please fix them. - What are the plans in terms of CI? We need some compilation testing and ideally some regular runtime testing. Maybe you can reach out to IBM PPC DPDK guys, like David Christensen, to see what they are doing. --=20 David Marchand