From: David Marchand <david.marchand@redhat.com>
To: Ajit Khaparde <ajit.khaparde@broadcom.com>
Cc: dev <dev@dpdk.org>, Raslan Darawsheh <rasland@mellanox.com>,
Lance Richardson <lance.richardson@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>
Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix CLANG compilation error
Date: Mon, 20 Apr 2020 09:14:24 +0200 [thread overview]
Message-ID: <CAJFAV8x950fWQrMRfrzZ+_32WgNbSbeHaYWNHbed1AZqw80c5g@mail.gmail.com> (raw)
In-Reply-To: <20200420062638.80181-1-ajit.khaparde@broadcom.com>
On Mon, Apr 20, 2020 at 8:28 AM Ajit Khaparde
<ajit.khaparde@broadcom.com> wrote:
>
> Fix a compilation error seen with CLANG.
> The current code causes a typedef redefinition error because
> 'p__LINE__' is a C11 feature. Fixing it by defining it to something
> which is not already defined in the language.
Can't you reuse the RTE_BUILD_BUG_ON macro instead of redefining this
in your driver?
If the EAL macro is not enough, I suppose we could improve it.
--
David Marchand
next prev parent reply other threads:[~2020-04-20 7:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 6:26 Ajit Khaparde
2020-04-20 7:14 ` David Marchand [this message]
2020-04-20 12:22 ` Ferruh Yigit
2020-04-20 12:23 ` David Marchand
2020-04-20 12:49 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8x950fWQrMRfrzZ+_32WgNbSbeHaYWNHbed1AZqw80c5g@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=lance.richardson@broadcom.com \
--cc=rasland@mellanox.com \
--cc=somnath.kotur@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).