From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 482D0A0543; Fri, 28 Oct 2022 16:04:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2E94740E28; Fri, 28 Oct 2022 16:04:55 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 7A87E400D5 for ; Fri, 28 Oct 2022 16:04:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666965893; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kXMu4XQyh4WWwn4k9yOQZBT/HkG28MSyggjmxTssKEI=; b=GdQqbfOdoODM9xEJAtD59jGk8EUiMyRXBPrXy7BYh39gQPHz3pn6jPXggvl84EuqmSrn8N 3YWS2iqUq6e50AMIzi1r6hmOQQ4dgv76UrWOUPXaTi9S9OYNTRK195Fh4+6ybZI2VwI54Q XfFg3tIV/2DK1AxhGdA0r1yXnEwJ9b4= Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-621-BXTPogZ0OmSyZvC66GVidg-1; Fri, 28 Oct 2022 10:04:51 -0400 X-MC-Unique: BXTPogZ0OmSyZvC66GVidg-1 Received: by mail-pl1-f198.google.com with SMTP id j7-20020a170902da8700b0018540711393so3373204plx.18 for ; Fri, 28 Oct 2022 07:04:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kXMu4XQyh4WWwn4k9yOQZBT/HkG28MSyggjmxTssKEI=; b=aIaGV1I48TRt3Za0RGmvGMSQBR4g9oxbFrFVNwxUT9Ox0W6f8fvf2oZWNWDJX4c0LT MOJZtME9D9lVbwt3vvDtdwMZoz2jWoNfoykZcYLghJMyu3QhMMH71so4QDToY1+YVSYT y4U6zL/u9gt4gR/QI6Cbq9fkhCZKSUkbSEhrdoxSxOwTdBnRN+KxIvHNELuISKdMYtgL 0pCpHSKRmso5I6Kd3UepU8ZX5t2r4eylVMcv56ZY04ZT4xTXEbZ42bGltk0VhbXBAnfA MOzdhAJpTbnttIo9s//Srl80wuZ/g6nG4hwyxMnPgeiX7tN2FTVObBSo4pz33sLlNFZz ohbw== X-Gm-Message-State: ACrzQf09xVn7zQjeLYM8aZoaapcyo0VqiuU76vrZTZONeIzJ7lbfGq26 heKmq+zQWX/t1bvJuTyV4Orqt5YTMhWgaM1pxgJ5DlcIxU5IyffdvklRBmSw4rdOf1C95QBMFAK 2jJHsuzE5N7x5m9R7FR0= X-Received: by 2002:a63:5b58:0:b0:452:2ba4:f86b with SMTP id l24-20020a635b58000000b004522ba4f86bmr45625968pgm.223.1666965890740; Fri, 28 Oct 2022 07:04:50 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6IlxovbvYMSDrNzSuvqvGpqR6kOx+1e/mEHDlR43a6cQGyYqX1mwnUq85moHSvNyMH/Sv3O+eu9EZMjcvTTkY= X-Received: by 2002:a63:5b58:0:b0:452:2ba4:f86b with SMTP id l24-20020a635b58000000b004522ba4f86bmr45625950pgm.223.1666965890488; Fri, 28 Oct 2022 07:04:50 -0700 (PDT) MIME-Version: 1.0 References: <20221006190038.431828-1-megha.ajmera@intel.com> <20221028095531.678682-1-megha.ajmera@intel.com> <20221028095531.678682-3-megha.ajmera@intel.com> In-Reply-To: From: David Marchand Date: Fri, 28 Oct 2022 16:04:39 +0200 Message-ID: Subject: Re: [PATCH v6 3/3] sched: support for 100G+ rates in subport/pipe config To: "Dumitrescu, Cristian" , "Ajmera, Megha" Cc: "dev@dpdk.org" , "Singh, Jasvinder" , "stephen@networkplumber.org" , "stable@dpdk.org" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Oct 28, 2022 at 12:57 PM Dumitrescu, Cristian wrote: > > Subject: [PATCH v6 3/3] sched: support for 100G+ rates in subport/pipe > > config As mentionned in 2/3, the title prefix is incorrect. > > > > - Config load functions updated to support 100G rates > > for subport and pipes. > > - Added new parse function to convert string to unsigned > > long long. > > - Added error checks. > > - Fixed format warnings. I reformated this a bit as I don't understand why this patch deserves a list. > > > > Signed-off-by: Megha Ajmera > > --- > > examples/qos_sched/cfg_file.c | 179 +++++++++++++++++++++------------- > > examples/qos_sched/cfg_file.h | 2 + > > examples/qos_sched/init.c | 23 ++++- > > 3 files changed, 133 insertions(+), 71 deletions(-) > > > > Acked-by: Cristian Dumitrescu > Series applied with fixes. -- David Marchand