From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BA58FA0032; Sat, 2 Oct 2021 11:34:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3A8124067B; Sat, 2 Oct 2021 11:34:57 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 1C84840042 for ; Sat, 2 Oct 2021 11:34:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633167295; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=r8VB4SgHMxd+I+WCh+PIGzfaqKYO/xPj4n78zstRmgE=; b=GTUZpNalPvsKifS+mT+idodu+fBTue9PNogsSZmwV7nzAupPAJ3JkA+dIBsMMsiduR+pH6 on3jj9kgEeFMAiVNJygZeRRwmAkVU7I7w9KGKguYAreV5xANZB/oFFghX5YCEWrQCgiZhY ByKbQxct3Io2nS1b0HMQVwR6WvyFVlc= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-547-pIg_wCBeOpWcui-X8vQ-fA-1; Sat, 02 Oct 2021 05:34:54 -0400 X-MC-Unique: pIg_wCBeOpWcui-X8vQ-fA-1 Received: by mail-lf1-f69.google.com with SMTP id i40-20020a0565123e2800b003f53da59009so10704546lfv.16 for ; Sat, 02 Oct 2021 02:34:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=r8VB4SgHMxd+I+WCh+PIGzfaqKYO/xPj4n78zstRmgE=; b=LQWbJpqF+Zp2T1g1b2BM3VuXMJy4STfgsnGC/3U/1YOl84Cu/k2asXhTV4dHaH7RbE v8xWfRlyEk7L3t620GG9K9qZLN28zLHQIUrkgNscyDXGpPF7orJI/p7REQkYwHkSk/PE xvKVRbNPpEMKVL8IJxVRTzkPUkBAzvqTCVcfAV3owAVMRLhFjtUk8Z75LnSMkpqvbQr2 FF01CW9ihcLCbm+rUobxW1vCBgbThRfQeBRFtW3BEW4R9qfxQ1zYGwrHCOue36I7jhXV XInv6VRhahOTQRnZH7l9zn3eOTl2LvSAPZygCmalS73E54nIEtrnIh9KQU2bKD1VxNiu NUWQ== X-Gm-Message-State: AOAM530/wMX6429aypg1BYWWIFTqU33LxgZaMyUov+lgclpeJQDtBY// iux9Qyra9AfrpvgLrjr50KVblFK5IAW7kLnAfB80AwiChG4tXLJ6GQ+/PPKxhWDpNIjlH2gq3yg z3zVusWEwcyDrNl9bEoY= X-Received: by 2002:a05:6512:d2:: with SMTP id c18mr65508lfp.484.1633167292713; Sat, 02 Oct 2021 02:34:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw5IoAoiq63LPyFKps+4w7MPOM2c8E9PLFkE65tvbX1Dzv6Ttl9HS1Ru/JFrke6s52qlkyhl7/3C56ZVx24phk= X-Received: by 2002:a05:6512:d2:: with SMTP id c18mr65493lfp.484.1633167292493; Sat, 02 Oct 2021 02:34:52 -0700 (PDT) MIME-Version: 1.0 References: <20210825220958.91326-1-stephen@networkplumber.org> <20210831193507.43426-1-stephen@networkplumber.org> <20210831193507.43426-4-stephen@networkplumber.org> In-Reply-To: <20210831193507.43426-4-stephen@networkplumber.org> From: David Marchand Date: Sat, 2 Oct 2021 11:34:41 +0200 Message-ID: To: Stephen Hemminger Cc: dev , "Ananyev, Konstantin" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 3/4] mbuf: make rte_mbuf_tx_offload as stable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Aug 31, 2021 at 9:35 PM Stephen Hemminger wrote: > > This function should be made stable now. > > Also, fix the docbook comment format. > > Fixes: 8d9c2c3a1f01 ("mbuf: add function to generate raw Tx offload value") > Cc: konstantin.ananyev@intel.com > Signed-off-by: Stephen Hemminger > --- > lib/mbuf/rte_mbuf.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/mbuf/rte_mbuf.h b/lib/mbuf/rte_mbuf.h > index 7722b36ee44b..627790fe26e7 100644 > --- a/lib/mbuf/rte_mbuf.h > +++ b/lib/mbuf/rte_mbuf.h > @@ -1773,7 +1773,7 @@ static inline int rte_pktmbuf_chain(struct rte_mbuf *head, struct rte_mbuf *tail > return 0; > } > > -/* > +/** > * @warning > * @b EXPERIMENTAL: This API may change without prior notice. > * > @@ -1797,6 +1797,7 @@ static inline int rte_pktmbuf_chain(struct rte_mbuf *head, struct rte_mbuf *tail > * @return > * raw tx_offload value. > */ > +__rte_experimental >From title and description, I would expect we remove __rte_experimental tag, not add one. Can you clarify the intention? > static __rte_always_inline uint64_t > rte_mbuf_tx_offload(uint64_t il2, uint64_t il3, uint64_t il4, uint64_t tso, > uint64_t ol3, uint64_t ol2, uint64_t unused) > -- > 2.30.2 > -- David Marchand