From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 64504A009E; Sun, 27 Oct 2019 14:03:12 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8F3AF1BF1B; Sun, 27 Oct 2019 14:03:11 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 959331BF0B for ; Sun, 27 Oct 2019 14:03:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1572181389; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X0m+YJjuUa9PntMt+ulU14MjSWUqzvmkjsq6Os06O0c=; b=W7k0KxuHwGce8YxDSquFFS9A74E5dMwSGEC7JMICdgPYNZOsSqjzzY1M+2PQJfUs0YHpol wVE7Q8xBoETpLVXUKeWPlvQN6tuBZoE9I4X5jr0BIIlYstSkBsOmlgN599Pc37K71OTMis iYXvNF5AQEC0QVmM8/q+eh6F4UUQ9qc= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-298-8BxyK3u8PM-e39ZpKUc_lQ-1; Sun, 27 Oct 2019 09:03:08 -0400 Received: by mail-vk1-f200.google.com with SMTP id q187so3554611vkq.4 for ; Sun, 27 Oct 2019 06:03:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=u62tLW4Cgw9sRkNNPMJc8ZNbIEqpW4u14Jwl0ZL5IzU=; b=svlHIxmMDRULNYCdBb37s0Czspx5U7weHfEVFFOzpxYfC0JJiCSjebuZq7fbKBX0OV AsBko4OQ0pAhkE5tuxHDMgnqcR3wHT5kZiI9Ukd0k74VxwBe2QbFlS8otV3J3vmdcQOF bvyN2iWZBTIXTGmNfQ0JE62B9ugobmTPnxcOEcOgeOw/re3h1TTfxuHyAAwzLypBAvMv qMkbDW9sm5QL3a94oeJdfiO6DmwAe8TCDWGihxmNQa1/hmZzyaY0HHJSUwcixDlqxmhZ ePSxINN2uIpZgzCSqBD+glfa50wWrLHgLzZJMtL3+SVA7h0gjGea6hysd8IU+K/hUVMW ofiA== X-Gm-Message-State: APjAAAV022XMXYSgtRb9tFY1KjST6H/JeDHr/uYfZARq8Ew/v9q0xtfY pA3J5jzUNVDQMqVfAAtwLf9jYSWEntYMm08N1Ezw6zCS4kiXkJty9ddCdPgcllge7WuX2cEXjR4 vZif3W37GIVVnpofNYC0= X-Received: by 2002:a05:6102:d8:: with SMTP id u24mr2602136vsp.180.1572181388206; Sun, 27 Oct 2019 06:03:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqyDVlBjt9YGnj8cYxpb5AjUOZUK3TYChbw9nISLeHEUW2uSOIn3JEpDQjGXo2WhATxJDEwVcxOff4Ag2rPaioI= X-Received: by 2002:a05:6102:d8:: with SMTP id u24mr2602122vsp.180.1572181387760; Sun, 27 Oct 2019 06:03:07 -0700 (PDT) MIME-Version: 1.0 References: <20191025070101.34281-1-xiaoyun.li@intel.com> In-Reply-To: <20191025070101.34281-1-xiaoyun.li@intel.com> From: David Marchand Date: Sun, 27 Oct 2019 14:02:56 +0100 Message-ID: To: Xiaoyun Li Cc: Jingjing Wu , Xiaolong Ye , dev , dpdk stable X-MC-Unique: 8BxyK3u8PM-e39ZpKUc_lQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] examples/ntb: fix no return check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 25, 2019 at 9:03 AM Xiaoyun Li wrote: > This patch adds return value checking and error handling for > rte_rawdev_en/dequeue_buffers() and rte_eth_link_get(). Different class of issues are fixed in this patch, but the initial commit mixed different features too... Please split your patches in the future. > Coverity issue: 350247, 350250, 350251, 350252, 350253, 350254 > Fixes: 5194299d6ef5 ("examples/ntb: support more functions") > Cc: stable@dpdk.org No need for copying stable, the fixed commit is only in master and was not a fix itself. > Signed-off-by: Xiaoyun Li Applied, thanks. It is probably worth revisiting this code and validate the malloc() failures, or rework this and get rid of malloc. --=20 David Marchand