From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2A019A0C49; Tue, 15 Jun 2021 11:26:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E73734067A; Tue, 15 Jun 2021 11:26:08 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id CFD0E40140 for ; Tue, 15 Jun 2021 11:26:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623749166; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wfh/XiW/zvPchB35SfJ4qQ2pyHOw5Lo5Yhtsr7XyNm4=; b=QF50Dk5cDw1eTPX++9ooFtGmnsZQBLqya9wD7TScdLEk0Hcjp34N852DWd4OACxegmmW/+ Gpg33ogvYdZFnbLVr57jyLRLtyPuUzh+rThC0XA5dw1tZ1Drp/PFxXQCftwA4TI+uEZRbB 7FoXvuNngwKbYKESTpQpxw2bZv+4Orc= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-433-elCDLB9AO9K0VHi-M2CTMQ-1; Tue, 15 Jun 2021 05:26:04 -0400 X-MC-Unique: elCDLB9AO9K0VHi-M2CTMQ-1 Received: by mail-ua1-f72.google.com with SMTP id k13-20020a9f30cd0000b029025e3e26edb8so3958738uab.9 for ; Tue, 15 Jun 2021 02:26:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wfh/XiW/zvPchB35SfJ4qQ2pyHOw5Lo5Yhtsr7XyNm4=; b=RVGExll/54Gp+wHXTiw1K5ceIyI9t96GqiFVjdrxBr6HNlSvFYGC1hYV7BBlh8FTIR Ik1NKv3YEtDBS2uewcvO6sEQjVc9vxrkkTzvHmk045xa12ep0OFCiRETDHHfTkTWScPk /Ckc1j+4e8b2tNRpnQ1dFILzBSO7QCUUYo97Pda/6OXLfuY5OUMAV4qKiKYN1M2vG4Gf rxpAro09Ajgv54wOjxDjjHn0jfVkAVSDtlDl6wgkfyoO5f4DOOHlmdjuD3azb7ady0UD ugGNPl5pERSJha/xpTq764MGFj4MYBD6xPua5XFZQWYKbK8pC6M8QvshOKG4+cVKes9j jtUQ== X-Gm-Message-State: AOAM530tkYsveJoSJymXpM2lNB7usikLb+ck5IZzpTz9S48zU9sW5x0c LvcTsSSQo764V5EFFV2rY9tPHcHpEz8MgNOC40SxdlbhB01d8AgLa5auDR4EUDxJ92NT653qZ9X Wnxkxvjlk2gLDzVNnq6o= X-Received: by 2002:a05:6102:67a:: with SMTP id z26mr1136532vsf.10.1623749164328; Tue, 15 Jun 2021 02:26:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy935AwAYa5XJXQIhoo76NFnafnRxdmIvy45ePbH5Usneylsi/pXfbgaWr5K/PwVFtzRYjQLqUgbBPyjwkIs0Q= X-Received: by 2002:a05:6102:67a:: with SMTP id z26mr1136516vsf.10.1623749164045; Tue, 15 Jun 2021 02:26:04 -0700 (PDT) MIME-Version: 1.0 References: <20210615084241.139097-1-maxime.coquelin@redhat.com> <20210615084241.139097-7-maxime.coquelin@redhat.com> In-Reply-To: <20210615084241.139097-7-maxime.coquelin@redhat.com> From: David Marchand Date: Tue, 15 Jun 2021 11:25:52 +0200 Message-ID: To: Maxime Coquelin Cc: dev , "Xia, Chenbo" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 6/6] vhost: convert inflight data to DPDK allocation API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jun 15, 2021 at 10:43 AM Maxime Coquelin wrote: > @@ -559,6 +559,31 @@ numa_realloc(struct virtio_net *dev, int index) > vq->log_cache = lc; > } > > + if (vq->resubmit_inflight) { > + struct rte_vhost_resubmit_info *ri; > + > + ri = rte_realloc_socket(vq->resubmit_inflight, sizeof(*ri), 0, node); > + if (!ri) { > + VHOST_LOG_CONFIG(ERR, "Failed to realloc resubmit inflight on node %d\n", > + node); > + return dev; > + } > + vq->resubmit_inflight = ri; > + > + if (vq->resubmit_inflight) { Quick first pass, I'll review more thoroughly the whole series later. I suppose you want to test ri->resubmit_list != NULL (else, this test is unnecessary since we made sure ri != NULL earlier). > + struct rte_vhost_resubmit_desc *rd; > + > + rd = rte_realloc_socket(ri->resubmit_list, sizeof(*rd) * ri->resubmit_num, > + 0, node); > + if (!ri) { > + VHOST_LOG_CONFIG(ERR, "Failed to realloc resubmit list on node %d\n", > + node); > + return dev; > + } > + ri->resubmit_list = rd; > + } > + } > + > vq->numa_node = node; -- David Marchand