[dpdk-dev] [PATCH 0/2] small improvements for FreeBSD build

[dpdk-dev] [PATCH 0/2] small improvements for FreeBSD build

[Bruce Richardson]

Two small changes to improve FreeBSD build and install with meson

Bruce Richardson (2):
  freebsd: allow installing kernel modules
  freebsd: always use clang for kmod compilation

 kernel/freebsd/meson.build | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

-- 
2.22.0

[dpdk-dev] [PATCH 1/2] freebsd: allow installing kernel modules

[Bruce Richardson]

Set the install path for the kernel modules as /boot/modules. This may
ease the integration with the official FreeBSD ports system as all
components should be correctly located in the staging directory after
running "ninja install"

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 kernel/freebsd/meson.build | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/kernel/freebsd/meson.build b/kernel/freebsd/meson.build
index 336083c48..ab1177147 100644
--- a/kernel/freebsd/meson.build
+++ b/kernel/freebsd/meson.build
@@ -28,5 +28,7 @@ foreach k:kmods
 			'KMOD=' + k,
 			'KMOD_CFLAGS=' + ' '.join(kmod_cflags)],
 		depends: built_kmods, # make each module depend on prev
-		build_by_default: get_option('enable_kmods'))
+		build_by_default: get_option('enable_kmods'),
+		install: get_option('enable_kmods'),
+		install_dir: '/boot/modules/')
 endforeach
-- 
2.22.0

[dpdk-dev] [PATCH 2/2] freebsd: always use clang for kmod compilation

[Bruce Richardson]

Clang is the system compiler for FreeBSD and kernel module builds can fail
when built with gcc, e.g. when testing with test-meson-builds.sh.
Therefore, it's safer to always use clang to build the kmods since the
actual flags used are outside of DPDK's control and cannot be guaranteed to
work with all compilers.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 kernel/freebsd/meson.build | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/kernel/freebsd/meson.build b/kernel/freebsd/meson.build
index ab1177147..dc156a43f 100644
--- a/kernel/freebsd/meson.build
+++ b/kernel/freebsd/meson.build
@@ -26,7 +26,8 @@ foreach k:kmods
 			'KMOD_OBJDIR=@OUTDIR@',
 			'KMOD_SRC=@INPUT1@',
 			'KMOD=' + k,
-			'KMOD_CFLAGS=' + ' '.join(kmod_cflags)],
+			'KMOD_CFLAGS=' + ' '.join(kmod_cflags),
+			'CC=clang'],
 		depends: built_kmods, # make each module depend on prev
 		build_by_default: get_option('enable_kmods'),
 		install: get_option('enable_kmods'),
-- 
2.22.0

Re: [dpdk-dev] [PATCH 0/2] small improvements for FreeBSD build

[Luca Boccassi]

On Tue, 2019-11-12 at 16:41 +0000, Bruce Richardson wrote:
> Two small changes to improve FreeBSD build and install with meson
> 
> Bruce Richardson (2):
>   freebsd: allow installing kernel modules
>   freebsd: always use clang for kmod compilation
> 
>  kernel/freebsd/meson.build | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)

Series-acked-by: Luca Boccassi <bluca@debian.org>

-- 
Kind regards,
Luca Boccassi

Re: [dpdk-dev] [PATCH 0/2] small improvements for FreeBSD build

[David Marchand]

On Wed, Nov 13, 2019 at 12:37 PM Luca Boccassi <bluca@debian.org> wrote:
>
> On Tue, 2019-11-12 at 16:41 +0000, Bruce Richardson wrote:
> > Two small changes to improve FreeBSD build and install with meson
> >
> > Bruce Richardson (2):
> >   freebsd: allow installing kernel modules
> >   freebsd: always use clang for kmod compilation
> >
> >  kernel/freebsd/meson.build | 7 +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)
>
> Series-acked-by: Luca Boccassi <bluca@debian.org>

Series applied, thanks.


-- 
David Marchand