From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 67F0FA0613 for ; Tue, 30 Jul 2019 21:21:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 436021BFDD; Tue, 30 Jul 2019 21:21:51 +0200 (CEST) Received: from mail-ua1-f66.google.com (mail-ua1-f66.google.com [209.85.222.66]) by dpdk.org (Postfix) with ESMTP id 618791BFCF for ; Tue, 30 Jul 2019 21:21:50 +0200 (CEST) Received: by mail-ua1-f66.google.com with SMTP id g11so3386870uak.0 for ; Tue, 30 Jul 2019 12:21:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=vfgGfh0rz9LLg7M7qQU1wpXffz4W4TGOMOyKHlmQxFg=; b=XtpiVOuPzmUeOYqjBGrO/yoPwJzN+A8ftCkdbAoZYdd3hXHKTj0VZ4HIoLwzE/ojC/ boCMmb0e10qQFVUong3d2aRyvF2hF8glPiPOnyGbEjAa9VNRqetWsnzBqD89WrafWiZ+ sC6iz6/3q/W9A0pZb5tZub80Mhk38DAKulUBu6497EU7Hk6cqvNDaW08htF1Pw/Jjf3X bUuRv436VMgabtgxP2lymvE9ED0jzR+x5+MLQR5eBTRIm9yh2p4LemMxKeAKx468FQv/ Tov5L3jrS8aKf0EKoOR13y6N3lPCc6mw1GRoWHnQ1eGlR2ZdnMpsQKkRejwYugCgXL52 NrPQ== X-Gm-Message-State: APjAAAVMtsEnntINPJC3ZcpNrYsV6OtKaN/obHekEvO6EmPfVHCM2Qy3 dFz8pslJex9tJPCo7PhIJ8sV614kKr4/Optvfxob/w== X-Google-Smtp-Source: APXvYqwNHde50gNzssNTyll2CYkyhaWmm2+h2xOGq3DM3+srG+gSh5zFRzWXybU7UzAnMef4MaA64jQxVUflDFBQ1b8= X-Received: by 2002:ab0:45e3:: with SMTP id u90mr11368162uau.126.1564514509663; Tue, 30 Jul 2019 12:21:49 -0700 (PDT) MIME-Version: 1.0 References: <1564479354-11192-1-git-send-email-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Tue, 30 Jul 2019 21:21:38 +0200 Message-ID: To: =?UTF-8?B?Sm9oYW4gS8OkbGxzdHLDtm0=?= Cc: "dev@dpdk.org" , "anatoly.burakov@intel.com" , "olivier.matz@6wind.com" , "stable@dpdk.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] eal: fix ctrl thread affinity with --lcores X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jul 30, 2019 at 6:32 PM Johan K=C3=A4llstr=C3=B6m wrote: > > Hi, for the online check I referred to the check of "default_set" via the= initial thread affinity. > > I see that pthread_getaffinity_np returns an already and:ed mask, was und= er the impression that pthread_getaffinity_np would return the same mask as= was set using pthread_setaffinity_np. > Looking on the implementation I see that it has been implemented on this = line (https://github.com/torvalds/linux/blob/master/kernel/sched/core.c#L52= 42) for the last decade. Don=E2=80=99t know how this is implemented on Free= BSD or Windows. Afaics on FreeBSD, trying to set an unknown core is rejected with the cpuset tool. Not sure at which level the refusal is (cpuset, libc, kernel). > Below is some example runs without the online cpu check running inside th= e exclusive cpuset 1-3,19,79 with cpu 79 offline. > Added a print statements after each consecutive calculation just to verif= y what the different steps. > > Nice that you were able to reproduce the bug, the fix looks good otherwis= e :) . Ok, I understand your concern now, but afaiu you confirm that there is no issue with this patch. We are really close to -rc3. Can you send a review or test tag? Thanks. -- David Marchand