DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
	Matan Azrad <matan@mellanox.com>,
	 Raslan Darawsheh <rasland@mellanox.com>,
	Thomas Monjalon <thomas@monjalon.net>
Cc: Ophir Munk <ophirmu@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>,
	Olga Shern <olgas@mellanox.com>,  Asaf Penso <asafp@mellanox.com>,
	"Kinsella, Ray" <ray.kinsella@intel.com>,
	 Neil Horman <nhorman@tuxdriver.com>,
	Kevin Laatz <kevin.laatz@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1] common/mlx5: remove devx depndency on ibv and dv
Date: Thu, 9 Apr 2020 09:24:34 +0200	[thread overview]
Message-ID: <CAJFAV8x=n9v1jX7dh5jipd3Kaj4O-pei7J-cm-MM=YWnDe7sTw@mail.gmail.com> (raw)
In-Reply-To: <6aef6e5c-143e-8ab1-fceb-3ce690342c06@intel.com>

Hello,

On Wed, Apr 8, 2020 at 7:12 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> On 4/1/2020 10:59 AM, Raslan Darawsheh wrote:
> > Hi,
> >
> >> -----Original Message-----
> >> From: Ophir Munk <ophirmu@mellanox.com>
> >> Sent: Monday, March 30, 2020 1:32 AM
> >> To: dev@dpdk.org; Matan Azrad <matan@mellanox.com>
> >> Cc: Thomas Monjalon <thomas@monjalon.net>; Olga Shern
> >> <olgas@mellanox.com>; Raslan Darawsheh <rasland@mellanox.com>; Ophir
> >> Munk <ophirmu@mellanox.com>; Asaf Penso <asafp@mellanox.com>
> >> Subject: [PATCH v1] common/mlx5: remove devx depndency on ibv and dv
> >>
> >> File mlx5_devx_cmds.c should contain pure DevX calls. It must be OS
> >> agnostic and not include any references to ibv or dv structs (defined in
> >> ibverbs and rdma-core linux libraries).  This commit replaces all ibv and
> >> dv references with 'void *'.  Specifically, the following struct were
> >> replaced:
> >> 1. struct ibv_context *
> >> 2. struct ibv_qp *
> >> 3. struct mlx5dv_devx_cmd_comp *
> >>
> >> Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
> >
> > Patch applied to next-net-mlx,
> >
>
> Hi David,
>
> This patch is failing in the travis for ABI checks [1], since mlx has APIs now
> [2], are they public APIs or internal ones, and are they part of the ABI policy,
> can you please check this?

- What I see on patchwork and test-report ml for this patch:
http://patchwork.dpdk.org/patch/67367/

Ophir proposed a patch on 03/30.

The robot reported an issue on 03/30, and I suppose Ophir got a report.
https://mails.dpdk.org/archives/test-report/2020-March/122623.html
https://travis-ci.com/github/ovsrobot/dpdk/jobs/308057800#L2337

Matan acked the patch on 03/31.

Rasland merged the patch on 04/01.

I understand that the abi checks are not perfect, and people need help
with the new abi checks.
Prove me wrong, but here, I get the feeling that it was just ignored
by 3 people in a row.


- On the question if these should be public API or internal, that is
not for me to reply/investigate.
This is a question for Mellanox.


-- 
David Marchand


  parent reply	other threads:[~2020-04-09  7:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-29 22:32 Ophir Munk
2020-03-31  6:29 ` Matan Azrad
2020-04-01  9:59 ` Raslan Darawsheh
2020-04-08 17:10   ` Ferruh Yigit
2020-04-09  6:21     ` Ray Kinsella
2020-04-09  7:24     ` David Marchand [this message]
2020-04-16 17:35       ` Ferruh Yigit
2020-04-16 20:00         ` Thomas Monjalon
2020-04-17 16:19           ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8x=n9v1jX7dh5jipd3Kaj4O-pei7J-cm-MM=YWnDe7sTw@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=asafp@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=kevin.laatz@intel.com \
    --cc=matan@mellanox.com \
    --cc=nhorman@tuxdriver.com \
    --cc=olgas@mellanox.com \
    --cc=ophirmu@mellanox.com \
    --cc=rasland@mellanox.com \
    --cc=ray.kinsella@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).