From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 975D5A0597; Thu, 9 Apr 2020 09:24:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 80EF31C1B0; Thu, 9 Apr 2020 09:24:52 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 324591C112 for ; Thu, 9 Apr 2020 09:24:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586417090; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GghRzlDC5+ce7L7lMqi3VSdUAFPETWCYSnbsFYWJky0=; b=ezg5AKUs0Vjvo+CUA08+9+/CVyCRtpN+DLpugX2i27V/JtswK5kUEl+MvzomhnfMaFkoTA e/BV6qvZ3AqWOVKP+bpFl2BT9HeuJrFnfUj49VSmRim+b6Iq75KZXHj0omBUbhvr/ZUzor n4tTqwJXK5nRtXadVuBCXuT4ZNmSxtI= Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-361-uu4OxKXfM-2sOv8wpFuDBQ-1; Thu, 09 Apr 2020 03:24:46 -0400 X-MC-Unique: uu4OxKXfM-2sOv8wpFuDBQ-1 Received: by mail-ua1-f71.google.com with SMTP id u33so2354030uah.20 for ; Thu, 09 Apr 2020 00:24:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MSgQUXzBOC/YqSmomhBWhnTAVCN127VmAfnVLF2/uK0=; b=YwdusDt4f0obIBhyPpQ4K1TaGQ8JErXfd7SwiQlNzjPeWRCyJrB7tSU1wQtx7eAifV U1pNndlgyQLqUP9ipvrgsUTLR3i4zzi6A/AEl5tjb1b4pD2GT3LoM+TL+JLWKHiJN+oW Bgogxd3mOkJXxj+eh9v8iuQpjnRmGwY2+ExWLHtqKGuvcpokM7LhgAQsQtEE1l9Pyomu M3SCDXgTFQpESfQ8rFJ9oyJyimIck0R58It9wpQLMZLkejS3lw18v99AxlzttrM/W4li GXV0Y4S/C5+apPK4cAAUG/9w6gTun4oppUeZ7gFyUvg5usf284TP/obUt7G8ccbavgYx kxBg== X-Gm-Message-State: AGi0Pubqbckyhpg+d65gyNutSdqPDTYYWSmE9TSdFFAi0Ix0PXSvBTU2 LXnkGECKT8w9dD/IC7Ijvu8541Sgh0RH/WbjY5+RpPzD+APBrBF4bgJ6nEWE1Pfpz3t4lV/q3KG bh+btzwMJw4fmHc9eU+4= X-Received: by 2002:a9f:2102:: with SMTP id 2mr6650701uab.41.1586417086248; Thu, 09 Apr 2020 00:24:46 -0700 (PDT) X-Google-Smtp-Source: APiQypKLIiFk625IgUMLtl4xkzOXVVRezQYCSNuHC/AY+nXa6RY/mp6b3Z85hVRMY82isANp4K3kn8g9sCFrAHY+4Tk= X-Received: by 2002:a9f:2102:: with SMTP id 2mr6650687uab.41.1586417085938; Thu, 09 Apr 2020 00:24:45 -0700 (PDT) MIME-Version: 1.0 References: <20200329223222.7553-1-ophirmu@mellanox.com> <6aef6e5c-143e-8ab1-fceb-3ce690342c06@intel.com> In-Reply-To: <6aef6e5c-143e-8ab1-fceb-3ce690342c06@intel.com> From: David Marchand Date: Thu, 9 Apr 2020 09:24:34 +0200 Message-ID: To: Ferruh Yigit , Matan Azrad , Raslan Darawsheh , Thomas Monjalon Cc: Ophir Munk , "dev@dpdk.org" , Olga Shern , Asaf Penso , "Kinsella, Ray" , Neil Horman , Kevin Laatz X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v1] common/mlx5: remove devx depndency on ibv and dv X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello, On Wed, Apr 8, 2020 at 7:12 PM Ferruh Yigit wrote: > > On 4/1/2020 10:59 AM, Raslan Darawsheh wrote: > > Hi, > > > >> -----Original Message----- > >> From: Ophir Munk > >> Sent: Monday, March 30, 2020 1:32 AM > >> To: dev@dpdk.org; Matan Azrad > >> Cc: Thomas Monjalon ; Olga Shern > >> ; Raslan Darawsheh ; Ophir > >> Munk ; Asaf Penso > >> Subject: [PATCH v1] common/mlx5: remove devx depndency on ibv and dv > >> > >> File mlx5_devx_cmds.c should contain pure DevX calls. It must be OS > >> agnostic and not include any references to ibv or dv structs (defined = in > >> ibverbs and rdma-core linux libraries). This commit replaces all ibv = and > >> dv references with 'void *'. Specifically, the following struct were > >> replaced: > >> 1. struct ibv_context * > >> 2. struct ibv_qp * > >> 3. struct mlx5dv_devx_cmd_comp * > >> > >> Signed-off-by: Ophir Munk > > > > Patch applied to next-net-mlx, > > > > Hi David, > > This patch is failing in the travis for ABI checks [1], since mlx has API= s now > [2], are they public APIs or internal ones, and are they part of the ABI = policy, > can you please check this? - What I see on patchwork and test-report ml for this patch: http://patchwork.dpdk.org/patch/67367/ Ophir proposed a patch on 03/30. The robot reported an issue on 03/30, and I suppose Ophir got a report. https://mails.dpdk.org/archives/test-report/2020-March/122623.html https://travis-ci.com/github/ovsrobot/dpdk/jobs/308057800#L2337 Matan acked the patch on 03/31. Rasland merged the patch on 04/01. I understand that the abi checks are not perfect, and people need help with the new abi checks. Prove me wrong, but here, I get the feeling that it was just ignored by 3 people in a row. - On the question if these should be public API or internal, that is not for me to reply/investigate. This is a question for Mellanox. --=20 David Marchand