From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1B76445BC0; Thu, 24 Oct 2024 11:06:10 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 06B4E43396; Thu, 24 Oct 2024 11:06:10 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 4577F43398 for ; Thu, 24 Oct 2024 11:06:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729760767; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8zmyc2uHbBWf/k9Ka6b9a3g01shu77i1aW7fzfA+uvs=; b=S8tdeJDfJPd43v3mI1goIHFt9RkdTBxisjLd8N5PPl+M8hzCPuyHdG7ewfjhsw2IbW1D1N XDgoeY8AD0ynhQHHGW2ZvXbmLhF2H1IRj1HFFo/y4CZ4ighZYrK4tQ7q3+1VqFDU6sxdXE 8VzTHGOsXQ4kPjv7NO5AiD4Vs4BHr6k= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-436-kubG6oc2MRyga5khTdLDIQ-1; Thu, 24 Oct 2024 05:06:06 -0400 X-MC-Unique: kubG6oc2MRyga5khTdLDIQ-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-539fe4e75c4so591084e87.0 for ; Thu, 24 Oct 2024 02:06:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729760765; x=1730365565; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8zmyc2uHbBWf/k9Ka6b9a3g01shu77i1aW7fzfA+uvs=; b=KGtWkGURoQ+KpPeZpXL+liJHMKJE4CB6g6ri4dub+YTivK8Rt5g7DW1XY1EpN4q4wl TytxebUaYTSVWOSZm93AW1s8df/gQECGjSaNGrtD/f8MGSbEoVcGfwow+4usDyeUf40A eH8hjsh6pjNDcngVSL09v0JbWKurXJYz31WLMcU6+yn7J/Acq/GdkWNmmv+rlUgeZSdX DVdCQmSJmvPpR07Tt9Mg2YmmvB7VGQQsFpTTqmgaIW4+noOJkL364dfm/RZBNhh+LFio mblYWG+F7C+x/aG7LmmahnLmCRBeRdsuCy2yyBswSEoBdjePJLPNnNCS+fLmBrDxIWhN Wa0Q== X-Gm-Message-State: AOJu0YxvKNHpe/D6hU53x0IDuFbQTtY/QG7Af606P9KJfsG67Ov6+QTp DEQviHoBJIOPAruLLF/OyJ3T/j5MVUrY8fuIRBScZbBvBua0nWsDXAnjfucUP2IbDBR6vKzwOJQ 0+N8bM/bO28BPAm+86/BARqEFadJewAT2qdgqriRqj1zneIXf0peMRf2cQOXXdXx6y5MMuv0Fhq XSHGMeIB0vMBnJNcHkCBC7J9+CRv2j X-Received: by 2002:a05:6512:220d:b0:535:6baa:8c5d with SMTP id 2adb3069b0e04-53b1a33cc87mr4638179e87.20.1729760764895; Thu, 24 Oct 2024 02:06:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE8saQDZV0SwSw829WnfvJ6B5nprIFfegSObjcsNcMhE0a8UmkSAGmfCm4V8MLfX4XOqbVWr+SiaWa31Nu+xFA= X-Received: by 2002:a05:6512:220d:b0:535:6baa:8c5d with SMTP id 2adb3069b0e04-53b1a33cc87mr4638153e87.20.1729760764544; Thu, 24 Oct 2024 02:06:04 -0700 (PDT) MIME-Version: 1.0 References: <20240829085724.270041-1-konrad.sztyber@intel.com> <20241011111533.20746-1-konrad.sztyber@intel.com> In-Reply-To: <20241011111533.20746-1-konrad.sztyber@intel.com> From: David Marchand Date: Thu, 24 Oct 2024 11:05:53 +0200 Message-ID: Subject: Re: [PATCH v3] bus/pci: don't open uio device in secondary process To: dev@dpdk.org Cc: Chaoyong He , Stephen Hemminger , stable@dpdk.org, Chenbo Xia , Nipun Gupta , Anatoly Burakov , Long Wu , Zerun Fu , Konrad Sztyber X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Oct 11, 2024 at 1:17=E2=80=AFPM Konrad Sztyber wrote: > > The uio_pci_generic driver clears the bus master bit when the device > file is closed. So, when the secondary process terminates after probing > a device, that device becomes unusable in the primary process. > > To avoid that, the device file is now opened only in the primary process > and the secondary gets it over UNIX domain socket via SCM_RIGHTS. > > Fixes: 847d78fb9530 ("bus/pci: fix FD in secondary process") > Cc: stable@dpdk.org > > Signed-off-by: Konrad Sztyber Recheck-request: rebase=3Dmain,iol-compile-amd64-testing --=20 David Marchand