From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96DBBA046B for ; Sat, 29 Jun 2019 08:19:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F1BB2326D; Sat, 29 Jun 2019 08:19:13 +0200 (CEST) Received: from mail-vs1-f45.google.com (mail-vs1-f45.google.com [209.85.217.45]) by dpdk.org (Postfix) with ESMTP id 835273237 for ; Sat, 29 Jun 2019 08:19:12 +0200 (CEST) Received: by mail-vs1-f45.google.com with SMTP id 190so5511779vsf.9 for ; Fri, 28 Jun 2019 23:19:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=u+amB5YZG2Ov8MwlWTcTPEly6OhEIZL5ccgtliLew2I=; b=Cz/qJ4io6H2k0Zqo4wXAVzFD9FWQBiD/YAaJxlR4zgywrMJwdwiaa9/kYb1Kes4lsa tHEGYCQ1evjhjqLKj2zII8dmdU4F4/7n9pQB4Wm+o78DxluN/3EI0TGL+NfHSpwiCmLO X/KgUejLfEN/QKyzj5s2LE30Mqbk2W7UjIgBM8sUlroS/7P4HuWinLOEdC59jLEM5uM/ Ol3e397G9r/p1vy59vJcUoFLR6tg985FsHPoJ6hEJbDqzrlLw+lIY4LUhtXrBboEXMx2 N9NvZt6OYGMyOnwzvbxNQfeQsOmlF6Fb7y7DWzCR7xAytqioY22NB3rfPX7FuKWjg64C sKmg== X-Gm-Message-State: APjAAAUBT0h3nBofH0/165R787rqavnctKUA17XP38VMzJ/UDBssqO83 mFXznMjYNJp3UdCX/GK/1i01AYBbwqcy+R4/BVUEbA== X-Google-Smtp-Source: APXvYqyVrOPl339BHiFblPpeXStHIRTFQCZ/GroJLp35xk3EShGv7FKfpDGd905esYFYThOXgNnCEtfs++kFpuG4f+w= X-Received: by 2002:a67:e9ca:: with SMTP id q10mr8695255vso.105.1561789151919; Fri, 28 Jun 2019 23:19:11 -0700 (PDT) MIME-Version: 1.0 References: <1561635235-22238-1-git-send-email-david.marchand@redhat.com> <1561635235-22238-9-git-send-email-david.marchand@redhat.com> <2284715.k64COaWSDv@xps> In-Reply-To: From: David Marchand Date: Sat, 29 Jun 2019 08:19:00 +0200 Message-ID: To: Kevin Laatz Cc: dev , Thomas Monjalon Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 8/9] remove experimental tags from all symbol definitions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, Jun 29, 2019 at 7:57 AM David Marchand wrote: > On Fri, Jun 28, 2019 at 9:20 PM David Marchand > wrote: > >> >> On Fri, Jun 28, 2019 at 5:57 PM Thomas Monjalon >> wrote: >> >>> 27/06/2019 13:33, David Marchand: >>> > We had some inconsistencies between functions prototypes and actual >>> > definitions. >>> > Let's avoid this by only adding the experimental tag to the prototypes. >>> > Tests with gcc and clang show it is enough. >>> > >>> > git grep -l __rte_experimental |grep \.c$ |while read file; do >>> > sed -i -e '/^__rte_experimental$/d' $file; >>> > sed -i -e 's/ *__rte_experimental//' $file; >>> > sed -i -e 's/__rte_experimental *//' $file; >>> > done >>> >>> There is one miss: >>> >>> rte_telemetry_parse is not flagged as experimental >>> but is listed in version map >>> Please add __rte_experimental to the definition of rte_telemetry_parse >>> >> >> Not sure I get you. >> How did you get this warning? >> >> > Ah ok, this library is disabled by default. > Another fix being cooked. > > Expect a v2 maybe later today, but I still need an answer on which > approach we take :-) > Reducing the CC: list. So, the reason why it is not flagged is that rte_telemetry_parser.h is not included in rte_telemetry_parser.c. But then I wondered why we did not see it. rte_telemetry Makefile does not add WERROR_FLAGS in its CFLAGS. If I try to add it, we have an avalanche of warnings for trivial things like symbol not marked as static, and a more bizarre "null" string passed as a marker that something went bad. I will send the fix on the missing header as part of my series. But please Kevin, fix the rest of the warnings and add WERROR_FLAGS in the lib Makefile. Thanks. -- David Marchand -- David Marchand