From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C3C2645B12; Fri, 11 Oct 2024 15:29:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 80ED1402A1; Fri, 11 Oct 2024 15:29:37 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 734824028B for ; Fri, 11 Oct 2024 15:29:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728653375; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sRcAZOaJkVdxMHzufJKx8HALOz0aaYW0cRi7HuWZk7Q=; b=g+OLSLQspEeYDXAZ6pFd3lC8MwWnWFZR7Amvgx9Uq7v6NS6CG4dgs/o3q48PA9BPWn8m85 CAPCmm2AnMxXlBMNvXpHZkeQqdkM3JUYDr45inDEG45OohrT23yFgHCnIabXEJNUFZVRn0 pMdlZRwgqfr/jQEb/OZ1CJUn/yY5A6k= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-661-doiuyZMyNeulwSXoMW7Skw-1; Fri, 11 Oct 2024 09:29:34 -0400 X-MC-Unique: doiuyZMyNeulwSXoMW7Skw-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2fad58ddea1so16063881fa.2 for ; Fri, 11 Oct 2024 06:29:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728653372; x=1729258172; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sRcAZOaJkVdxMHzufJKx8HALOz0aaYW0cRi7HuWZk7Q=; b=bxvhBkp9hPanlULKr6A9ZK52fnrWQbwR8kmiKplvfdcM99f147nnUos+u2w5NVKEsC t9waq12fyfNCRU25pzsJXP6dE+6PVEu2U+u3F/h2TT7JP3iJAHa/TmzQl9QUIUui88UR alElUOfUVzdXWpeC3WeMOvRNkOfRaythyyAaoeendXkHEFUrm2G5aokVW1/l0lC/xbxg NzYdytdKTtImJArKTdhnwn3aNGyIvbLPfHuWUbFxpp3VxSxsMBZBNOnCLlOY5os22SSZ HGWgeuoOch/SMdiMi1pcdkzr5VOZWMkUXikbWpqSgutPVQFUb4vT7Ayb8RSnD9mreeVD WWqQ== X-Forwarded-Encrypted: i=1; AJvYcCXnQ4i31BxZL2RtDZrwcCx2qPSvSP9iDnEGq3ga9BMsN3bbwjoWjzRRYag+LjnCWKlQrbc=@dpdk.org X-Gm-Message-State: AOJu0YyuBx4CJdPWJr1XNrg/EDGe/I51YowWgRmz8lnYDi7DV+FEh+Px ZaHyGiGlt6OBNtl9BSE4JIh3ryzDbjKUdh8lY57dfHuK2JOYHLO8GdQe6QVCMqkEulWbUKu4OkU 7p3Gof32iwjzxRiRuChAl00QUwpJ2R/R3f7VlXXqcCfilqHV3JOVHPQ3ysKQDCIiB/yErbuNEqI 3AmfR6wx9mmcSf51M= X-Received: by 2002:a05:6512:10c4:b0:536:7377:7d23 with SMTP id 2adb3069b0e04-539da564e36mr2403449e87.40.1728653372492; Fri, 11 Oct 2024 06:29:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFAjXkQwAoiNWUJ8O5W223Op8Ld0pwSMXqPiXnJ31mQBTiD2n2qBtU6O2/BuZjhvsWOkr6KxyjboBmsbwyyZFk= X-Received: by 2002:a05:6512:10c4:b0:536:7377:7d23 with SMTP id 2adb3069b0e04-539da564e36mr2403427e87.40.1728653372125; Fri, 11 Oct 2024 06:29:32 -0700 (PDT) MIME-Version: 1.0 References: <20241009112308.2973903-1-tduszynski@marvell.com> <20241011094944.3586051-1-tduszynski@marvell.com> <20241011094944.3586051-5-tduszynski@marvell.com> In-Reply-To: <20241011094944.3586051-5-tduszynski@marvell.com> From: David Marchand Date: Fri, 11 Oct 2024 15:29:19 +0200 Message-ID: Subject: Re: [PATCH v14 4/4] eal: add PMU support to tracing library To: Tomasz Duszynski Cc: Jerin Jacob , Sunil Kumar Kori , Tyler Retzlaff , Ruifeng.Wang@arm.com, bruce.richardson@intel.com, dev@dpdk.org, konstantin.v.ananyev@yandex.ru, mattias.ronnblom@ericsson.com, mb@smartsharesystems.com, thomas@monjalon.net, zhoumin@loongson.cn, stephen@networkplumber.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Oct 11, 2024 at 11:50=E2=80=AFAM Tomasz Duszynski wrote: > diff --git a/lib/eal/meson.build b/lib/eal/meson.build > index e1d6c4cf17..2b1a1eb283 100644 > --- a/lib/eal/meson.build > +++ b/lib/eal/meson.build > @@ -14,7 +14,7 @@ subdir(exec_env) > > subdir(arch_subdir) > > -deps +=3D ['log', 'kvargs'] > +deps +=3D ['log', 'kvargs', 'pmu'] Quick comment as I saw a failure in CI. An optional library should not be a required dependency for EAL. You need something like (untested): if dpdk_conf.has('RTE_LIB_PMU') deps +=3D ['pmu'] endif > if not is_windows > deps +=3D ['telemetry'] > endif --=20 David Marchand