From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 05328A051A; Fri, 17 Jan 2020 14:04:04 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6F86A14EC; Fri, 17 Jan 2020 14:04:03 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 5001F11A4 for ; Fri, 17 Jan 2020 14:04:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579266241; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4emimILulRMYqAYOheVr6s/flutXzYmc4UuTan62fp8=; b=S1FlA7TmESBPn9U6QJmqZBueyoDooavURD9pw2kHarzaCmbqNqGQW6Yj4md7ppETaoMFd7 86JpQqAQCHWbrXRn5PVPPPLmqpyQhU19uIYIm+/uDlgsDD/+mG2EDhI8Dg/G1Ts+1i8cM8 1UwMWfk3T3uqGOpzy/56QhoFBAxl3Iw= Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-85-YEjFUs5JNmemJpZ1BMq_MA-1; Fri, 17 Jan 2020 08:03:55 -0500 Received: by mail-ua1-f71.google.com with SMTP id z7so3839313uai.0 for ; Fri, 17 Jan 2020 05:03:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=4emimILulRMYqAYOheVr6s/flutXzYmc4UuTan62fp8=; b=tevoF5OXvrt9ba8/AfVJX8z9OjbrkhFHjF6XUJuYWU76eNvZ3SmnXkoVkbCmcCS5U3 sXTzQhd4mNNprV5JQ3Ur/wQ68wWWzidCvlyHd3NfeRvi4BvJbGSoHQXHymL0qI/xpLK7 r1DOO48EpJGuMtlO+y+lbZ9bREcVt8p6RaXZ2/mES6dV05DTFXxD9ah/m7KzE/Abvffj hxgIjHp2ebxx3DM2/37PKrbVvya0ShlggsSnxv6eVhKF/lyMFSSIHXpNjXgKkFg1o9fs LSuqJ5Cfj3Fx1ITHT0z64dSmi0JQ9tW+P4HVlZd6fQM0Y3IMSo31Rg37sYPWD5Zxcfts doiw== X-Gm-Message-State: APjAAAXl9fQMjmCcN4qNDEX7Z6B3o4kzdcMl7QU4V2T9FFZTh1iTI1BD tgPNmT9JWnNYiCw3BdOg8iaW5UhcmtReJ4dDOshz+Y7KNFvV/54QyDWeSzVYcRz9vI0GE30xcf5 ygLuQTmB2cqGEq+/ERio= X-Received: by 2002:ab0:902:: with SMTP id w2mr11035929uag.41.1579266234396; Fri, 17 Jan 2020 05:03:54 -0800 (PST) X-Google-Smtp-Source: APXvYqxfCD+gjRnPVvJKqIzPZ/RK3s1j52bgz+Ase89NjRgTUKRykaPQho/5Mb8J8jyy/Nix8bcHYJyvIuxrNUtMjio= X-Received: by 2002:ab0:902:: with SMTP id w2mr11035899uag.41.1579266233994; Fri, 17 Jan 2020 05:03:53 -0800 (PST) MIME-Version: 1.0 References: <1571125801-45773-1-git-send-email-joyce.kong@arm.com> <1576648808-24765-1-git-send-email-joyce.kong@arm.com> In-Reply-To: <1576648808-24765-1-git-send-email-joyce.kong@arm.com> From: David Marchand Date: Fri, 17 Jan 2020 14:03:42 +0100 Message-ID: To: Joyce Kong Cc: Thomas Monjalon , Stephen Hemminger , mb@smartsharesystems.com, Jerin Jacob Kollanukkaran , Bruce Richardson , Ravi Kumar , Rasesh Mody , Shahed Shaikh , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , Honnappa Nagarahalli , Phil Yang , Gavin Hu , nd , dev X-MC-Unique: YEjFUs5JNmemJpZ1BMq_MA-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v6 0/6] implement common rte bit operation APIs in PMDs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Dec 18, 2019 at 7:00 AM Joyce Kong wrote: > > There are a lot functions of bit operations scattered in PMDs, consolidat= e > them into a common API family and applied in different PMDs to reduce cod= e > duplication. > > v6: > Trim 'unsigned long' in PMDs down to 'uint32_t', as on mainstream 64-bit= OS, > 'unsigned long' is 64-bit in size, but the 32-bit OS expects 32-bit 'uns= igned > long' argument. > > v5: > Correct the spelling mistake in test_bitops.c > > v4: > Introduce uint32_t/uint64_t *addr when definiting bit operation APIs(su= ggested by > Morten Br=C3=B8rup). > > v3: > 1. Change the API's head file back to rte_bitops.h, then implement both= 32-bit and > 64-bit operations with and without C11 atomic memory ordering. > 2. Add multi-core test case for bit operations which implemented with m= emory ordering. > 3. Modify the doc of both APIs and test cases. > > v2: > 1. Add doxygen comments for the rte bit operation API(suggested by Step= hen Hemminger). > 2. Add test cases for common rte bit operation API(suggested by Stephen= Hemminger). > 3. Change the header file to rte_io_bitops.h and the operation to rte_i= o_set_bit()etc., > as the API uses barriers inside and the barriers are only needed for= IO operations > (suggested by Jerin Jacob). > 4. Use an well defined uint_NN_t type(suggested by Morten Br=C3=B8rup). I did not wait for travis to finish but afaics, this series only builds on 32bits and AARCH64. https://travis-ci.com/david-marchand/dpdk/builds/144927372 --=20 David Marchand