From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 36D1245F20; Mon, 23 Dec 2024 10:28:36 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C602A4068E; Mon, 23 Dec 2024 10:28:35 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 0396B402DC for ; Mon, 23 Dec 2024 10:28:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734946113; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u58V7vDz09TrhwOQX8i1rSOfW3YbmKq8gweSrCvmnH0=; b=DS6ccgWxxZAS+ZF6+wEjK6+Z9do2sBhXu8xef6Hry7tke3CmyfAyoYS1yUHJEKAy6tsUFD EBjSvb7JqFGqKe48l0YqsJ+qTmgDq/S4uXCU535uGEDWDGFQN1Mnd4CscsWECoAaRJnOw2 cRvJKNtLK/CQU11vpLQ825qNVPDlutw= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-371-2hfV-SQqMbudsovbb2824g-1; Mon, 23 Dec 2024 04:28:31 -0500 X-MC-Unique: 2hfV-SQqMbudsovbb2824g-1 X-Mimecast-MFC-AGG-ID: 2hfV-SQqMbudsovbb2824g Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-53e39a081f9so1739474e87.0 for ; Mon, 23 Dec 2024 01:28:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734946110; x=1735550910; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=u58V7vDz09TrhwOQX8i1rSOfW3YbmKq8gweSrCvmnH0=; b=uns17klIkMe/XuWayLplL5zjEyivcPIx+bqWLW0khac7ll+YUwuJoqPCjY//eQkeT8 EJbzL0VpKQ/bwwK61S6xrko7ET3bKKcgl2ein8Rvmf2HhoferCysKrvF7kjqiSJDsVyU 6eo0oh32EyOOjzgHo3z3layQwpGLcqvVfmCOejV5v11k8ns40cGMuLOsgWjEHfl9liLk 48usJ9I2sGFFsIw1yNBHbDvuDk6HZLhaR2CJqD6gxVdn+F2Y0x4dG0R+607kgqIriDdl RTY96Y3w5sQM3vm9JaIOMHt+1oagtzXaVD+flNIJ5MVPTfTM+htCs1nPlIhq06jEM9N3 M05Q== X-Gm-Message-State: AOJu0Yw8R4OOlFS/3izsE5tZA2xf9gJirJe3pUZ2Jon1y5yTVoFSCYtV QDdNr3Pd37qi3b/i/q2sAMGko1ZGh2WBD4e0yDMYBR4I5ygxWDfeLJEaKe6bDWXI3m/eO8l4/jQ tYdlWYB+ifGKvvi0Y5Ma+EzQ3gJud85vsOBpV2iaPYxu5xGhAqB5MIG3z+EJobsVixW481kKB41 3pIFkKCKfAHpmuerk= X-Gm-Gg: ASbGnctfvtvlCyw4FB6sQ6KR2gsczKYgqds6HTJtcwNf5T4GrBKXG31xR+nfng9tAm+ epceMG84h11rIkQxFMRmfNSbQHrjFdc/Udmg02chy X-Received: by 2002:a05:6512:230d:b0:53f:8c46:42bb with SMTP id 2adb3069b0e04-5422955ff80mr3097385e87.40.1734946109722; Mon, 23 Dec 2024 01:28:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IEnOPmQj/qAVx8gDau8BNFOU9KLur4WvWnLcn2tDxCf6pFJUSZhRGS4B1/au7lpee+FwamLm6FusXQPRRwYap0= X-Received: by 2002:a05:6512:230d:b0:53f:8c46:42bb with SMTP id 2adb3069b0e04-5422955ff80mr3097374e87.40.1734946109291; Mon, 23 Dec 2024 01:28:29 -0800 (PST) MIME-Version: 1.0 References: <1733882751-29598-1-git-send-email-andremue@linux.microsoft.com> <1733954844-24397-1-git-send-email-andremue@linux.microsoft.com> In-Reply-To: <1733954844-24397-1-git-send-email-andremue@linux.microsoft.com> From: David Marchand Date: Mon, 23 Dec 2024 10:28:18 +0100 Message-ID: Subject: Re: [PATCH v2 00/14] use portable variadic macros To: Andre Muezerie Cc: dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: y4fbv7v7z2I83vqp0u5lCIik6WhOaDXoUpuNhKgqoSI_1734946110 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Dec 11, 2024 at 11:07=E2=80=AFPM Andre Muezerie wrote: > > Many places are using a GCC extension related to variadic macros, > where a name prepends the ellipsis. This results in a warning like > the one below when compiling the code with MSVC: > > app\test-pmd\testpmd.h(1314): error C2608: > invalid token '...' in macro parameter list > > Variadic macros became a standard part of the C language with C99. > GCC, Clang and MSVC handle them properly. > > The fix is to remove the prefix name (args... becomes ...) and use > __VA_ARGS__. > > v2: > * Removed "do { } while (0)" that was added to macros in v1. As a > result, the patchset is now smaller. > > Andre Muezerie (14): > app/test-acl: use portable variadic macros > app/test-eventdev: use portable variadic macros > app/test-mldev: use portable variadic macros > app/test-pmd: use portable variadic macros > drivers/bus: use portable variadic macros > drivers/common: use portable variadic macros > drivers/compress: use portable variadic macros > drivers/crypto: use portable variadic macros > drivers/dma: use portable variadic macros > drivers/event: use portable variadic macros > drivers/mempool: use portable variadic macros > drivers/net: use portable variadic macros > drivers/raw: use portable variadic macros > drivers/vdpa: use portable variadic macros > > app/test-acl/main.c | 4 +- > app/test-eventdev/evt_common.h | 12 ++-- > app/test-mldev/ml_common.h | 7 ++- > app/test-pmd/testpmd.h | 4 +- > drivers/bus/cdx/cdx_logs.h | 12 ++-- > drivers/bus/dpaa/include/fman.h | 4 +- > drivers/bus/dpaa/rte_dpaa_logs.h | 18 +++--- > drivers/bus/fslmc/fslmc_logs.h | 12 ++-- > drivers/bus/fslmc/qbman/include/compat.h | 14 ++--- > drivers/bus/ifpga/ifpga_logs.h | 16 ++--- > drivers/bus/uacce/uacce.c | 8 +-- > drivers/common/dpaax/compat.h | 16 ++--- > drivers/common/dpaax/dpaax_logs.h | 18 +++--- > drivers/common/idpf/base/idpf_osdep.h | 8 ++- > drivers/compress/octeontx/otx_zip.h | 8 +-- > drivers/compress/zlib/zlib_pmd_private.h | 12 ++-- > drivers/crypto/caam_jr/caam_jr_log.h | 28 ++++----- > drivers/crypto/dpaa2_sec/dpaa2_sec_logs.h | 28 ++++----- > drivers/crypto/dpaa_sec/dpaa_sec_log.h | 28 ++++----- > drivers/crypto/virtio/virtio_logs.h | 60 +++++++++---------- > drivers/dma/dpaa/dpaa_qdma_logs.h | 24 ++++---- > drivers/dma/dpaa2/dpaa2_qdma_logs.h | 24 ++++---- > drivers/dma/idxd/idxd_internal.h | 8 +-- > drivers/dma/ioat/ioat_internal.h | 8 +-- > drivers/event/dlb2/dlb2_log.h | 8 +-- > drivers/event/dlb2/pf/base/dlb2_osdep.h | 12 ++-- > drivers/event/dpaa/dpaa_eventdev.h | 16 ++--- > drivers/event/dpaa2/dpaa2_eventdev_logs.h | 12 ++-- > drivers/event/dsw/dsw_evdev.h | 8 +-- > drivers/event/sw/sw_evdev_log.h | 12 ++-- > drivers/mempool/dpaa/dpaa_mempool.h | 20 +++---- > drivers/mempool/dpaa2/dpaa2_hw_mempool_logs.h | 30 +++++----- > drivers/net/ark/ark_logs.h | 4 +- > drivers/net/bnxt/tf_core/cfa_tcam_mgr.h | 12 ++-- > drivers/net/bnxt/tf_core/tfp.h | 8 +-- > drivers/net/bnxt/tf_ulp/bnxt_tf_common.h | 4 +- > drivers/net/dpaa/dpaa_ethdev.h | 16 ++--- > drivers/net/dpaa/fmlib/fm_ext.h | 4 +- > drivers/net/dpaa2/dpaa2_pmd_logs.h | 28 ++++----- > drivers/net/e1000/base/e1000_osdep.h | 10 ++-- > drivers/net/ena/base/ena_plat_dpdk.h | 14 ++--- > drivers/net/enetc/enetc_logs.h | 32 +++++----- > drivers/net/enetfec/enet_pmd_logs.h | 18 +++--- > drivers/net/enic/enic_compat.h | 16 ++--- > drivers/net/fm10k/base/fm10k_osdep.h | 10 ++-- > drivers/net/hns3/hns3_logs.h | 20 +++---- > drivers/net/i40e/base/i40e_osdep.h | 2 +- > drivers/net/ice/base/ice_osdep.h | 4 +- > drivers/net/igc/base/igc_osdep.h | 10 ++-- > drivers/net/ipn3ke/ipn3ke_logs.h | 16 ++--- > drivers/net/ixgbe/base/ixgbe_osdep.h | 30 +++++----- > drivers/net/ngbe/base/ngbe_osdep.h | 2 +- > drivers/net/ngbe/ngbe_logs.h | 2 +- > drivers/net/pfe/pfe_logs.h | 18 +++--- > drivers/net/qede/qede_ethdev.h | 4 +- > drivers/net/qede/qede_logs.h | 16 ++--- > drivers/net/sfc/sfc_debug.h | 4 +- > drivers/net/txgbe/base/txgbe_osdep.h | 2 +- > drivers/net/txgbe/txgbe_logs.h | 2 +- > drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h | 24 ++++---- > drivers/raw/ifpga/base/opae_debug.h | 4 +- > drivers/raw/ifpga/base/opae_osdep.h | 20 +++---- > .../raw/ifpga/base/osdep_rte/osdep_generic.h | 4 +- > drivers/raw/ifpga/ifpga_rawdev.h | 16 ++--- > drivers/raw/skeleton/skeleton_rawdev.h | 16 ++--- > drivers/raw/skeleton/skeleton_rawdev_test.c | 8 +-- > drivers/vdpa/ifc/base/ifcvf_osdep.h | 4 +- > 67 files changed, 453 insertions(+), 450 deletions(-) Thanks for the cleanup Andr=C3=A9, the series lgtm. Applied, thanks. --=20 David Marchand