Re: [dpdk-dev] [PATCH 7/8] event: switch sequence number to dynamic field

[David Marchand <david.marchand@redhat.com>]

On Tue, Oct 27, 2020 at 11:16 PM David Marchand
<david.marchand@redhat.com> wrote:
> diff --git a/lib/librte_eventdev/rte_eventdev.h b/lib/librte_eventdev/rte_eventdev.h
> index ce1fc2ce0f..1656ff8dce 100644
> --- a/lib/librte_eventdev/rte_eventdev.h
> +++ b/lib/librte_eventdev/rte_eventdev.h
> @@ -211,13 +211,15 @@ extern "C" {
>  #endif
>
>  #include <rte_common.h>
> +#include <rte_compat.h>
>  #include <rte_config.h>
> +#include <rte_mbuf.h>
> +#include <rte_mbuf_dyn.h>
>  #include <rte_memory.h>
>  #include <rte_errno.h>
>
>  #include "rte_eventdev_trace_fp.h"
>
> -struct rte_mbuf; /* we just use mbuf pointers; no need to include rte_mbuf.h */
>  struct rte_event;
>
>  /* Event device capability bitmap flags */
> @@ -570,9 +572,9 @@ struct rte_event_queue_conf {
>          */
>         uint32_t nb_atomic_order_sequences;
>         /**< The maximum number of outstanding events waiting to be
> -        * reordered by this queue. In other words, the number of entries in
> -        * this queue’s reorder buffer.When the number of events in the
> -        * reorder buffer reaches to *nb_atomic_order_sequences* then the
> +        * event_tested by this queue. In other words, the number of entries in
> +        * this queue’s event_test buffer.When the number of events in the
> +        * event_test buffer reaches to *nb_atomic_order_sequences* then the

v2 tomorrow, without this %s/reorder/test_event/g...


>          * scheduler cannot schedule the events from this queue and invalid
>          * event will be returned from dequeue until one or more entries are
>          * freed up/released.
> @@ -935,7 +937,7 @@ rte_event_dev_close(uint8_t dev_id);
>   * Event ordering is based on the received event(s), but also other
>   * (newly allocated or stored) events are ordered when enqueued within the same
>   * ordered context. Events not enqueued (e.g. released or stored) within the
> - * context are  considered missing from reordering and are skipped at this time
> + * context are  considered missing from event_testing and are skipped at this time
>   * (but can be ordered again within another context).
>   *
>   * @see rte_event_queue_setup(), rte_event_dequeue_burst(), RTE_EVENT_OP_RELEASE
> @@ -1021,7 +1023,7 @@ rte_event_dev_close(uint8_t dev_id);
>   * then this function hints the scheduler that the user has done all that need
>   * to maintain event order in the current ordered context.
>   * The scheduler is allowed to release the ordered context of this port and
> - * avoid reordering any following enqueues.
> + * avoid event_testing any following enqueues.
>   *
>   * Early ordered context release may increase parallelism and thus system
>   * performance.


-- 
David Marchand