From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id B357CA0096
	for <public@inbox.dpdk.org>; Thu,  6 Jun 2019 10:03:27 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 780174D27;
	Thu,  6 Jun 2019 10:03:26 +0200 (CEST)
Received: from mail-vs1-f67.google.com (mail-vs1-f67.google.com
 [209.85.217.67]) by dpdk.org (Postfix) with ESMTP id 37BD44C99
 for <dev@dpdk.org>; Thu,  6 Jun 2019 10:03:25 +0200 (CEST)
Received: by mail-vs1-f67.google.com with SMTP id z11so664874vsq.9
 for <dev@dpdk.org>; Thu, 06 Jun 2019 01:03:25 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=PN+o+FyrAvc0CH3bCEHRopkdAk7eLKtlBYUX0dDRP1w=;
 b=qwWo9Vtn68Wz8/NCM8RkKuFSYqUrEUeRoFhd7+cU1X2U8oxWNnr2PDFHiAtbWIQi4B
 0z46qbqT4AzAtIslEk/W72kEbArH+24itjLNK20mEeCkbtQg7AWKHaIodgptCQV76XRr
 uin6OK7oasO4/ccuMxHF1I4Sp+66t3tBCJJfb/lbqdO5R7kwH4xFE5fM+PBmiwngIbmp
 wynme68Jj5/o8Izmc8JFDe4slNmAkGz8f6zBX7wS1G6Lg4x/KPmMdCRpWNyu4KUqaI+k
 Wan/TP97JtGzu7NzhKFr4SxCLtFtgVmMZ3INY5XiZMOUl3V960RYie+JpNuVo1QHN6mo
 tANQ==
X-Gm-Message-State: APjAAAWYfn/jdAAEWxwavMd7oAQDY/lUIs/o0HCu6bLwvW2Xep9KLPBR
 T9h8pzUZ5Fyan0w0BZKRrk+3y0miduiGYgdXmeqQYQ==
X-Google-Smtp-Source: APXvYqyxmyMf6ut4GentjkvayyD66kgKWoRPu/v2/G0H0Z6GRYRJu4FPaqQ17uy2wW/AP09yJPtc4OYf7K9aCvu6YwM=
X-Received: by 2002:a67:688f:: with SMTP id
 d137mr14360356vsc.198.1559808204603; 
 Thu, 06 Jun 2019 01:03:24 -0700 (PDT)
MIME-Version: 1.0
References: <1559546368-32263-1-git-send-email-arnon@qwilt.com>
 <1559661921-8821-1-git-send-email-arnon@qwilt.com>
 <CAJFAV8yj8r-md6nOZWeE-=kBUxqsfPNBbZ9w_6JTBeakxPpDLA@mail.gmail.com>
 <CAKy9EB0Mx1LH-PpPkWQTCmwowCTz_qgQthbJZrsCb80LAxwtiQ@mail.gmail.com>
In-Reply-To: <CAKy9EB0Mx1LH-PpPkWQTCmwowCTz_qgQthbJZrsCb80LAxwtiQ@mail.gmail.com>
From: David Marchand <david.marchand@redhat.com>
Date: Thu, 6 Jun 2019 10:03:13 +0200
Message-ID: <CAJFAV8xCwqx5Po0cnpUsPTh7VFaR4jMZ3VFoVQC7Pd6uYwq5UQ@mail.gmail.com>
To: Arnon Warshavsky <arnon@qwilt.com>
Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>, 
 Stephen Hemminger <stephen@networkplumber.org>,
 Bruce Richardson <bruce.richardson@intel.com>
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH v4] eal: remove non-thread panic calls from
	init sequence
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Jun 5, 2019 at 5:44 PM Arnon Warshavsky <arnon@qwilt.com> wrote:
> On Wed, Jun 5, 2019 at 10:50 AM David Marchand <david.marchand@redhat.com>
wrote:
>> On Tue, Jun 4, 2019 at 5:45 PM Arnon Warshavsky <arnon@qwilt.com> wrote:
>>> This patch changes some void functions to return a value,
>>> so that the init sequence may tear down orderly
>>> instead of calling panic.
>>
>> All we care about in this patch are the panics wrt the shared
configuration init.
>> Can the commit title and description refer to this ?
>
> Will remove the non-thread from the title.
> Can you be more specific/ offer your view per the description?

Looking at the git history, how about:
eal: do not panic on shared memory init

--
David Marchand