From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 296C5A0C41; Wed, 17 Nov 2021 10:29:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C02E641144; Wed, 17 Nov 2021 10:29:42 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id CF1B540040 for ; Wed, 17 Nov 2021 10:29:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1637141380; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yfV2zuoCcki1rR0Vq9P0qV7FPWJmg+PXs15W5bF6Wrw=; b=Yo6xbyuQu798TJVd7Is4eEjIZH9Xj6qMzgeA4NevqNRVvVEdTfe95iFGtK5oQe0nPWFg8T V///TnsznBWrblegJQ2F6o37700hE0GpggJ5rPkYeGA4GNgg47QBLHigjVaUenH5YxdZkh EGIefIP73qZ9SEb182StrQTvJAhbmi8= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-101-jeX9T4XBP-aF0PHWpX0rQw-1; Wed, 17 Nov 2021 04:29:38 -0500 X-MC-Unique: jeX9T4XBP-aF0PHWpX0rQw-1 Received: by mail-lf1-f70.google.com with SMTP id i1-20020a056512318100b003ffd4e89eb9so1059862lfe.19 for ; Wed, 17 Nov 2021 01:29:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yfV2zuoCcki1rR0Vq9P0qV7FPWJmg+PXs15W5bF6Wrw=; b=Kdd6bLifWhqaOjjDajeomHkWkp0HEy4YV6Kdk9O6j6EzIOM/JtbvA++pcCcZHModsy XZMm+bxXBjPbR7PePRQhEohxhXPmg9BL0H/stfhbpPDHIIuoLNxRK36yCio1RDIXWhQj vBpFfHxB2r+5ZTZbw76Kd6A0rmtoB1eVEVyh37zcyXWz9/PU1Fhn4884pNMFfOddvDI3 l8snmy3cVHNO27NquDOQI2S9UJjwdvSy9Nw0bhFi2+A0Lpfcwpgfijhxi6d0y6nV179h 3AiRxxK6osv2mSPOO0byPJjeY6UNhDNkk8ppajudNTgIsCrunCGTe75om6HKFC8ABEft saQg== X-Gm-Message-State: AOAM532KHZngQG5t6HOlKYaj+CcUIlnmDYnTVZ9cm2+6mT79YiDYIhbJ NGu6WX3TGu6UeyouUw97CsIT+Df9i5ywJfLF9Pr8Hqa2wyfhkCe+lLkN15xinXd827DbjIbNy7m 6lUUwFsJGFEYHx1R7nQM= X-Received: by 2002:a05:6512:aca:: with SMTP id n10mr13850492lfu.265.1637141377461; Wed, 17 Nov 2021 01:29:37 -0800 (PST) X-Google-Smtp-Source: ABdhPJzk3fPfKaM6XS6VyfrwBqwnHvpWp9PbRlSZcSFlfrTxn2Cl0o16Pp1vjJblc7frD0Lc+Pplao3ueiBFRiMg8BI= X-Received: by 2002:a05:6512:aca:: with SMTP id n10mr13850476lfu.265.1637141377281; Wed, 17 Nov 2021 01:29:37 -0800 (PST) MIME-Version: 1.0 References: <20211116094205.750359-1-joyce.kong@arm.com> <20211116094205.750359-4-joyce.kong@arm.com> In-Reply-To: From: David Marchand Date: Wed, 17 Nov 2021 10:29:26 +0100 Message-ID: Subject: Re: [PATCH v2 03/12] test/timer: use compiler atomic builtins for sync To: Honnappa Nagarahalli Cc: Joyce Kong , Robert Sanford , Erik Gabriel Carrillo , dev , nd , Ruifeng Wang Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Nov 16, 2021 at 10:21 PM Honnappa Nagarahalli wrote: > > Joyce, Honnappa, > > > > On Tue, Nov 16, 2021 at 10:43 AM Joyce Kong wrote: > > > > > > Convert rte_atomic usages to compiler atomic built-ins for lcore_state > > > and collisions sync. > > > > > > Also, move 'main_init_workers' outside of 'timer_stress2_main_loop' to > > > guarantee lcore_state initialized correctly before the threads > > > launched. > > > > Is this "also" part actually related to the change? > > Or is it a separate fix? > 'Also' part is not fixing a different problem (i.e. the code earlier was not having any issues). This 'also' part just helps to keep the code simple. This is indeed better this way. Thanks. -- David Marchand