From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B53BCA0471 for ; Tue, 13 Aug 2019 08:32:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A5D031B203; Tue, 13 Aug 2019 08:32:57 +0200 (CEST) Received: from mail-ot1-f65.google.com (mail-ot1-f65.google.com [209.85.210.65]) by dpdk.org (Postfix) with ESMTP id 1B33B5681 for ; Tue, 13 Aug 2019 08:32:56 +0200 (CEST) Received: by mail-ot1-f65.google.com with SMTP id m24so15470670otp.12 for ; Mon, 12 Aug 2019 23:32:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rQeNc6vz9X1edwVocAj2r8G52GZDCOxIT/m9GmurvGY=; b=o8l+53aDp4mbAyWpT3XTGwwsfeg3a85o56xSWUR9wx0eR/dNg4gXMAsrdJAcl8OzqG NVywHO+zXB14t9mrSwFhdBMiDsQczHdVEURkxXvp7t+FMSVtQi/zC9B3VYGmc+AHz3iK xWxOndnNy3vE4umwQbrrk20J+CKvMQuPfX7DHHL1WZERmCLTQa1F0KPghvvKQbu8F6dv V/iZtyjzYI9QDEerwJEWr7zo6m5hout7y/5SfRuPsZE/2+ZEbKR0NuhjMd/5cg6NLIlA Hffqme5mPVMsUEeKIltgOT0V3+xqEhsubzRWL09xHIlFrz2PRunVIb0HH0ObsB7a0nvH oS4A== X-Gm-Message-State: APjAAAXWkVPHNvcs9yg/2ZGMrPFZoD6qLkV9K/Yqe4Lq+MUCDHgydgRG Mvfb2eczOCVhKImjHG095GJQWnqnGMWPzfQ4ioBp1A== X-Google-Smtp-Source: APXvYqwNGNMgRvOxFn7F4kaqHryTelsv6u6o40/bi9y/te01DpZtkwRLibWrU3BC63Aw6yplMHEKaP5ZWqb2mnjkwpw= X-Received: by 2002:a6b:ee15:: with SMTP id i21mr13842473ioh.281.1565677975247; Mon, 12 Aug 2019 23:32:55 -0700 (PDT) MIME-Version: 1.0 References: <1565593348-6431-1-git-send-email-david.marchand@redhat.com> <20190812201320.GA8474@localhost.localdomain> In-Reply-To: <20190812201320.GA8474@localhost.localdomain> From: David Marchand Date: Tue, 13 Aug 2019 08:32:44 +0200 Message-ID: To: Neil Horman Cc: dev , Aaron Conole Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] buildtools: lighter experimental symbol check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Aug 12, 2019 at 10:14 PM Neil Horman wrote: > > On Mon, Aug 12, 2019 at 09:02:28AM +0200, David Marchand wrote: > > Dumping every object file for every symbol is too heavy. > > Use a temporary storage. > > > > Before: > > $ rm -rf master && make defconfig O=master > > $ time make EXTRA_CFLAGS=-g O=master > > [...] > > real 2m24.063s > > user 1m16.985s > > sys 1m46.372s > > > > After: > > $ rm -rf master && make defconfig O=master > > $ time make EXTRA_CFLAGS=-g O=master > > [...] > > real 1m37.110s > > user 0m49.417s > > sys 0m51.803s > > > > Signed-off-by: David Marchand > > --- > > buildtools/check-experimental-syms.sh | 15 ++++++++------- > > 1 file changed, 8 insertions(+), 7 deletions(-) > > > > diff --git a/buildtools/check-experimental-syms.sh b/buildtools/check-experimental-syms.sh > > index 0f6c62d..47a06fc 100755 > > --- a/buildtools/check-experimental-syms.sh > > +++ b/buildtools/check-experimental-syms.sh > > @@ -18,14 +18,15 @@ then > > exit 0 > > fi > > > > +DUMPFILE=$(mktemp -t dpdk.${0##*/}.XXX.objdump) > > +trap 'rm -f "$DUMPFILE"' EXIT "If a sigspec is EXIT (0) the command arg is executed on exit from the shell." > > +objdump -t $OBJFILE >$DUMPFILE > > + > When does this temporary file get deleted? It should be enough? -- David Marchand