From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 387D4A0579; Thu, 8 Apr 2021 13:22:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AA35E40698; Thu, 8 Apr 2021 13:22:02 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mails.dpdk.org (Postfix) with ESMTP id 11F3340138 for ; Thu, 8 Apr 2021 13:22:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617880921; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+Lk5r85ckAfIg79pL+gXrEyK6rEsNV8REa8KOlMGDpw=; b=ULpmFCr9ycqgEwxwQEbvA0vKY5KeqS7l+77tfV1+e92AyJh75ROAoSQ1Jn0Ni8zvZKR4su fvS78AuiSsnOpNhVrTkQ0MuAS/gOT/Hi+Cu+FoPgloSPCM8vkJS4cAVSoeJC93gesTTnnG i/wJuhmnRYtL1IkjxJrX4QkedaFXKUU= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-578-y77jDPRaN6uCJ1u5DOcYGw-1; Thu, 08 Apr 2021 07:21:56 -0400 X-MC-Unique: y77jDPRaN6uCJ1u5DOcYGw-1 Received: by mail-vk1-f198.google.com with SMTP id v188so178574vkg.13 for ; Thu, 08 Apr 2021 04:21:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+Lk5r85ckAfIg79pL+gXrEyK6rEsNV8REa8KOlMGDpw=; b=lLNIBey5kGugGH94G8ipe9xWHMvfXxupnlMqwVmu1GMIELs3yM5qZHe8QU70cwejF1 jnW2Ej91VHUwP3oSrljYrORKE3n8U/lv1a3O/Wgm/HdkOQeP6P238mFSiPM3W3MEsbTS Mybohw9yo0w6Qorx6X4yvSylTfvPmEDH1pdCZO3U5axThml49XZheZye3lvbmmn/BSfR XniIkzDj01k48LkJUuTsHeLkAgBQ0S0y9WFbXOllQpblbL8iLlz6tfRYvw6ijOrogi5a DIqbOCZL/4hoIgJGoBN/MQ5nW/xrp4IJAn1KY3Uq7wwenSkDiI+aXG2F3nsHU3u9Px4G tI8A== X-Gm-Message-State: AOAM531opQ+mTK62Yor3FS/WyEjxRHoA6FF/VYVn8FfHVKKuebT1TdN+ MOwF1NhnM7kgT7NFgwfhhnfivGnlJPIiq4pyNvopILeCitmkQj4dAsxPwwUGEgP9+80B/657AX+ dFt3HbTTipyy5DEM0Pd8= X-Received: by 2002:a67:f84a:: with SMTP id b10mr5466620vsp.10.1617880916504; Thu, 08 Apr 2021 04:21:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyrZOtryuPBaXQfmDqNKTy//3RNVfuOVQnXBLRzaMEUx1oPjN+W28QUTFN6aHNlJlH8bHbVlpOXzky3fqBsqu0= X-Received: by 2002:a67:f84a:: with SMTP id b10mr5466605vsp.10.1617880916327; Thu, 08 Apr 2021 04:21:56 -0700 (PDT) MIME-Version: 1.0 References: <1617877043-11025-1-git-send-email-humin29@huawei.com> In-Reply-To: <1617877043-11025-1-git-send-email-humin29@huawei.com> From: David Marchand Date: Thu, 8 Apr 2021 13:21:44 +0200 Message-ID: To: "Min Hu (Connor)" Cc: dev , "Yigit, Ferruh" , Bruce Richardson , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] examples/helloworld: add eal clean up to the example X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Apr 8, 2021 at 12:17 PM Min Hu (Connor) wrote: > > From: Chengchang Tang > > According to the programming guide, the rte_eal_init should be used pairs > with rte_eal_cleanup. > > So, we should add the use of clean up to the hello world example to > encourage new users of DPDK to use it. > > Fixes: af75078fece3 ("first public release") rte_eal_cleanup() was introduced with aec9c13c5257 ("eal: add function to release internal resources") from v18.02. Other examples probably need fixes too. $ git grep -l rte_eal_init examples/ |xargs grep -L rte_eal_cleanup |wc 52 52 1623 -- David Marchand