From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8163B4560D; Fri, 12 Jul 2024 10:40:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6F69C402E1; Fri, 12 Jul 2024 10:40:21 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id DEF8D402DC for ; Fri, 12 Jul 2024 10:40:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720773619; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Bj500Ac9pSDVWoMdPaNy2j+lCQeWPIfqz+2RMy4ft4o=; b=BqyRaA3rjkxmlxrgVEjRrs9wapMMqUoPWvnovksOyv3az2eVmnAj+sjn7aHiUJ9qD3/RDk oIO+Swzdf5z45O0LWEHELtUh29RV+cyzALcbonL1bIcgH74aCnvlJx5CFNf+i1MndyRb8L 2srfjjFA10muCcyMC5c4ZiSxzYyN88c= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-308-C8dorN-wNzeikvxsEadZrA-1; Fri, 12 Jul 2024 04:40:18 -0400 X-MC-Unique: C8dorN-wNzeikvxsEadZrA-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2ee95497b77so17515081fa.1 for ; Fri, 12 Jul 2024 01:40:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720773616; x=1721378416; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Bj500Ac9pSDVWoMdPaNy2j+lCQeWPIfqz+2RMy4ft4o=; b=Uldgk/6yWcen3WNNdeOmzK+xCLoQ/6Uf/H3SZ0C+dhtadQistIAu5rsU/5hiP+zgbU o7kNiiNss69jOt9FrdCgXT0IQPjjjJyPACtq8co13CVotFaJagLyc+jmeNOCGjfkUgWs KEpoOZaULpVmLM49bg/1XgV8+W5Pq7eO9ZVNhab3P7QP+2Vz4L3XGpe3I+gGFObTRz3F VtiLRhBIMnVBSsB0hWmZGnyVTSAb+rWS1MLrwf7wYoU4X95KNit0l9/OCJTJ1koYJEMn cibpCsR30sAXB3LvxnEuuQtgsamdfvYFLB7hnajJ41x0xgARjrVS+il34pNfZloLp3eB 31oA== X-Gm-Message-State: AOJu0YxMhIeNC210mtD553VrgCK9+lfr/idiPXG4cqihXlcR+VZqXRLB EprVVRI3nabaBbb+NY4lomR3jmbwqF5kApRrWK6rsmhfq+aMJGk8viYU/gUOb2sCcdlLWXCi75P FvPKPSlngT9RloczBGisTbOor1CxXKGkn2TfKChr1pc4cybOjwXBKfYMtnRMOJs6/49FFONui0Q kVNrRDMs+3lhS5Ito= X-Received: by 2002:a05:651c:11c7:b0:2ee:4623:93e with SMTP id 38308e7fff4ca-2eeb30e398cmr70285471fa.20.1720773616765; Fri, 12 Jul 2024 01:40:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEyCdlLegTEWMGzSze5GsWeJm3bWlotxZp9VRnOdN6DlfhWhHartY1LZBnkRZN/lIgQEleE7nP9LDUUgfZ2cns= X-Received: by 2002:a05:651c:11c7:b0:2ee:4623:93e with SMTP id 38308e7fff4ca-2eeb30e398cmr70285381fa.20.1720773616366; Fri, 12 Jul 2024 01:40:16 -0700 (PDT) MIME-Version: 1.0 References: <20240711165728.1105073-1-bruce.richardson@intel.com> In-Reply-To: <20240711165728.1105073-1-bruce.richardson@intel.com> From: David Marchand Date: Fri, 12 Jul 2024 10:40:02 +0200 Message-ID: Subject: Re: [PATCH] net/ice: fix sizing of filter hash table To: Bruce Richardson Cc: dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jul 11, 2024 at 6:57=E2=80=AFPM Bruce Richardson wrote: > > The hash table used for managing the filter rules in the ice driver was > dimensioned to a hard-coded 16k, which is insufficient for holding all > the filters supported by E830 HW. > > Rather than using a hard-coded value which may need updates for new > hardware support, we can query the NIC max filter support from hardware > and scale the hash table size based on that value. > > Fixes: 1a2fc1799f09 ("net/ice: reject duplicated flow for flow director") > > Signed-off-by: Bruce Richardson I did not test it, but on the principle this looks fine. Acked-by: David Marchand > > --- > > NOTE: Omission of "Cc: stable..." is deliberate. Although this > is a fix for an issue originally introduced in an old commit, the issue > only manifests with newly-supported HW, so the fix does not need > backporting. Makes sense. --=20 David Marchand