Re: [dpdk-dev] [PATCH] librte_eal: ease init in a docker container

[David Marchand <david.marchand@redhat.com>]

s/librte_eal/mem/ for the title prefix.

On Thu, May 23, 2019 at 10:56 AM Burakov, Anatoly <anatoly.burakov@intel.com>
wrote:

> On 22-May-19 4:41 PM, Nicolas Dichtel wrote:
> > move_pages() is only used to get the numa node id, but this function
> > is not allowed by default in docker (it needs CAP_SYS_NICE and an update
> of
> > the seccomp profile).
> > get_mempolicy() also requires CAP_SYS_NICE but doesn't need any change in
> > the default seccomp profile.
> >
> > Note that the returned value of move_pages() was not checked, thus some
> > errors could be hidden (if the requested id was 0).
> >
> > Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> > Reviewed-by: Olivier Matz <olivier.matz@6wind.com>
> > Reviewed-by: Didier Pallard <didier.pallard@6wind.com>
> > ---
>
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
>
> Still, should at least specify Cc: stable, if not Fixes tag too (since
> ignoring return value of move_pages() is technically a bug).
>

+1
At first I was wondering if we should separate the fix from the
enhancement, but I suppose backporting both things as one patch is fine too.


-- 
David Marchand