From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 3047BA05D3 for <public@inbox.dpdk.org>; Thu, 23 May 2019 11:01:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4B6F8493D; Thu, 23 May 2019 11:01:03 +0200 (CEST) Received: from mail-vk1-f194.google.com (mail-vk1-f194.google.com [209.85.221.194]) by dpdk.org (Postfix) with ESMTP id 78E6F2B9E for <dev@dpdk.org>; Thu, 23 May 2019 11:01:01 +0200 (CEST) Received: by mail-vk1-f194.google.com with SMTP id g194so1184665vke.13 for <dev@dpdk.org>; Thu, 23 May 2019 02:01:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GLMQHCnGy3NWC/xKRucvKLzRc3ikLLZKELnUrcElcMQ=; b=se4dIXFy1TEvmTZo5xL/il/Vd9AHEgE2r6otvWYC9gjM7CKfyEo15DJSCtQokQn7Mz GhccM2aRCuqOuC6j9rZ7o+O8uf+8qYPU6e1qyFph/s7lUg6JPhqVmBCkZ/8kDqwYjfDv IPeCZ0DeU6Vx98171piPN7aQxEwh3pg+3nqSXMg2qVVeNxPPVWJ3h4bfhbf4ZymhBPT4 CCf/dx7NmPGJdZOxWl5tF6ZIXM/tazGKU254zGn5VuF574GMk2zWvGNrWZqukTws3Gqp JT5AwKbENvWFcfwSxSsIpqX5c7kAeMttkyvu5ujog5eSx3rcMzwDnnfm6hkovHzvt1eE BGJg== X-Gm-Message-State: APjAAAXFmKXKkR8r4jLIj39D8z+Hnub58u3uYW1H9ayd2zdgnmno6mWd lKNMvpCnrs3OC01PcGgievtmWMGaoN+wtCz/6+wAZQ== X-Google-Smtp-Source: APXvYqy/B8iQHOmmx/2NXNHTnYMeIivzSIt5OCbyPBt2MowWiVwRhNaYL/apu/YkORm8tSGO7y9NFOomTVmcz2njkik= X-Received: by 2002:a1f:a54f:: with SMTP id o76mr1077054vke.86.1558602060731; Thu, 23 May 2019 02:01:00 -0700 (PDT) MIME-Version: 1.0 References: <20190522154143.8041-1-nicolas.dichtel@6wind.com> <70ffa3f2-e80c-d7d8-1405-eb9b950761a8@intel.com> In-Reply-To: <70ffa3f2-e80c-d7d8-1405-eb9b950761a8@intel.com> From: David Marchand <david.marchand@redhat.com> Date: Thu, 23 May 2019 11:00:49 +0200 Message-ID: <CAJFAV8xFNDWZ_q=ecu8u5KqApeW04rZuOi5ZG7yNKYGs7sKaBQ@mail.gmail.com> To: "Burakov, Anatoly" <anatoly.burakov@intel.com> Cc: Nicolas Dichtel <nicolas.dichtel@6wind.com>, dev <dev@dpdk.org>, Olivier Matz <olivier.matz@6wind.com>, Didier Pallard <didier.pallard@6wind.com> Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] librte_eal: ease init in a docker container X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> s/librte_eal/mem/ for the title prefix. On Thu, May 23, 2019 at 10:56 AM Burakov, Anatoly <anatoly.burakov@intel.com> wrote: > On 22-May-19 4:41 PM, Nicolas Dichtel wrote: > > move_pages() is only used to get the numa node id, but this function > > is not allowed by default in docker (it needs CAP_SYS_NICE and an update > of > > the seccomp profile). > > get_mempolicy() also requires CAP_SYS_NICE but doesn't need any change in > > the default seccomp profile. > > > > Note that the returned value of move_pages() was not checked, thus some > > errors could be hidden (if the requested id was 0). > > > > Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com> > > Reviewed-by: Olivier Matz <olivier.matz@6wind.com> > > Reviewed-by: Didier Pallard <didier.pallard@6wind.com> > > --- > > Acked-by: Anatoly Burakov <anatoly.burakov@intel.com> > > Still, should at least specify Cc: stable, if not Fixes tag too (since > ignoring return value of move_pages() is technically a bug). > +1 At first I was wondering if we should separate the fix from the enhancement, but I suppose backporting both things as one patch is fine too. -- David Marchand