From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D75DA0A0C; Thu, 15 Jul 2021 16:22:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 006A54014D; Thu, 15 Jul 2021 16:22:16 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id DB95440143 for ; Thu, 15 Jul 2021 16:22:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626358934; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qHk2FFBqqBEV/1DHSHa0dyYXQlJV+ztIA72IU317f+M=; b=WSWLx3WLAySPDHOyXzmObbiMuT/oXRdvgyfbAr14gt5brWnpkDZZa6oxa4IvjX/aXo35Mm pMGJGMkaVOpnnU8g4qUOochm4pkfUUwEec7AgK5tclblNal8zPdGpHEAiK8QdisP74X6cQ puVcrkt5L2hfuZoNVgummDwzed2fdvU= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-412-gI_yjXqHNEmyU5RC1JSYMA-1; Thu, 15 Jul 2021 10:22:11 -0400 X-MC-Unique: gI_yjXqHNEmyU5RC1JSYMA-1 Received: by mail-vk1-f200.google.com with SMTP id z125-20020a1fe2830000b029025c947168ffso1494999vkg.16 for ; Thu, 15 Jul 2021 07:22:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qHk2FFBqqBEV/1DHSHa0dyYXQlJV+ztIA72IU317f+M=; b=Dmw8bOLK/Ln15hnF/XAvUTxtisKAkBIWxQeG2b0BCZFXAt4ycbMQJ1wENwl/u67mrW x0i83649iMIS3AoFBKoKxzn7Nj1On0S7kHRmRYYleJfWUUemPX61CL+Aw1Ocr8Adl1rj 6gG35d9MykRAEEkAFnNMviHD7kd/ZR2UUNzjhwXEOWPkKzieZBc5LMB4ZHkgkDxc1x8y BW5x1nIINk2Op93ebqnNJA9kLhsLtqFyRj5gdLzoWMh4m+4jEl6NYwRTQL6P4yN3cXJr v1fRTPiKbwGX8YgmOZCXgTq5Mxvt/F70OsW3ehzuxUPwyI0H20Xf0VPjzltwz1/XHw2E rgSw== X-Gm-Message-State: AOAM532h2S5yylLOGVd1FhXf0dFUiO7iJ6yQ9hf+kxnPr+GCN+IC933G WHQDnp15IHwLWsp43ku8TVy18Vsjw+k1rqLFkuL854LzcPXlNUfaNed0qmLo88kAPg4bYqt7yDt 8T6xX/2VpRQt/qJcSxaw= X-Received: by 2002:a05:6102:21b:: with SMTP id z27mr6811695vsp.18.1626358930496; Thu, 15 Jul 2021 07:22:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx4IPW79LKyBrAYoaDY96dC/g9w/fWh3gIrMUgb/Hot822asyIyC/9i+6ckfO85aq/4dobq8uajA0ZqIJuqI/0= X-Received: by 2002:a05:6102:21b:: with SMTP id z27mr6811666vsp.18.1626358930257; Thu, 15 Jul 2021 07:22:10 -0700 (PDT) MIME-Version: 1.0 References: <2bd2c4be2295105b81843d31c1bcb4dab7e1aff7.1624481225.git.sthotton@marvell.com> In-Reply-To: <2bd2c4be2295105b81843d31c1bcb4dab7e1aff7.1624481225.git.sthotton@marvell.com> From: David Marchand Date: Thu, 15 Jul 2021 16:21:58 +0200 Message-ID: To: Shijith Thotton , Akhil Goyal Cc: dev , Pavan Nikhilesh , Anoob Joseph , Jerin Jacob Kollanukkaran , Abhinandan Gujjar , Ankur Dwivedi , Ray Kinsella , Aaron Conole , dpdklab , Lincoln Lavoie Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 1/2] drivers: add octeontx crypto adapter framework X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello, On Wed, Jun 23, 2021 at 10:54 PM Shijith Thotton wrote: > diff --git a/drivers/event/octeontx/meson.build b/drivers/event/octeontx/meson.build > index 3cb140b4de..0d9eec3f2e 100644 > --- a/drivers/event/octeontx/meson.build > +++ b/drivers/event/octeontx/meson.build > @@ -12,3 +12,4 @@ sources = files( > ) > > deps += ['common_octeontx', 'mempool_octeontx', 'bus_vdev', 'net_octeontx'] > +deps += ['crypto_octeontx'] This extra dependency resulted in disabling the event/octeontx driver in FreeBSD, since crypto/octeontx only builds on Linux. Removing hw support triggers a ABI failure for FreeBSD. - This had been reported by UNH CI: http://mails.dpdk.org/archives/test-report/2021-June/200637.html It seems the result has been ignored but it should have at least raised some discussion. - I asked UNH to stop testing FreeBSD abi for now, waiting to get the main branch fixed. I don't have the time to look at this, please can you work on it? Several options: * crypto/octeontx is made so that it compiles on FreeBSD, * the abi check is extended to have exceptions per OS, * the FreeBSD abi reference is regenerated at UNH not to have those drivers in it (not sure it is doable), Thanks. -- David Marchand