From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EF7B1A10DA for ; Thu, 1 Aug 2019 14:29:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D1A4E1C1DD; Thu, 1 Aug 2019 14:29:33 +0200 (CEST) Received: from mail-ua1-f66.google.com (mail-ua1-f66.google.com [209.85.222.66]) by dpdk.org (Postfix) with ESMTP id C84561C1D8 for ; Thu, 1 Aug 2019 14:29:32 +0200 (CEST) Received: by mail-ua1-f66.google.com with SMTP id g11so1486680uak.0 for ; Thu, 01 Aug 2019 05:29:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=k5Jfbe1zL3LBggxwt2wxMPcLYy2/z1VkxBDcEYgN9jc=; b=KYvozhfFllaoI0FSd68dZrKp59w4nN3+OXkW8UoGN9F7wB6oaCvkIz06GwxUeVc++c 6G2Ygs5vRlEuQ3vGdEiUfQYXj4ejE5zt0Psz2UtRr5Mip1MkDROoPIWYnQ4pucmNA2/Z xC4JIKqQkEkETNieKF72mfXbBHBNgJ8bsqMzfbZRNRnMjtTteJpo6pYR3qytbLkpNr3Q na/ek//9NHU91aE+5UlVjdQdBIU5EgFHXGQTP1dICLgYWdyatqUdBo7uglARb7hTfUkT mwR3VfIe9ZOiwejSpPvFEsKakCRztGFgFkLQ2y7r51NrPd2DvjVrXvNZJkvf840jrZYc /bXA== X-Gm-Message-State: APjAAAXhL9egO+CSTC3CXpsA7KuqzzSy9N5JzYKq9j0h5PlwbxCGRYS+ wLm90BF3ccvrersQglcWZzYXZYQg1oUpqT2z+xgUQBEa X-Google-Smtp-Source: APXvYqzrA/4l3K7fJDNqK6GpLAAu1JTwVgo0Ek7FiHdm+kIcwmoahPRrxZhpbyzb4KCt/MXdZkcsdOC6GNKF7erDLuI= X-Received: by 2002:ab0:6198:: with SMTP id h24mr17762612uan.41.1564662571990; Thu, 01 Aug 2019 05:29:31 -0700 (PDT) MIME-Version: 1.0 References: <1564662465-2925-1-git-send-email-david.marchand@redhat.com> In-Reply-To: <1564662465-2925-1-git-send-email-david.marchand@redhat.com> From: David Marchand Date: Thu, 1 Aug 2019 14:29:21 +0200 Message-ID: To: dev Cc: Aaron Conole , Michael Santana , dpdk stable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] test/eal: do not scan PCI devices for memory tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Aug 1, 2019 at 2:28 PM David Marchand wrote: > > The memory tests currently check that, for normal mode (not legacy mode), > there is no memory left behind when exiting. > > The problem is that if a ethdev port is allocated when scanning pci > devices (even if the driver probe fails like when you have a virtio > management interface attached to the kernel), on exit, dpdk won't free > the associated memory since ethdev never frees the ethdev memzone. > > Workaround this by disabling pci scan. Not entirely happy with this patch. I am open to suggestions :-) > > Fixes: 651cc78f83b5 ("test: fix hugepage file handling in EAL flags autotest") > Fixes: 690fd3577e90 ("test/eal: add cases for in-memory and single-file-segments") > Cc: stable@dpdk.org And we might want to drop stable. -- David Marchand