From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 426DDA0543; Fri, 7 Oct 2022 21:47:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 327A6400D5; Fri, 7 Oct 2022 21:47:15 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 0DCA040042 for ; Fri, 7 Oct 2022 21:47:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665172033; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Z2kA6otTvC+q54O2lT27Q8lvkd9+2tjDhmr2tojwrKk=; b=gnDifTHWPVFP9TYBGA5xBjI2u3/XBIlXcoHUYLUqyE/WpxHjdFhfop8V9EqYGMj3GkL9fK 0SNE6tt2+JLpvVHKTstTM1UH1XO/tnkD9h0rDxAWjusIwsYK/IQaKhtBwq/naeVzH5Mxvk 6Y8Gx6df3OYbciOFPy6qEvpViBu6hBU= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-170-ZweLnwKXMR2AgMprIeIvdQ-1; Fri, 07 Oct 2022 15:47:12 -0400 X-MC-Unique: ZweLnwKXMR2AgMprIeIvdQ-1 Received: by mail-pl1-f200.google.com with SMTP id u5-20020a170902e80500b00178944c46aaso3880164plg.4 for ; Fri, 07 Oct 2022 12:47:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Z2kA6otTvC+q54O2lT27Q8lvkd9+2tjDhmr2tojwrKk=; b=ZzeM4WV3HrPejxGqYM0Ze2bVSkNRkYHbINweNnLdbSD0oseCHtzaLMn9Qv+vHciDUs in/OVXYar6b7Iy7MEPSu2bIttBtx0ktqbi52zRLg54GsPEsNMfNz0L94ZsOq2N0elkD7 L3HyShCy1Z0K3HNxNHKTWU3rYQd4Z0w3wPA7KdwiFubJf/LjHq9YyN0tthpv0qI4ug1G lj/kOHxqI+33dPt4oMuilgC2aNsEA/srU59Fo1Dp3ti0unhOd0jMNqV2wq9xcvV/lL7n kcwr+F9tmXO8nsnsIFQds2xl2G7ZKLxXe35bojh8Ar+PRvRWGNJPchkQKerzJDP9Gk4T Bdbg== X-Gm-Message-State: ACrzQf3W4Qty2rn8QD8+NMYbGSftVdQELoqipMqlrmrBCDH3dMS4Jqc2 bS8NP7ksZypjFrK/uxlUm5XQdm664sDsc2OfALYYnFpi+VvOjVGKBJNuIequbK/Nn2yV97kGD3h 9FJmlnvnCmpWvoP4x23M= X-Received: by 2002:a17:903:2302:b0:178:286c:86a8 with SMTP id d2-20020a170903230200b00178286c86a8mr6366403plh.172.1665172030972; Fri, 07 Oct 2022 12:47:10 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5taQTfvTg0j6uwVVkk/K/LgT5X9StjWs9+OiO+9kHeXTI14FtOG7NTsPu3d8AFmZDKKW/0cJ0u7VpCG4wQTAY= X-Received: by 2002:a17:903:2302:b0:178:286c:86a8 with SMTP id d2-20020a170903230200b00178286c86a8mr6366381plh.172.1665172030671; Fri, 07 Oct 2022 12:47:10 -0700 (PDT) MIME-Version: 1.0 References: <20220525103352.1806937-1-amitprakashs@marvell.com> <20220929114313.1346972-1-amitprakashs@marvell.com> <20220929114313.1346972-2-amitprakashs@marvell.com> In-Reply-To: <20220929114313.1346972-2-amitprakashs@marvell.com> From: David Marchand Date: Fri, 7 Oct 2022 21:46:59 +0200 Message-ID: Subject: Re: [PATCH v5 2/2] mem: telemetry support for system memory information To: Amit Prakash Shukla , Thomas Monjalon , Anatoly Burakov , dmitry.kozliuk@gmail.com Cc: dev@dpdk.org, jerinj@marvell.com, bruce.richardson@intel.com, ciara.power@intel.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Sep 29, 2022 at 1:44 PM Amit Prakash Shukla wrote: > > Changes adds telemetry support to display system memory information, > allocated using calls malloc, calloc, mmap, etc. This patch > is based on malloc_info. This patch adds following endpoints: malloc_info is a GNU extension. It is not available in musl and it breaks compilation in Alpine Linux. So I can't take this patch. > > 1. /sysmem/sys_heap_list > The commands displays the arenas currently in use. > Example: > --> /sysmem/sys_heap_list > {"/sysmem/sys_heap_list": [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10]} > I am unsure about the command names. Those commands are really low level and tied to glibc malloc. It is unlikely we will have an unified naming with other libc/OS. I would prefer another pair of eyes, especially on this patch. Dmitry, Anatoly? -- David Marchand