From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6608242421; Thu, 19 Jan 2023 22:16:52 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2BCA040223; Thu, 19 Jan 2023 22:16:52 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 6F5DF400D5 for ; Thu, 19 Jan 2023 22:16:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674163010; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hOTJxNe+5OWkjHjwqy/DtSrzaZpGyW8DwRrg4sqwzeA=; b=e0C94Ab6rRGhCMdyaA8xDcBdXQ79OQnOsHM1RoriNTr6mg70wHCwFf6fvyCLWWCAFjrEIF X1lb+oosiWUupXgWdekBcp6AeRbx2mavv5rkIFhGMno4+LlBGY7dH3qrthEpVYFyrsq9in WpCHbQCRy4c3x9b8YiggNqrpn8qYNSs= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-177-MyO4w2bJNVqq7H_M7Wm_qQ-1; Thu, 19 Jan 2023 16:16:48 -0500 X-MC-Unique: MyO4w2bJNVqq7H_M7Wm_qQ-1 Received: by mail-pj1-f71.google.com with SMTP id o36-20020a17090a0a2700b00226b4e9895aso1439121pjo.8 for ; Thu, 19 Jan 2023 13:16:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hOTJxNe+5OWkjHjwqy/DtSrzaZpGyW8DwRrg4sqwzeA=; b=7YmgznagDcP71snhVHhnzn8pgbq3kyRFEfJkq2J58KCKjqKVNFYTv1R4Duz6y15Er2 YNnaF07oNdkcmF8QIORAce4xV0ibJl2bFH6k6UCN7NjzkdwH0oXjcQQIhLdFQRLEv4SA Q1twxSUgfWeN95MNQ3LHt75e7QEGVAVAddEuI+a4awuvm64/xrU9KiSc59BeEyLKZwf0 IK3c0u9hC5+Lmah9OzwEYAowYljZz7+seNCxKfy3bHROuf97l2v4+jCDm3fQYaDjZADm ZOH3jnB5Qapejw7WE7x6ipJi4hXWeT81erAqGYJrf+l8jWxBzuEIBdTGAuED8cHvYqqI uzmw== X-Gm-Message-State: AFqh2krNOj3Zr0FPIk/2jGuMXYXBprik2JWJXBQ+JfYelbnipjcfK52E QOCLMKkeu8R1ephKitwJafOzCNujFCGYc+laTxXX2UpS7iMhYYJBi9z3gF4bb4dZA7vDHhWkmbw D3I8+8X7zcgm3pIIv3eQ= X-Received: by 2002:a63:1011:0:b0:4c7:ef33:bbe1 with SMTP id f17-20020a631011000000b004c7ef33bbe1mr1020392pgl.73.1674163007306; Thu, 19 Jan 2023 13:16:47 -0800 (PST) X-Google-Smtp-Source: AMrXdXs0Gj3IIpHJBdht2afgZlHPOdpoQBichcq8+Gk7/D73CbzSOOX9ICdcE3Na67/94NpbI6e9BEdvmfh0gnwP1l4= X-Received: by 2002:a63:1011:0:b0:4c7:ef33:bbe1 with SMTP id f17-20020a631011000000b004c7ef33bbe1mr1020389pgl.73.1674163007031; Thu, 19 Jan 2023 13:16:47 -0800 (PST) MIME-Version: 1.0 References: <20220328121758.26632-1-david.marchand@redhat.com> <20230119184620.3195267-1-david.marchand@redhat.com> <20230119184620.3195267-2-david.marchand@redhat.com> <20230119114202.27f7da80@hermes.local> <20230119203923.GA32536@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> In-Reply-To: <20230119203923.GA32536@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> From: David Marchand Date: Thu, 19 Jan 2023 22:16:35 +0100 Message-ID: Subject: Re: [PATCH v4 1/9] eal: annotate spinlock, rwlock and seqlock To: Tyler Retzlaff Cc: Stephen Hemminger , dev@dpdk.org, maxime.coquelin@redhat.com, chenbo.xia@intel.com, jiayu.hu@intel.com, yuanx.wang@intel.com, xuan.ding@intel.com, Anatoly Burakov , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , David Christensen , Bruce Richardson , Konstantin Ananyev X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jan 19, 2023 at 9:39 PM Tyler Retzlaff wrote: > > On Thu, Jan 19, 2023 at 11:42:02AM -0800, Stephen Hemminger wrote: > > On Thu, 19 Jan 2023 19:46:12 +0100 > > David Marchand wrote: > > > > > +#ifndef __DOXYGEN__ > > > + __rte_exclusive_lock_function(&seqlock->lock) > > > +#endif > > > { > > > > Would be cleaner any required ifdefs was in rte_lock_annotations > > rather than sprinkling the code > > we briefly touched on abstracting annotations in another thread. it > would be favorable if annotations were stashed behind macros that could > be expanded for more than just clang/internal/under doxygen to make > available opportunities to use other annotation dialects that may be > compatible. I am open to abstractions. Do you have pointers for an equivalent functionnality in other compilers/tooling? -- David Marchand