From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B4399A0542; Thu, 13 Feb 2020 15:01:42 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8BC111C020; Thu, 13 Feb 2020 15:01:42 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 8FC791C020 for ; Thu, 13 Feb 2020 15:01:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581602500; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YKN7a67XaKEEGYquJw57FraG8b4DpgQvn1c5SNV9KKs=; b=fZuOLLNhNQ0aCX9k+CfGKCn+HMiLzMjYFjqPKrCHiD3D0qlLcKJkmNrkCFIMm6ndWPAcPF /wXFetL/r9ic5+u2EIdm6o60j6ufoYQHwc5MJs9GxeWU5t3Kbm2xDFyP1V+K4WPu28AtMm eWD2n7dWoT847YHawxRUssaTgekmzmo= Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-180-ywllhhI1MnCsoKyzrvVNUw-1; Thu, 13 Feb 2020 09:01:38 -0500 Received: by mail-ua1-f69.google.com with SMTP id f15so1396251uap.4 for ; Thu, 13 Feb 2020 06:01:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YKN7a67XaKEEGYquJw57FraG8b4DpgQvn1c5SNV9KKs=; b=dUrE0r2yqAloD4VD3BpiN3bT33ZhrnOh/qzCX9P6iVUdJ41YjzkpWmJaYcu6r/4AwI ejLVA/uEx/6meyomDrYB0Hbg9DDuHRklm7NIGvvI6QfUstRzXkv5KIqWhjiH2eV2EZiM cih2D1vZiXv1njZXkital/Zw4rv3FY+ZGa91gcJ+NMSx3yPIWz+owOKD5m5G8BJoumBF Ybm/XloQVXnRudi/lDj8G1WUWrNlsTRxYBh7hNwrErJlrR+dl/ly0nqyMppANMzXZRKo Aya4Ok6fK+qCm/AERFcB9qzhRUaNAlqI2ikZoew0tXXaI+ebqlEC4xVk6YNxgti+EiVe JHgA== X-Gm-Message-State: APjAAAVQWBCPyqIIbmy2faMcX8AZrFGWImTyIpCwJMjStzzrfdwQrkVy QhocCv6Rvje3a1I4bFvAEIQKKhMuFjpZEYPLwKw4t86wVnBHa5DglTeBNIf2rrYKLmUtDY2ZyOf rnTyD9vTFgwAMCQkQ2Ak= X-Received: by 2002:a1f:9d8a:: with SMTP id g132mr2009730vke.39.1581602497443; Thu, 13 Feb 2020 06:01:37 -0800 (PST) X-Google-Smtp-Source: APXvYqwdLHXUulcGLBHDSNS6KrLOp2WiDCyafhP14zWMa/2Z3pk5AdyBRUdyl0K+QOFg+fi5D9GOLjH+NOb1q86HyNw= X-Received: by 2002:a1f:9d8a:: with SMTP id g132mr2009699vke.39.1581602497096; Thu, 13 Feb 2020 06:01:37 -0800 (PST) MIME-Version: 1.0 References: <20200204160156.64773-1-ciara.power@intel.com> <20200207102402.24396-1-ciara.power@intel.com> In-Reply-To: <20200207102402.24396-1-ciara.power@intel.com> From: David Marchand Date: Thu, 13 Feb 2020 15:01:24 +0100 Message-ID: To: Ciara Power Cc: Bruce Richardson , dev , Pawel Modrak , dpdk stable X-MC-Unique: ywllhhI1MnCsoKyzrvVNUw-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2] examples/ioat: fix invalid link status check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Feb 7, 2020 at 11:34 AM Ciara Power wrote: > > The return value of the get link function call was not checked, and > could return a negative value indicating a failure. This meant the > link_status of the link being checked is invalid, because the link was > not filled with data. The return value is now checked, and if the return > value is not 0 for success, the loop continues with the next port. > > To avoid confusion between variable names, the existing retval variable > is renamed to link_status, to better represent its use. > > Coverity issue: 350348 > Fixes: c8e6ceecebc1 ("examples/ioat: add new sample app for ioat driver") > Cc: stable@dpdk.org > > Signed-off-by: Ciara Power Acked-by: Bruce Richardson Applied, thanks. -- David Marchand