Re: [dpdk-dev] [PATCH 21.05] net/virtio: remove duplicate port id from virtio_user

[David Marchand <david.marchand@redhat.com>]

On Wed, Mar 17, 2021 at 9:04 PM Maxime Coquelin
<maxime.coquelin@redhat.com> wrote:
> > diff --git a/drivers/net/virtio/virtio_user/vhost_user.c b/drivers/net/virtio/virtio_user/vhost_user.c
> > index ec2c53c8fb..18ae29eed2 100644
> > --- a/drivers/net/virtio/virtio_user/vhost_user.c
> > +++ b/drivers/net/virtio/virtio_user/vhost_user.c
> > @@ -950,7 +950,8 @@ vhost_user_update_link_state(struct virtio_user_dev *dev)
> >               r = recv(data->vhostfd, buf, 128, MSG_PEEK);
> >               if (r == 0 || (r < 0 && errno != EAGAIN)) {
> >                       dev->net_status &= (~VIRTIO_NET_S_LINK_UP);
> > -                     PMD_DRV_LOG(ERR, "virtio-user port %u is down", dev->port_id);
> > +                     PMD_DRV_LOG(ERR, "virtio-user port %u is down",
> > +                             dev->hw.port_id);
>
> Trivial, but it can fit in a single line, as IIRC, we can go up to 100
> chars now. If you agree, we can fix it while applying, no need to
> resubmit.

Yep, ok for me, thanks.


-- 
David Marchand