From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 16E1945CB1; Fri, 8 Nov 2024 09:51:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0047242F0A; Fri, 8 Nov 2024 09:51:43 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 61EC5402C8 for ; Fri, 8 Nov 2024 09:51:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1731055901; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=309odvqt7uYXDQQco0WGszsCqFGCv8ihajpe7HKOGMc=; b=Dg2E0uO2/v84BQKHG5roXuNyWlJJn5qc47lR2ty4H0jT9wkvWaQAEpQ+KqrkU0Ue8LARb1 oKHp3rdaNsm6rIFRCHDEruogLcJcN40APjW3Jh45wS7e0ZgYFwHH5crkZtwjsbTsc3UY9I p8bjs3UYuiVNBHxUywxbrKTXm+sDMRs= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-402-YJuOcC84PBCZCdm_3QkrHA-1; Fri, 08 Nov 2024 03:51:40 -0500 X-MC-Unique: YJuOcC84PBCZCdm_3QkrHA-1 X-Mimecast-MFC-AGG-ID: YJuOcC84PBCZCdm_3QkrHA Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-53a0b48e8d4so1351264e87.3 for ; Fri, 08 Nov 2024 00:51:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731055899; x=1731660699; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=309odvqt7uYXDQQco0WGszsCqFGCv8ihajpe7HKOGMc=; b=EEqo3r6LvFpf5hOBUQ7hqGZU/GU7JJiHzh5lt5Pg/Rvl9aya3KxdfoZx7pdmlGdgy/ Fq4IiHwm8KAU7A39JR+xxs2wvcYPq3A4OzgCodPKnWTKOiaw9STsSJfym2ntj0UlTg6b o/Iwv7e6ShP2jOyuicLIrajGe5Qi6hnQ0nn9UA+OKSVKkGcfmLJsr3w0PZs/9BLCKwHI W3HInBugfnmUfn/U5UWXfVZxVxQXMWukd56JFn4c+doIjOyT1teQk/iYlWhR9f46GI+z wqA93L1F1L0rV65Ly16j0R4/f/1KIFzYnyxwUzlOWbN1Mfqxby9fpeORAfoPEn7vcqmK /TVQ== X-Gm-Message-State: AOJu0YxVVF+BAxLGeLqSe1vUGi+9k/st+24nYwdyM/W2k+JcFMLCdvMd QpC6HO14PAURTHXxOU6lx545coKzc5HWou6EhIqkJ3I72NZRWGGISxphNLWW4jRjS3oiR/BzfnW /X102wcIZwN7Ft/Zoal+kJRemIMj0r/8K+qYIWuArMRBbeO5CV1bG+fXMl6ec7d4qF69F7/rAFi VXcMsE4LJsZ7Cyv+iG/ApxXLo= X-Received: by 2002:a2e:a90a:0:b0:2ef:17f7:6e1d with SMTP id 38308e7fff4ca-2ff201e74b6mr10013721fa.4.1731055899047; Fri, 08 Nov 2024 00:51:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IEZsyW90R8024VldmIs7H/q4dilY7iT99ftTS4Trlpd12yWlJkUFYc7Z5ZACdijyKen6/h9MR6q0HW0bUTxHOQ= X-Received: by 2002:a2e:a90a:0:b0:2ef:17f7:6e1d with SMTP id 38308e7fff4ca-2ff201e74b6mr10013551fa.4.1731055898601; Fri, 08 Nov 2024 00:51:38 -0800 (PST) MIME-Version: 1.0 References: <20200814173441.23086-1-stephen@networkplumber.org> <20241107205145.2424871-1-david.marchand@redhat.com> In-Reply-To: <20241107205145.2424871-1-david.marchand@redhat.com> From: David Marchand Date: Fri, 8 Nov 2024 09:51:27 +0100 Message-ID: Subject: Re: [PATCH v31 00/12] Log library enhancements To: Stephen Hemminger , Tyler Retzlaff , Andre Muezerie Cc: dev@dpdk.org, Thomas Monjalon X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: pp7FR-Gv2C9PstZP_ya5JWsNIvapYgZBXDo5HGrUBDU_1731055899 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Nov 7, 2024 at 9:52=E2=80=AFPM David Marchand wrote: > > Improvements and unification of logging library. > This version works on all platforms: Linux, Windows and FreeBSD. > > This is update to rework patch set. It adds several new features > to the console log output. > > * Putting a timestamp on console output which is useful for > analyzing performance of startup codes. Timestamp is optional > and must be enabled on command line. > > * Displaying console output with colors. > It uses the standard conventions used by many other Linux commands > for colorized display. The default is to enable color if the > console output is going to a terminal. But it can be always > on or disabled by command line flag. This default was chosen > based on what dmesg(1) command does. > > Color is used by many tools (vi, iproute2, git) because it is helpful= ; > DPDK drivers and libraries print lots of not very useful messages. > And having error messages highlighted in bold face helps. > This might also get users to pay more attention to error messages. > Many bug reports have earlier messages that are lost because > there are so many info messages. > > * Add support for automatic detection of systemd journal > protocol. If running as systemd service will get enhanced > logging. > > * Use of syslog is optional and the meaning of the > --syslog flag has changed. The default is *not* to use > unless requested. > > Add Stephen as maintainer for log because by now have added > more than previous authors. > > > Resending for CI after some small/cosmetic changes: > > Changes since v30: > - added a little helper that identifies log options (this fixed a little > bug with the color option being parsed twice) and > renamed eal_log_level_parse() as eal_parse_log_options(), > - adjusted log level to ALERT for EAL error on Windows, > - split RN updates in relevant patches and fixed style, > - fixed --syslog usage string, > - split and squashed Windows shim update in relevant patches, > - fixed typos, > - cleaned duplicate inclusion of headers, > - moved syslog facility code update in relevant patch, > - removed dead reference to eal_log_set_default, The escape character \e is refused with MSVC. This had been reported as a warning starting v26 iiuc: =3D=3D=3D=3D 20 line log output for Windows Server 2022 (dpdk_msvc_compile)= : =3D=3D=3D=3D ... [ 3 5 / 9 6 ] C o m p i l i n g C o b j e c t l i b / l i b r t e _ l o g . a . p / l o g _ l o g _ c o l o r . c . o b j F A I L E D : l i b / l i b r t e _ l o g . a . p / l o g _ l o g _ c o l o r . c . o b j " c l " " - I l i b \ l i b r t e _ l o g . a . p " " - I l i b " " - I . . \ l i b " " - I . " " - I . . " " - I c o n f i g " " - I . . \ c o n f i g " " - I l i b \ e a l \ i n c l u d e " " - I . . \ l i b \ e a l \ i n c l u d e " " - I l i b \ e a l \ w i n d o w s \ i n c l u d e " " - I . . \ l i b \ e a l \ w i n d o w s \ i n c l u d e " " - I l i b \ e a l \ x 8 6 \ i n c l u d e " " - I . . \ l i b \ e a l \ x 8 6 \ i n c l u d e " " - I l i b \ l o g " " - I . . \ l i b \ l o g " " - I C : \ P r o g r a m F i l e s \ M e l l a n o x \ M L N X _ W i n O F 2 _ D e v X _ S D K \ i n c " " / M D " " / n o l o g o " " / s h o w I n c l u d e s " " / W 3 " " / W X " " / s t d : c 1 1 " " / O 2 " " / G w " " / w d 4 2 4 4 " " / w d 4 2 6 7 " " / w d 4 1 4 6 " " / e x p e r i m e n t a l : c 1 1 a t o m i c s " " / d 1 e x p e r i m e n t a l : t y p e o f " " / e x p e r i m e n t a l : s t a t e m e n t E x p r e s s i o n s " " / F I " " r t e _ c o n f i g . h " " - D _ G N U _ S O U R C E " " - D _ W I N 3 2 _ W I N N T =3D 0 x 0 A 0 0 " " - D A L L O W _ E X P E R I M E N T A L _ A P I " " - D A L L O W _ I N T E R N A L _ A P I " " - D R T E _ L O G _ D E F A U L T _ L O G T Y P E =3D l i b . l o g " " / F d l i b \ l i b r t e _ l o g . a . p \ l o g _ l o g _ c o l o r . c . p d b " / F o l i b / l i b r t e _ l o g . a . p / l o g _ l o g _ c o l o r . c . o b j " / c " . . / l i b / l o g / l o g _ c o l o r . c . . / l i b / l o g / l o g _ c o l o r . c ( 8 6 ) : e r r o r C 2 2 2 0 : t h e f o l l o w i n g w a r n i n g i s t r e a t e d a s a n e r r o r . . / l i b / l o g / l o g _ c o l o r . c ( 8 6 ) : w a r n i n g C 4 1 2 9 : ' e ' : u n r e c o g n i z e d c h a r a c t e r e s c a p e s e q u e n c e . . / l i b / l o g / l o g _ c o l o r . c ( 8 6 ) : w a r n i n g C 4 1 2 9 : ' e ' : u n r e c o g n i z e d c h a r a c t e r e s c a p e s e q u e n c e . . / l i b / l o g / l o g _ c o l o r . c ( 8 8 ) : w a r n i n g C 4 1 2 9 : ' e ' : u n r e c o g n i z e d c h a r a c t e r e s c a p e s e q u e n c e Respinning the series with \033 (that was used until v25) and we should be = good. --=20 David Marchand