From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8BB3F431EE; Tue, 24 Oct 2023 10:46:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 715F5406B8; Tue, 24 Oct 2023 10:46:32 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id B1C79406A2 for ; Tue, 24 Oct 2023 10:46:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698137190; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yca4JouL+3ZgJgouRd4F9jwuBICIvJRILTl99lkTXLE=; b=O4iLVDQITkEytJBpAYI9h6tjkgnlefIE+i1JWWHYIL5bntTyKXPME/loy6TWU9XBM4nmV2 G90D+fBqSJ7nUtp0NdOAyiBuVpsATHbqWigNDXFzPSZf/9+fLIkIYg4DiKgRYMVvIMF8AR mPR83UJX6njpFOQNgtAvEi+TLSJoxb0= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-641-_jg1uBnrMPeX82D9r6HVSg-1; Tue, 24 Oct 2023 04:44:28 -0400 X-MC-Unique: _jg1uBnrMPeX82D9r6HVSg-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2c50257772bso37768251fa.3 for ; Tue, 24 Oct 2023 01:44:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698137067; x=1698741867; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yca4JouL+3ZgJgouRd4F9jwuBICIvJRILTl99lkTXLE=; b=kXynyGKK+ZvJvVGZp9vGPyT3Zfqzyykj/cnvGHb8TTc0ZUZyCHXtmwLm5PIvdd7Qfe XG+57l2DkF+0Rv5ieoEb5TSTI5WM4sPFz0uUahvdgzj/jJbxrtlgIOzCCmJ/xipAbSSv 9L7w4qT1tO1MSDZvQ9YmDJLsz0MgWIMEIPIEGAYA+nI1ZJxGDthEsTjdxXyVcI0Gfsu5 mV6tNFd1kFKtd7EoGWtoZZ7Fq5BOFq5VSyULaSxZdb0cat/gjEHHsqKbDGsa3FqFlO7o UuO4bmERKimjIt5uObk+tfXlpLqe6b63/a/WBr7WevQXqxlJgz21if1P6V1jxdoPXhZT RnNA== X-Gm-Message-State: AOJu0YzqNurzqvxl1BhidzKbeWMxeD+Q+BmJP61xnGG+nBZeH+ThogHw +jOeWrWQdtIJfo4biD0oRUu/raQGJx1I5T+VJJjujn3NpIqSjdYCD9cffYel2wKBoumbAQgJrJX j65ywFiKKeCLC3gtBI5Q= X-Received: by 2002:a2e:a99e:0:b0:2c5:31e6:e8e2 with SMTP id x30-20020a2ea99e000000b002c531e6e8e2mr9001542ljq.25.1698137067201; Tue, 24 Oct 2023 01:44:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IECnwksIV4wLcE723Pd3nQl3uQZ/h/eDGW6kxYhkKL4JZN+vgy8R+whKK6w+YCsyDOen5wx8G1OQZJeT2dEShI= X-Received: by 2002:a2e:a99e:0:b0:2c5:31e6:e8e2 with SMTP id x30-20020a2ea99e000000b002c531e6e8e2mr9001525ljq.25.1698137066876; Tue, 24 Oct 2023 01:44:26 -0700 (PDT) MIME-Version: 1.0 References: <20231023163803.98455-1-radu.nicolau@intel.com> In-Reply-To: From: David Marchand Date: Tue, 24 Oct 2023 10:44:15 +0200 Message-ID: Subject: Re: [PATCH] net/iavf: fix Tx offloading flags check To: Radu Nicolau Cc: "Zhang, Qi Z" , "Wu, Jingjing" , "Xing, Beilei" , "dev@dpdk.org" , "stable@dpdk.org" , Ferruh Yigit , Thomas Monjalon , Akhil Goyal X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Oct 24, 2023 at 10:40=E2=80=AFAM Radu Nicolau wrote: > > > On 24-Oct-23 6:42 AM, Zhang, Qi Z wrote: > > > >> -----Original Message----- > >> From: Radu Nicolau > >> Sent: Tuesday, October 24, 2023 12:38 AM > >> To: Wu, Jingjing ; Xing, Beilei > >> Cc: dev@dpdk.org; Nicolau, Radu ; > >> stable@dpdk.org; Marchand, David > >> Subject: [PATCH] net/iavf: fix Tx offloading flags check > >> > >> Use IAVF_TX_OFFLOAD_MASK flags instead of > >> IAVF_TX_CKSUM_OFFLOAD_MASK. > >> > >> Fixes: 3c715591ece0 ("net/iavf: fix checksum offloading") > >> Cc: stable@dpdk.org > >> Cc: david.marchand@redhat.com > >> > >> Signed-off-by: Radu Nicolau > >> --- > >> drivers/net/iavf/iavf_rxtx.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx= .c index > >> c6ef6af1d8..85f8c141ce 100644 > >> --- a/drivers/net/iavf/iavf_rxtx.c > >> +++ b/drivers/net/iavf/iavf_rxtx.c > >> @@ -2664,7 +2664,7 @@ iavf_build_data_desc_cmd_offset_fields(volatile > >> uint64_t *qw1, > >> l2tag1 |=3D m->vlan_tci; > >> } > >> > >> - if ((m->ol_flags & IAVF_TX_CKSUM_OFFLOAD_MASK) =3D=3D 0) > >> + if ((m->ol_flags & IAVF_TX_OFFLOAD_MASK) =3D=3D 0) > > Not sure if this will break previous fix. > > Could you please provide some clarification regarding the specific offl= oad flags that not in IAVF_TX_CKSUM_OFFLOAD_MASK, but you still don't want = to skip? > > A specific flag is RTE_ETH_TX_OFFLOAD_SECURITY, and because this is not > contained in IAVF_TX_OFFLOAD_MASK the previous fix broke the inline > crypto feature. RTE_ETH_TX_OFFLOAD_SECURITY is a ethdev level flag. This is not supposed to be in a mbuf ol_flags, is it? --=20 David Marchand