From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6782745AAF; Fri, 4 Oct 2024 16:45:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2B42D415D7; Fri, 4 Oct 2024 16:45:56 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 6D9D741153 for ; Fri, 4 Oct 2024 16:45:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728053154; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RkCyV0edlYZ5N5NNsRJ2OkhIJpDFuIQ9PNL5ySQd+Kg=; b=adWkejq8elILToryByRK01qC+Ficv88QgUiCa7/DjA+/id+D1P3l1Z03pYOqTUh3Kb5Dqc MtH3cZ8dSyXc2cB4S2BFUcLYg/Ho12yWBANQP3MpwgtH0Vl4pFttJ3pJbsufC8OhDlx/LX Spaq7lOQ78VepHuYVlk1FQA5nwiZO7U= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-172-D24siCHBMqOZcRlR4VrAHQ-1; Fri, 04 Oct 2024 10:45:52 -0400 X-MC-Unique: D24siCHBMqOZcRlR4VrAHQ-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-53987fc3625so1784634e87.0 for ; Fri, 04 Oct 2024 07:45:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728053151; x=1728657951; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RkCyV0edlYZ5N5NNsRJ2OkhIJpDFuIQ9PNL5ySQd+Kg=; b=kHUVQ7i3qzKKu4LiehIOik1KGzOgNqwVADHSlTDgLGfA98Zhjd/KFjdEvzQmcOEuil ge9cxLbtvNCLDmFCigjy81Q4SQN0hs7ib/vaA2QPJC2xKtY+6GM91MXtZ24AY5JsbSHv By1hTrHthdo9Z/jmjNeFdK6SE2oFKmA1bX5gXWGX0A85g6mPgsU1vJJzqqeZtAjfnJQe WwzhyTznj9hzaVQja3k8RP8phOxVFr/u1Lr2bRtH/y0tOIbqPLXSywOFPuDgidpWjgdU uvpK9txxLgRtAyes1AdmpwJ/mXDq/Y+cs3orGJX+pCemJcnUaVr4kiLCG/JfUva4KfPR 3NxA== X-Gm-Message-State: AOJu0YxOoFgSjlKseZSPtfvd8QdvZrnGQDTVCUDn6nd2uez96dzBn1Ex qBpg2kpAhM7+mLbDqsFL+hmI1L1GfKY24kxguXywk2KWAMCKRoT7v4wnfJJWehJO69ByasEqQjT clUAc0+2SGG0HKT24LyKhwLjzckLJiL99G/yFnqsQkdQ1ZL0eW7+8Eia84hWS4Se/aFGFKk1i85 4YNY8mbqWvmApMMJE= X-Received: by 2002:a05:6512:220d:b0:52c:df6f:a66 with SMTP id 2adb3069b0e04-539ab9f1187mr1790984e87.58.1728053151084; Fri, 04 Oct 2024 07:45:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGt2vilaItJlpUZygSLgTZ+yNc1uwCMfw/kUF/ELa9B3PR3ih6VRMyqyI1msNHarMl0TMC2bclw/4Aum8fYHjI= X-Received: by 2002:a05:6512:220d:b0:52c:df6f:a66 with SMTP id 2adb3069b0e04-539ab9f1187mr1790965e87.58.1728053150647; Fri, 04 Oct 2024 07:45:50 -0700 (PDT) MIME-Version: 1.0 References: <20240906132757.457921-1-bruce.richardson@intel.com> In-Reply-To: <20240906132757.457921-1-bruce.richardson@intel.com> From: David Marchand Date: Fri, 4 Oct 2024 16:45:39 +0200 Message-ID: Subject: Re: [PATCH] eal/x86: fix 32-bit write-combined stores To: Bruce Richardson Cc: dev@dpdk.org, radu.nicolau@intel.com, stable@dpdk.org, Tyler Retzlaff X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Sep 6, 2024 at 3:28=E2=80=AFPM Bruce Richardson wrote: > > The "movdiri" instruction is given as a series of bytes in rte_io.h so > that it works on compilers/assemblers which are unaware of the > instruction. The REX prefix (0x40) on this instruction is invalid for > 32-bit code, causing issues. Thankfully, the prefix is unnecessary in > 64-bit code, since the data size used is 32-bits. > > Fixes: 8a00dfc738fe ("eal: add write combining store") > Cc: stable@dpdk.org > > Signed-off-by: Bruce Richardson Thanks for the fix, and reviews. Applied. --=20 David Marchand