From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8A5FBA0521; Tue, 3 Nov 2020 10:45:56 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 64B1BC832; Tue, 3 Nov 2020 10:45:55 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id E969FC82C for ; Tue, 3 Nov 2020 10:45:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604396751; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rzgcNt8zhpnZgrSpGWmtyzCBSfyWQiJB5c4VCt/Z1nQ=; b=hEFzruY9/qPnrz/LmdMgaI8w8ptkaOO+R44euIN1Ifd0dq8j20nb7q4H4M/Q4UPQvqTuUt 6V1BiZrlgwio7AmjyIgEwnY6RlIK0rbf1syf8P0cebjYgTKVDzyevPZ/cgxVcQHqDUNGqY +PR4W0f51KelzMh+ID6eHWJM72606PM= Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-189-jw7d2xhwOUSrGPA-Vmm5aQ-1; Tue, 03 Nov 2020 04:45:50 -0500 X-MC-Unique: jw7d2xhwOUSrGPA-Vmm5aQ-1 Received: by mail-vs1-f69.google.com with SMTP id n126so6006118vsn.22 for ; Tue, 03 Nov 2020 01:45:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rzgcNt8zhpnZgrSpGWmtyzCBSfyWQiJB5c4VCt/Z1nQ=; b=WAWC3YapxKZUNVjZ4PKLHdFIPZun+9jMEQx24McutKDv7srXzjKjL3pIQg7LsNeWBI ndECVo8/EgXYKDV1RQHYgZH2d03oVHLE+xktFDeAGHaoZVcAHoQnH2I/67cGhhvHir5C e34pmlqQE5uX5EGB7DmwaJyj3xfTj0SFA+AIbo7UTBoovxyWrU18+D6qNbe2QBkPYOR1 yIrM3SaLWtPS9OPt2DwSqc80w7wBf7qaxWOFAJfZNKVfeQBXOUJVmJT09+Fq0OfEfuez 8vUoUqxAZpG2rnUaDFe2GjapE7jtIm7Jn4gQH54QSt9mGEhdDj2bjsV3Wqw+LEfvBbO4 VbYQ== X-Gm-Message-State: AOAM530mHNag1MGxL/tZ0+PbdE/ZGKAL2Qw3b8FuTIe6aNIwZZp1B4H4 AHoOKSyc6i0UiHn+QL7Cq6RYYP+MoPQ3WILfiQtCTOZZldk73RIEZsj2rqxOWiIidmA3SzQ/94T xEnn1v0WbZxNt+mH8jGU= X-Received: by 2002:a1f:d205:: with SMTP id j5mr11241525vkg.9.1604396749502; Tue, 03 Nov 2020 01:45:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJyBxNE5ACrJj9/BVKy+R/QnJuzKfr1e7O19gtNEGhmKZtyiydXWDW/cQwv307FoXpvNUNDyUkNSgEu5+1xJtmc= X-Received: by 2002:a1f:d205:: with SMTP id j5mr11241515vkg.9.1604396749252; Tue, 03 Nov 2020 01:45:49 -0800 (PST) MIME-Version: 1.0 References: <20201102174507.1085128-1-bruce.richardson@intel.com> <4495149.WBtOTWmHy8@thomas> <2238783.mFnA29xreC@thomas> In-Reply-To: From: David Marchand Date: Tue, 3 Nov 2020 10:45:37 +0100 Message-ID: To: Thomas Monjalon Cc: Bruce Richardson , dev , Guy Kaneti , Luca Boccassi , Rosen Xu , Andrew Rybchenko Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 1/8] regex/octeontx2: fix unnecessary name override X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Nov 3, 2020 at 10:19 AM David Marchand wrote: > > On Tue, Nov 3, 2020 at 10:06 AM Thomas Monjalon wrote: > > > > 03/11/2020 09:19, David Marchand: > > > On Tue, Nov 3, 2020 at 1:30 AM Thomas Monjalon wrote: > > > > > > -name = 'octeontx2_regex' > > > > > > > > But it is not the same? > > > > > > > > The name will default to "octeontx2", which is fine. > > > > But the fmt_name should not take this default. > > > > I believe fmt_name should be "octeontx2_regex" as I did in my patch. > > > > > > fmt_name is only for maintaining config compat. > > > This driver is new to 20.11. > > > We can drop fmt_name too. > > > > If we don't set fmt_name, it defaults to "name", "octeontx2" here. > > What is the consequence in compat definitions? > Ok, got it, the problem is when we disable the net/octeontx2 driver. Your patch correctly sets a RTE_LIBRTE_OCTEONTX2_REGEX_PMD compat option that is unused but that does not overwrite the RTE_LIBRTE_OCTEONTX2_PMD compat option (which indicates the presence of the net/octeontx2 driver). -- David Marchand