From: David Marchand <david.marchand@redhat.com>
To: "Van Haaren, Harry" <harry.van.haaren@intel.com>
Cc: dev <dev@dpdk.org>, Aaron Conole <aconole@redhat.com>,
dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] eal/service: fix exit by resetting service lcores
Date: Thu, 12 Mar 2020 09:59:53 +0100 [thread overview]
Message-ID: <CAJFAV8xJNB2KVjTfE_OnesNyk=S9hnPa6hz6hEd-hTH1TkTKJQ@mail.gmail.com> (raw)
In-Reply-To: <MWHPR1101MB21575ECFB47831F8DE513465D7FC0@MWHPR1101MB2157.namprd11.prod.outlook.com>
Hello,
On Wed, Mar 11, 2020 at 5:21 PM Van Haaren, Harry
<harry.van.haaren@intel.com> wrote:
> Issue was that service cores can remain running while main thread
> has freed service-core memory, later racy return of service lcore
> then causes use-after-free.
>
> This commit fixes it by
> A) resetting all service cores to return
> B) waiting for them to return
> C) freeing memory
>
> I am confident in the fix.
Ok.
> > > a race-condition on eal_cleanup(), where the service core
> > > could still be executing while the main thread has already
> > > free-d the service memory, leading to a segfault.
> > >
> > > Fixes: 21698354c832 ("service: introduce service cores concept")
The race per se was introduced with:
da23f0aa87d8 ("service: fix memory leak with new function")
--
David Marchand
next prev parent reply other threads:[~2020-03-12 9:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 13:33 [dpdk-dev] [PATCH] " Harry van Haaren
2020-03-10 16:31 ` David Marchand
2020-03-10 16:38 ` Van Haaren, Harry
2020-03-10 17:44 ` Aaron Conole
2020-03-10 19:14 ` Aaron Conole
2020-03-11 9:09 ` David Marchand
2020-03-11 14:39 ` [dpdk-dev] [PATCH v2] " Harry van Haaren
2020-03-11 16:15 ` David Marchand
2020-03-11 16:21 ` Van Haaren, Harry
2020-03-12 8:59 ` David Marchand [this message]
2020-03-11 17:08 ` Aaron Conole
2020-03-12 9:03 ` David Marchand
2020-03-13 10:04 ` David Marchand
2020-04-06 10:30 ` Burakov, Anatoly
2020-04-14 13:22 ` Aaron Conole
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8xJNB2KVjTfE_OnesNyk=S9hnPa6hz6hEd-hTH1TkTKJQ@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=aconole@redhat.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).