From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 00E22A04BC; Thu, 8 Oct 2020 17:19:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3C51E1C196; Thu, 8 Oct 2020 17:19:56 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 96BD41C190 for ; Thu, 8 Oct 2020 17:19:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602170392; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QtT/+ExzF11Ua5SerERwNq5i2J2rZAh5b2IuA5GNi8o=; b=StQb1yWrCDagPYiemB4Hnvu3Zu+GmESArcstGF2KAUTz3nNsNbEqAafCvZSKigy/KEmNSc AD56MHQiF9v/+1+5qCrs5903fLOQKeceKA8syzRkTHzjPqmMjCaMr4xUjVf14SsNDpU6Su w31lQYs1ZDmTJSHprNtpPt6L5pmT0ow= Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-144-pkrHeYO6MEmfKqSBC979vg-1; Thu, 08 Oct 2020 11:19:50 -0400 X-MC-Unique: pkrHeYO6MEmfKqSBC979vg-1 Received: by mail-vs1-f69.google.com with SMTP id 124so839886vss.1 for ; Thu, 08 Oct 2020 08:19:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=QtT/+ExzF11Ua5SerERwNq5i2J2rZAh5b2IuA5GNi8o=; b=nIxd6NrekzwzwJaDqnWMDBvXVH5CuNeaEwapzH5Rjuc0D+Tan79Gmkfw8Y0mnHkghR mQEc2BvmNzlYs/a2cOn/Ga0+H178iq8Ek/c85U+nSpe9iwRAlnLH0PFq0OqtVXgwCFKl V1qt83SKTrSEDCoK/xUYnLYHMSyLC4V+HZnsnYyMXqmTMhqw1I9hToDC9taAljoqdWhK JWGc5kqzeKA/xaUDnKMtI9kahDSjgSD3WssdNcEDwce4+yXHvWr1vK23M+dprbIJwVXf pgdDpJPhTJ5tC6bG68YexLJX8J1NdAEa3tIcE7sAwryo5ziL9HW+k4otgd3nI2QP3cUd 5EWQ== X-Gm-Message-State: AOAM531+xP5zKRyjV10ro3H2vu7sRuyqYC6++3qe/799gQUiZZCGninT qKRDF6nqgmTmCTQoYdV2q5S7YetPVPnZ+MnPV2A38hQP/Ti/R1rnGlqt3EmRSMeF4Ay1HNRIF9v MjVGlEKlu0MobDA1iMpw= X-Received: by 2002:a05:6102:5d:: with SMTP id k29mr5115985vsp.17.1602170389741; Thu, 08 Oct 2020 08:19:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwbb7+gCHfhNNJV+Ds+e7o/Vx6mQSoh2vTM3QesGd7aB0UwnKYVHSIcZOWf6XVHGgNEc8rapCuP9iB5ycDVbl8= X-Received: by 2002:a05:6102:5d:: with SMTP id k29mr5115968vsp.17.1602170389489; Thu, 08 Oct 2020 08:19:49 -0700 (PDT) MIME-Version: 1.0 References: <20200807155859.63888-1-ciara.power@intel.com> <20200930130415.11211-1-ciara.power@intel.com> <20200930130415.11211-19-ciara.power@intel.com> In-Reply-To: <20200930130415.11211-19-ciara.power@intel.com> From: David Marchand Date: Thu, 8 Oct 2020 17:19:38 +0200 Message-ID: To: Ciara Power Cc: dev , Bruce Richardson , Vladimir Medvedkin , Jerin Jacob , Ruifeng Wang Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v3 18/18] lpm: choose vector path at runtime X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Sep 30, 2020 at 3:14 PM Ciara Power wrote: > > When choosing the vector path, max SIMD bitwidth is now checked to > ensure a vector path is allowable. To do this, rather than the vector > lookup functions being called directly from apps, a generic lookup > function is called which will call the vector functions if suitable. > > Signed-off-by: Ciara Power Got a build error on this patch with ./devtools/test-meson-builds.sh ("gcc-shared" target): [2/3] Compiling C object 'examples/c590b3c@@dpdk-l3fwd-thread@exe/performance-thread_l3fwd-thread_ma= in.c.o'. FAILED: examples/c590b3c@@dpdk-l3fwd-thread@exe/performance-thread_l3fwd-th= read_main.c.o ccache gcc -Iexamples/c590b3c@@dpdk-l3fwd-thread@exe -Iexamples -I../../dpdk/examples -Iexamples/performance-thread/l3fwd-thread -I../../dpdk/examples/performance-thread/l3fwd-thread -I../../dpdk/examples/performance-thread/l3fwd-thread/../common -I../../dpdk/examples/performance-thread/l3fwd-thread/../common/arch/x86 -I. -I../../dpdk/ -Iconfig -I../../dpdk/config -Ilib/librte_eal/include -I../../dpdk/lib/librte_eal/include -Ilib/librte_eal/linux/include -I../../dpdk/lib/librte_eal/linux/include -Ilib/librte_eal/x86/include -I../../dpdk/lib/librte_eal/x86/include -Ilib/librte_eal/common -I../../dpdk/lib/librte_eal/common -Ilib/librte_eal -I../../dpdk/lib/librte_eal -Ilib/librte_kvargs -I../../dpdk/lib/librte_kvargs -Ilib/librte_telemetry/../librte_metrics -I../../dpdk/lib/librte_telemetry/../librte_metrics -Ilib/librte_telemetry -I../../dpdk/lib/librte_telemetry -Ilib/librte_mempool -I../../dpdk/lib/librte_mempool -Ilib/librte_ring -I../../dpdk/lib/librte_ring -Ilib/librte_net -I../../dpdk/lib/librte_net -Ilib/librte_mbuf -I../../dpdk/lib/librte_mbuf -Ilib/librte_ethdev -I../../dpdk/lib/librte_ethdev -Ilib/librte_meter -I../../dpdk/lib/librte_meter -Ilib/librte_cmdline -I../../dpdk/lib/librte_cmdline -Ilib/librte_timer -I../../dpdk/lib/librte_timer -Ilib/librte_lpm -I../../dpdk/lib/librte_lpm -Ilib/librte_hash -I../../dpdk/lib/librte_hash -Ilib/librte_rcu -I../../dpdk/lib/librte_rcu -I/home/dmarchan/intel-ipsec-mb/install/include -fdiagnostics-color=3Dalways -pipe -D_FILE_OFFSET_BITS=3D64 -Wall -Winvalid-pch -Werror -O2 -g -include rte_config.h -Wextra -Wcast-qual -Wdeprecated -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-address-of-packed-member -Wno-packed-not-aligned -Wno-missing-field-initializers -D_GNU_SOURCE -march=3Dnative -Wno-format-truncation -DALLOW_EXPERIMENTAL_API -MD -MQ 'examples/c590b3c@@dpdk-l3fwd-thread@exe/performance-thread_l3fwd-thread_ma= in.c.o' -MF 'examples/c590b3c@@dpdk-l3fwd-thread@exe/performance-thread_l3fwd-threa= d_main.c.o.d' -o 'examples/c590b3c@@dpdk-l3fwd-thread@exe/performance-thread_l3fwd-thread= _main.c.o' -c ../../dpdk/examples/performance-thread/l3fwd-thread/main.c #=E2=80=98target_mem_ref=E2=80=99 not supported by expression#=E2=80=99In f= ile included from ../../dpdk/examples/performance-thread/l3fwd-thread/main.c:133: ../../dpdk/examples/performance-thread/l3fwd-thread/main.c: In function =E2=80=98process_burst=E2=80=99: ../../dpdk/lib/librte_lpm/rte_lpm.h:435:7: error: may be used uninitialized in this function [-Werror=3Dmaybe-uninitialized] 435 | if (rte_lpm_lookup(lpm, ((uint32_t *) &ip)[i], &hop[i]) < 0) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors ninja: build stopped: subcommand failed. gcc (GCC) 9.3.1 20200408 (Red Hat 9.3.1-2) --=20 David Marchand