From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id DC7AAA046B
for <public@inbox.dpdk.org>; Fri, 28 Jun 2019 10:38:55 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 0F23B4C93;
Fri, 28 Jun 2019 10:38:54 +0200 (CEST)
Received: from mail-vs1-f68.google.com (mail-vs1-f68.google.com
[209.85.217.68]) by dpdk.org (Postfix) with ESMTP id 12CD4378E
for <dev@dpdk.org>; Fri, 28 Jun 2019 10:38:52 +0200 (CEST)
Received: by mail-vs1-f68.google.com with SMTP id l125so3496493vsl.13
for <dev@dpdk.org>; Fri, 28 Jun 2019 01:38:52 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=I97w/VNZ3h9IISxvHPwZt2VJrgfQfIpdaZKdXaCELJo=;
b=iwOzao/AKZgnXFDtsvRQQpPBhwKLCFEsyJvIIGdrV82LhqRG2B8e9evNxWCFo7UjDU
+VlLWFlHt6ORDC7Gh5yh9C7LlS4+IZGtP/3WDqMnvA4wL5hoxdgsroHIgsRtu+1Z6Hid
D08TntUtNf524H+04Tn32iY4fxY4QHTjwDGP/toesZHnwQJ4HC7ewlLqsGCdSbQph8h2
0GqmXp+8ai+c1POjJS0BwOfxhUdXRR4u6NRXdIoLA4C+h/t4rVaS3D5Q0vak/mVslKYX
IHO86PabSJHv86YOzdXt9JEB20VSGlaRMKGt64doiah6kzYJoqhTyEJUHD9cfbk6MnAg
ZFZA==
X-Gm-Message-State: APjAAAWLKMKFqM6xaVDPb8yHa64azj7aC+VV+c2tpfPov61hN5oKz2jz
Icwm2y474rgHFjKvEiHCPikojkYnSxmD//w9VAyWp7JB
X-Google-Smtp-Source: APXvYqznrkKj19E//b/LsdBWYWVJzjquYDql+e6EeC8O7M4/6dqe+ZiTENcgwXwIp1a1khMQYilel0zFDBkp9ozdvkM=
X-Received: by 2002:a67:2ec8:: with SMTP id u191mr5875156vsu.39.1561711131457;
Fri, 28 Jun 2019 01:38:51 -0700 (PDT)
MIME-Version: 1.0
References: <20190627032420.4730-1-honnappa.nagarahalli@arm.com>
<20190628045254.17614-1-honnappa.nagarahalli@arm.com>
<20190628045254.17614-3-honnappa.nagarahalli@arm.com>
In-Reply-To: <20190628045254.17614-3-honnappa.nagarahalli@arm.com>
From: David Marchand <david.marchand@redhat.com>
Date: Fri, 28 Jun 2019 10:38:40 +0200
Message-ID: <CAJFAV8xK+mZEzpZwROXRBf62-oQ66py2L4D=bSh4Yu2a5Y9jDA@mail.gmail.com>
To: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Cc: "Wang, Yipeng1" <yipeng1.wang@intel.com>, "Gobriel,
Sameh" <sameh.gobriel@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>,
Dharmik Thakkar <dharmik.thakkar@arm.com>, dev <dev@dpdk.org>, nd <nd@arm.com>,
dpdk stable <stable@dpdk.org>
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2 3/3] test/hash: free
allocated memory
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Fri, Jun 28, 2019 at 6:53 AM Honnappa Nagarahalli <
honnappa.nagarahalli@arm.com> wrote:
> Free allocated memory.
>
> Fixes: 3f9aab961ed3 ("test/hash: check lock-free extendable bucket")
> Cc: stable@dpdk.org
>
> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Reviewed-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
> ---
> app/test/test_hash_readwrite_lf.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/app/test/test_hash_readwrite_lf.c
> b/app/test/test_hash_readwrite_lf.c
> index 12522e265..9b054dec0 100644
> --- a/app/test/test_hash_readwrite_lf.c
> +++ b/app/test/test_hash_readwrite_lf.c
>
>
[snip]
@@ -653,6 +656,8 @@ test_rwc_reader(__attribute__((unused)) void *arg)
> cycles = rte_rdtsc_precise() - begin;
> rte_atomic64_add(&gread_cycles, cycles);
> rte_atomic64_add(&greads, read_cnt*loop_cnt);
> +
> + rte_free(pos);
> return 0;
> }
>
In this function, there are three other places returning -1 without freeing
pos.
--
David Marchand