From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C160746000; Thu, 23 Jan 2025 15:17:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A73AD40A73; Thu, 23 Jan 2025 15:17:26 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 4286F40261 for ; Thu, 23 Jan 2025 15:17:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737641844; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0UyTeYkzJg6lFCXaiy46YSWnrtBmJy9gxy+LU5GRS00=; b=WT46XY7wSe2IRUdUAhxLlM492VAP04wN2KVT/r5TXotiPp3jCGo+f40YlMUuqSiAc92PLT lpPxt+P7njLE4z56aFlLxX+iDz4vkyTXWezyf7ca2fNMQe7CMa9NU7jPUpX+cPQsNTml0M +fWq5vkJTBNuIptV6H8gTJP8em9CxOg= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-177-UpCTjck1MPW1a4hMwH-Ayg-1; Thu, 23 Jan 2025 09:17:22 -0500 X-MC-Unique: UpCTjck1MPW1a4hMwH-Ayg-1 X-Mimecast-MFC-AGG-ID: UpCTjck1MPW1a4hMwH-Ayg Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-3021cdd76b5so4422541fa.1 for ; Thu, 23 Jan 2025 06:17:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737641841; x=1738246641; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0UyTeYkzJg6lFCXaiy46YSWnrtBmJy9gxy+LU5GRS00=; b=R/8WErBYRmw3vXRpuDhWLXy/k+mXznhk4qaIEoSpNnO2Dbnj8RUXmd+JlqSDwIif8v aZd5xLH3RNqd6EdPWliwADKfADwbL9Sgmg0tVa6FLjic2lN2ul7a4xAVuQaHCqvNEh82 gRZuWlhjTaPa8tqbQLEAkrcv7qbEFS7JcowQjmf5+dun3i7HBYUF5s56U2NQHRwLyLsM 5rfti7ojFUzCq3zEF6f9KblMhYycq+ZaxTTpnoOOrQI0roT+0uORiS6J1DayM18UOEsG gnRTo9XLl6IMPLVJO9DqBIlQZIPIPEfIk+f7ND3Nb5GNdOJEbM9wexujgmffc57CNgnS YUnw== X-Gm-Message-State: AOJu0Yysetvzq1qTWoq1GpenrV/R5m+y/aJB7M6lFFGW6i0KfJouAw+V M+6W/i6Qx13Ry04AmQ0poP79s6SNqo47R+AjZ0KUHysQqDPfaiDM0QiJYo8IslIEyCxNUtbRmcY Dyb6TRK1UfWmxdst1kWD+TZjHo1brQUkJIFU0/ZpohtF0X9kVC52QfUtF9CU7TudJv1Zd746wnm ttgFBoxCcF2AnmhaPHR5SMe9A= X-Gm-Gg: ASbGnct5ta5goYK7QYygSSidMjs3GxsRY/Q87OewjNe+6TfaL19jBNi1Jaj2W21PGpp r2M/+KFcnWGcRWsu87FEo68uRc4NxvNDTSRJzk9fkbz+ZJKKvmcSAGQ== X-Received: by 2002:a2e:bc83:0:b0:302:1cdd:73c6 with SMTP id 38308e7fff4ca-3072ca97f28mr113272771fa.20.1737641840949; Thu, 23 Jan 2025 06:17:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IH1qoMO7/b2gPfLbYzqiWvBGqsOXEKKoKVr5h5VdC9p4ykNNb3jy2C1U0DEj5NN+7ikEeuuq8lMGEqwPOOO4VM= X-Received: by 2002:a2e:bc83:0:b0:302:1cdd:73c6 with SMTP id 38308e7fff4ca-3072ca97f28mr113272621fa.20.1737641840540; Thu, 23 Jan 2025 06:17:20 -0800 (PST) MIME-Version: 1.0 References: <20241122125418.2857301-1-bruce.richardson@intel.com> <20250120120016.1530274-1-bruce.richardson@intel.com> <20250120120016.1530274-3-bruce.richardson@intel.com> In-Reply-To: <20250120120016.1530274-3-bruce.richardson@intel.com> From: David Marchand Date: Thu, 23 Jan 2025 15:17:08 +0100 X-Gm-Features: AbW1kvYPXDM246O-lY36UpciI9OP75MSZ42Qsrk4PFQY1rSoW9LPX1wD-tcNR3g Message-ID: Subject: Re: [PATCH v5 02/25] net/intel/common: add pkt reassembly fn for intel drivers To: Bruce Richardson , Thomas Monjalon Cc: dev@dpdk.org, Ian Stokes , Vladimir Medvedkin , Anatoly Burakov X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: CR4k9HopUOw26GRgAJ-autZkT_mGBrGikLFxbMsxGJk_1737641841 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jan 20, 2025 at 1:00=E2=80=AFPM Bruce Richardson wrote: > > The code for reassembling a single, multi-mbuf packet from multiple > buffers received from the NIC is duplicated across many drivers. Rather > than having multiple copies of this function, we can create an > "intel/common" directory to hold such functions and consolidate > multiple functions down to a single one for easier maintenance. > > Signed-off-by: Bruce Richardson The new drivers/net/intel/common directory is an orphan. Please add it to MAINTAINERS. An alternative: to avoid such miss in the future, it could be worth having a dedicated block in MAINTAINERS for drivers/net/intel/ with subtree set to next-net-intel and an associated subtree maintainer name, then move all Intel drivers in this block. Thomas, opinion? --=20 David Marchand